[MINOR] refactor(image): Fix Docker image build error #532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code Coverage Report
|
|
@xunliu please take a look. |
xunliu
reviewed
Oct 18, 2023
jerryshao
approved these changes
Oct 18, 2023
jerryshao
pushed a commit
that referenced
this pull request
Oct 26, 2023
### What changes were proposed in this pull request? Clarify `--image` and `--tag` options in the build Docker image script ### Why are the changes needed? `--image` with tag value will bring errors and confusion ### Does this PR introduce _any_ user-facing change? usage of Docker image build command changed ### How was this patch tested? tested locally and pushed the latest built image to the Docker hub
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Clarify
--imageand--tagoptions in the build Docker image scriptWhy are the changes needed?
--imagewith tag value will bring errors and confusionDoes this PR introduce any user-facing change?
usage of Docker image build command changed
How was this patch tested?
tested locally and pushed the latest built image to the Docker hub