[#5070] improvement(core): Add check for the full name of the metadata object #5075
+241
−134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerqi
changed the title
jerqi
requested review from
jerryshao and
yuqi1129
and removed request for
jerryshao
xunliu
reviewed
Oct 10, 2024
Comment on lines
427
to
429
| void checkAndImportEntity(String metalake, MetadataObject metadataObject, GravitinoEnv env) { | ||
| MetadataObjectUtil.checkMetadataObject(metalake, metadataObject, env); | ||
| } |
There was a problem hiding this comment.
The checkAndImportEntity(...) function only have one line code.
We can directly call MetadataObjectUtil.checkMetadataObject(metalake, metadataObject, env).
There was a problem hiding this comment.
This is convenient to test. Because we can spy this method easily.
Comment on lines
119
to
120
| public static void checkMetadataObject(String metalake, MetadataObject object, GravitinoEnv env) { | ||
| NameIdentifier identifier = toEntityIdent(metalake, object); |
There was a problem hiding this comment.
I think we doesn't need GravitinoEnv env params in the checkMetadataObject(...) function.
We can directly call GravitinoEnv.getInstance() in the function body.
There was a problem hiding this comment.
Using env as a method parameter will make the mock test easy to achieve.
yuqi1129
reviewed
Oct 10, 2024
| } | ||
| break; | ||
|
|
||
| case COLUMN: |
There was a problem hiding this comment.
Do we support checking columns or not? If the answer is 'No', you can remove case COLUMN: here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add check for full name of the metadata object.
Why are the changes needed?
Fix: #5070
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Add UTs.