Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#5051] GravitinoClient needs metalake to obtain version #5060

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

lsyulong
Copy link
Contributor

@lsyulong lsyulong commented Oct 3, 2024

What changes were proposed in this pull request?
[Improvement] GravitinoClient needs metalake to obtain version

Why are the changes needed?

Fix: #5051

Does this PR introduce any user-facing change?
No

@justinmclean
Copy link
Member

Thanks for your contribution. There are a couple of unnecessary changes to the documentation here, can you please fix those? It also looks like you using an old branch, it would be best to use a new branch off the main one.

@lsyulong
Copy link
Contributor Author

lsyulong commented Oct 7, 2024

Thanks for your contribution. There are a couple of unnecessary changes to the documentation here, can you please fix those? It also looks like you using an old branch, it would be best to use a new branch off the main one.感谢您的贡献。这里的文档有一些不必要的更改,您能修复这些吗?它看起来也像您使用旧分支,最好使用主分支之外的新分支。

Hello, I didn't quite understand what it meant. Can you explain it to me

@justinmclean
Copy link
Member

Your PR include changes to apache-hive-catalog.md and a couple of other .md documentation files, these changes are not related to the issue and should not be in the PR. Your branch is also 3 months out of date, it would be best to base your PR on a newer branch.

@lsyulong
Copy link
Contributor Author

Your PR include changes to apache-hive-catalog.md and a couple of other .md documentation files, these changes are not related to the issue and should not be in the PR. Your branch is also 3 months out of date, it would be best to base your PR on a newer branch.您的 PR 包括对 apache-hive-catalog.md 和其他几个 .md 文档文件的更改,这些更改与问题无关,不应出现在 PR 中。你的分支也已经过期 3 个月了,最好将你的 PR 建立在较新的分支上。

Hello, I am unable to use a specific commit file specified in the submitted PR. Can you help me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improvement] GravitinoClient needs metalake to obtain version
2 participants