[#480] test(lakehouse-iceberg): add hive catalog to IcebergRESTServiceIT #493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code Coverage Report
|
|
Is it still in draft? |
it's ready to review now, some Jdbc configs are commented in this PR. |
FANNG1
commented
Oct 12, 2023
...datastrato/graviton/integration/test/catalog/lakehouse/iceberg/IcebergRESTServiceBaseIT.java
Outdated
Show resolved
Hide resolved
jerryshao
changed the title
jerryshao
reviewed
Oct 12, 2023
integration-test/src/main/java/com/datastrato/graviton/integration/test/util/ITUtils.java
Outdated
Show resolved
Hide resolved
jerryshao
reviewed
Oct 12, 2023
...datastrato/graviton/integration/test/catalog/lakehouse/iceberg/IcebergRESTServiceBaseIT.java
Outdated
Show resolved
Hide resolved
yuqi1129
reviewed
Oct 13, 2023
...rc/main/java/com/datastrato/graviton/catalog/lakehouse/iceberg/utils/IcebergCatalogUtil.java
Outdated
Show resolved
Hide resolved
yuqi1129
reviewed
Oct 13, 2023
...datastrato/graviton/integration/test/catalog/lakehouse/iceberg/IcebergRESTServiceBaseIT.java
Show resolved
Hide resolved
...datastrato/graviton/integration/test/catalog/lakehouse/iceberg/IcebergRESTServiceBaseIT.java
Show resolved
Hide resolved
yuqi1129
reviewed
Oct 16, 2023
...datastrato/graviton/integration/test/catalog/lakehouse/iceberg/IcebergRESTHiveCatalogIT.java
Outdated
Show resolved
Hide resolved
yuqi1129
reviewed
Oct 16, 2023
...datastrato/graviton/integration/test/catalog/lakehouse/iceberg/IcebergRESTServiceBaseIT.java
Show resolved
Hide resolved
integration-test/src/main/java/com/datastrato/graviton/integration/test/util/ITUtils.java
Outdated
Show resolved
Hide resolved
...datastrato/graviton/integration/test/catalog/lakehouse/iceberg/IcebergRESTHiveCatalogIT.java
Outdated
Show resolved
Hide resolved
|
I'm OK with the current code, just address some of the comments left by @yuqi1129 |
jerryshao
approved these changes
Oct 17, 2023
|
@sandflee Do you have other PRs for issue #480? like support JDBC catalog. |
|
Our dev process is that one issue relates to one PR. I would suggest modify #480 to reflect the work you done here in this PR. And create a new issue and PR to do JDBC support. |
jerryshao
pushed a commit
that referenced
this pull request
Oct 26, 2023
…eIT (#493) ### What changes were proposed in this pull request? add hive catalog to IcebergRESTServiceIT 1. custom graviton config file with different Iceberg catalog types 2. The hive catalog warehouse location is using localfs to bypass HDFS 3. unify test namespace to `iceberg_rest_` prefix, to drop all test namespace and tables before each test. ### Why are the changes needed? Part of: #480 ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? 1. existing UTs 4. HiveCatalog UTs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
add hive catalog to IcebergRESTServiceIT
iceberg_rest_prefix, to drop all test namespace and tables before each test.Why are the changes needed?
Part of: #480
Does this PR introduce any user-facing change?
No
How was this patch tested?