[#445] feat(lakehouse-iceberg): support load HDFS config files for Iceberg REST server #468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code Coverage Report
Files
|
|
By the way, we should consider adding some UTs to verify its effectiveness, such as we can read configuration contents. |
yuqi1129
reviewed
Oct 9, 2023
core/src/main/java/com/datastrato/graviton/utils/IsolatedClassLoader.java
Outdated
Show resolved
Hide resolved
|
@jerryshao @yunqing-wei , please help to review this pr |
|
Why do we remove ".template" suffix for hdfs and hive conf file? |
fixed |
jerryshao
approved these changes
Oct 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
support load HDFS config files for Iceberg REST server, support multiple classpath for
graviton.auxService.iceberg-rest.classpath, such ascatalogs/lakehouse-iceberg/libs, catalogs/lakehouse-iceberg/confWhy are the changes needed?
HDFS configs are complicated, we should put
core-site.xmlandhdfs-site.xmlto the classpathFix: #445
Does this PR introduce any user-facing change?
no
How was this patch tested?