[#396] feat(CI): Accessing HDFS from outside the graviton-ci-hive Docker #398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code Coverage Report
|
yuqi1129
reviewed
Sep 15, 2023
docs/publish-docker-images.md
Outdated
| @@ -32,4 +32,4 @@ We use Github Actions to publish the docker images to the DockerHub repository. | |||
| ## The version of the Data source in the Docker image | |||
| | Docker image name | Docker image tag | Data source version | | |||
| |-------------------|------------------|--------------------------| | |||
| | graviton-ci-hive | 0.1.0 | hadoop-2.7.3, hive-2.3.9 | | |||
| | graviton-ci-hive | 0.1.x | hadoop-2.7.3, hive-2.3.9 | | |||
There was a problem hiding this comment.
We'd better also adding a description column to describe the difference in each version.
jerryshao
changed the title
|
@jerryshao @yuqi1129 Please help me review again. Thanks. |
yuqi1129
approved these changes
Sep 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
We need to change these configurations:
fs.defaultFStohdfs://0.0.0.0:9000in the/usr/local/hadoop/etc/hadoop/core-site.xmlfile.Optimized
7180port, It's an unused port. It's look like Cloudera manager portlatest.Why are the changes needed?
Currently, HDFS uses
localhostin the graviton-ci-hive Docker.localhostis a loopback IP address in the LINUX,The application (Trino) can't use this IP to access HDFS in the graviton-ci-hive Docker container.
Fix: #396
Does this PR introduce any user-facing change?
N/A
How was this patch tested?
CI passed