-
Notifications
You must be signed in to change notification settings - Fork 304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#351] feat(catalog-lakehouse): make IcebergTableOps#updateTable more convenient #383
Conversation
Code Coverage Report
Files
|
@yunqing-wei @jerryshao , this's pr is ready to review |
@yunqing-wei can you please review firstly? |
Suggestions for modifications were made in the review, and Xiaojing is currently making the changes. |
I think you should leave all the review comments on the PR, not just sync up off-line. |
...use/src/main/java/com/datastrato/graviton/catalog/lakehouse/iceberg/ops/IcebergTableOps.java
Outdated
Show resolved
Hide resolved
...use/src/main/java/com/datastrato/graviton/catalog/lakehouse/iceberg/ops/IcebergTableOps.java
Outdated
Show resolved
Hide resolved
+1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this PR is mainly targeted to add a bunch of helper methods to convert from Graviton's TableChange to Iceberg's UpdateSchema, I would suggest:
- Writing all these converters to a new so-called adapter class or helper class. Leave the IcebergTableOps here all about the Iceberg operations.
- Differentiate the parameter name, if the parameter is iceberg's, then using icebergXxx, if from Graviton, use gravitonXxx.
...use/src/main/java/com/datastrato/graviton/catalog/lakehouse/iceberg/ops/IcebergTableOps.java
Outdated
Show resolved
Hide resolved
...use/src/main/java/com/datastrato/graviton/catalog/lakehouse/iceberg/ops/IcebergTableOps.java
Outdated
Show resolved
Hide resolved
...use/src/main/java/com/datastrato/graviton/catalog/lakehouse/iceberg/ops/IcebergTableOps.java
Outdated
Show resolved
Hide resolved
...use/src/main/java/com/datastrato/graviton/catalog/lakehouse/iceberg/ops/IcebergTableOps.java
Outdated
Show resolved
Hide resolved
...use/src/main/java/com/datastrato/graviton/catalog/lakehouse/iceberg/ops/IcebergTableOps.java
Outdated
Show resolved
Hide resolved
...use/src/main/java/com/datastrato/graviton/catalog/lakehouse/iceberg/ops/IcebergTableOps.java
Outdated
Show resolved
Hide resolved
...use/src/main/java/com/datastrato/graviton/catalog/lakehouse/iceberg/ops/IcebergTableOps.java
Outdated
Show resolved
Hide resolved
add IcebergTableChange icebergTableChange =
icebergTableOpsHelper.makeIcebergTableChanges(gravitonNameIdentifier, gravitonTableChanges);
return icebergTableOps.updateTable(icebergTableChange);
fixed. |
...main/java/com/datastrato/graviton/catalog/lakehouse/iceberg/utils/IcebergTableOpsHelper.java
Outdated
Show resolved
Hide resolved
...main/java/com/datastrato/graviton/catalog/lakehouse/iceberg/utils/IcebergTableOpsHelper.java
Outdated
Show resolved
Hide resolved
...main/java/com/datastrato/graviton/catalog/lakehouse/iceberg/utils/IcebergTableOpsHelper.java
Outdated
Show resolved
Hide resolved
...main/java/com/datastrato/graviton/catalog/lakehouse/iceberg/utils/IcebergTableOpsHelper.java
Outdated
Show resolved
Hide resolved
...main/java/com/datastrato/graviton/catalog/lakehouse/iceberg/utils/IcebergTableOpsHelper.java
Outdated
Show resolved
Hide resolved
...main/java/com/datastrato/graviton/catalog/lakehouse/iceberg/utils/IcebergTableOpsHelper.java
Outdated
Show resolved
Hide resolved
…ent for Graviton IcebergCatalog
There're some style issues, please fix them first. |
done |
What changes were proposed in this pull request?
add a new
updateTable
interface in IcebergTableOpsWhy are the changes needed?
graviton developer could pass
TableChange
to IcebergTableOps, and no need to care about details of Icebergfixes: #351
Does this PR introduce any user-facing change?
No
How was this patch tested?
UT