[#317] feat(core, catalog): make fields in AuditInfo optional and overwriteable #330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code Coverage Report
Files
|
mchades
reviewed
Sep 6, 2023
catalog-hive/src/main/java/com/datastrato/graviton/catalog/hive/HiveTable.java
Outdated
Show resolved
Hide resolved
yuqi1129
reviewed
Sep 6, 2023
| .withLastModifier(currentUser()) | ||
| .withLastModifiedTime(Instant.now()) | ||
| .build(); | ||
| alteredTable.auditInfo().merge(newAudit, true /* overwrite */); |
There was a problem hiding this comment.
I'm confused. Does the code mean that the audit information in gravition is more recent than that in external storage, and that's what we'll use as the final result?
There was a problem hiding this comment.
Yes, if the audit info also exists in Graviton, we will use the one from Graviton as precendence.
mchades
reviewed
Sep 6, 2023
catalog-hive/src/main/java/com/datastrato/graviton/catalog/hive/HiveCatalogOperations.java
Show resolved
Hide resolved
mchades
reviewed
Sep 6, 2023
mchades
approved these changes
Sep 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR proposes to change the requirements of the
AuditInfofields to make them optional and overwriteable.Why are the changes needed?
This is the first change of #250, the change is going to address two problems:
AuditInfois not existed in both Graviton store and underlying source, we should support the emptyAuditInfo, or only several fields are set inAuditInfo.AuditInfoare both set in the Graviton store and underlying source, we should supportAuditInfomergeable.Fix: #317
Does this PR introduce any user-facing change?
No
How was this patch tested?
Modify and add the UTs to test.