-
Notifications
You must be signed in to change notification settings - Fork 304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#2252][#2253][#2470] (PyClient): Add Fileset APIs in Gravitino Python client #2898
Conversation
pass | ||
|
||
|
||
class SupportsSchemas(ABC): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When we create Fileset catalog or do other operations, We need create metalake and schema before that, Because Fileset catalog dependence metalake and schema.
So I need implement SupportsSchemas, I don't wait 0.6 version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this PR has too many changes; Some code like the ChangeRequest, SupportsSchemas are not needed at this moment; If we add them, need to ensure the API's stable, and the functionality are all ready to use (need UT);
Besides, as the implementation are from Java client, I have the concern that it is not the best way of using in Python. Need be evaluated and get feedback from real Python scenarios.
Because if we need implement Fileset Catalog, We must implement Metalake and schema operation. because Fileset Catalog depends Metalake and schema. |
The code I'm about to commit depends on this PR and I've been waiting for this PR merge for 2 days now, so I'm merging this PR first. If there is a problem, we can create a new issue to discuss it. |
What changes were proposed in this pull request?
Support Fileset Catalog in Python client, support below functions:
Why are the changes needed?
Fix: #2470 #2252 #2253
Does this PR introduce any user-facing change?
N/A
How was this patch tested?
CI Passed