Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#2252][#2253][#2470] (PyClient): Add Fileset APIs in Gravitino Python client #2898

Merged
merged 4 commits into from
Apr 13, 2024

Conversation

xunliu
Copy link
Member

@xunliu xunliu commented Apr 11, 2024

What changes were proposed in this pull request?

Support Fileset Catalog in Python client, support below functions:

  1. list_filesets()
  2. load_fileset()
  3. create_fileset()
  4. alter_fileset()
  5. drop_fileset()

Why are the changes needed?

Fix: #2470 #2252 #2253

Does this PR introduce any user-facing change?

N/A

How was this patch tested?

CI Passed

@xunliu xunliu added this to the Gravitino 0.5.0 milestone Apr 11, 2024
@xunliu xunliu requested a review from shaofengshi April 11, 2024 14:46
@xunliu xunliu self-assigned this Apr 11, 2024
pass


class SupportsSchemas(ABC):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This interface will be changed soon(plan in 0.6, see #553 and #2479); I'm not suggesting to implement it now in Python.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When we create Fileset catalog or do other operations, We need create metalake and schema before that, Because Fileset catalog dependence metalake and schema.
So I need implement SupportsSchemas, I don't wait 0.6 version.

Copy link
Contributor

@shaofengshi shaofengshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this PR has too many changes; Some code like the ChangeRequest, SupportsSchemas are not needed at this moment; If we add them, need to ensure the API's stable, and the functionality are all ready to use (need UT);

Besides, as the implementation are from Java client, I have the concern that it is not the best way of using in Python. Need be evaluated and get feedback from real Python scenarios.

@xunliu xunliu changed the title [#2470] Add Fileset APIs in Gravitino Python client [#2470] (PyClient): Add Fileset APIs in Gravitino Python client Apr 13, 2024
@xunliu
Copy link
Member Author

xunliu commented Apr 13, 2024

I think this PR has too many changes; Some code like the ChangeRequest, SupportsSchemas are not needed at this moment; If we add them, need to ensure the API's stable, and the functionality are all ready to use (need UT);

Besides, as the implementation are from Java client, I have the concern that it is not the best way of using in Python. Need be evaluated and get feedback from real Python scenarios.

Because if we need implement Fileset Catalog, We must implement Metalake and schema operation. because Fileset Catalog depends Metalake and schema.
All my test cases are done, waiting for this PR to be merged and submitted.

@xunliu xunliu changed the title [#2470] (PyClient): Add Fileset APIs in Gravitino Python client [#2252][#2253][#2470] (PyClient): Add Fileset APIs in Gravitino Python client Apr 13, 2024
@xunliu
Copy link
Member Author

xunliu commented Apr 13, 2024

The code I'm about to commit depends on this PR and I've been waiting for this PR merge for 2 days now, so I'm merging this PR first. If there is a problem, we can create a new issue to discuss it.

@xunliu xunliu merged commit 139a40a into apache:main Apr 13, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Subtask] Add Fileset APIs in Gravitino Python client
2 participants