[#874] refactor(lakehouse-iceberg) improve IcebergRESTServiceIT #1143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FANNG1
changed the title
|
@Clearvive @xunliu please help to review, thx |
|
LGTM, @FANNG1 can you please rebase the code with latest main branch. |
done |
jerryshao
approved these changes
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
gravitino-docker-ittag from IcebergRESTServiceIT.Why are the changes needed?
After #711, It takes too much time to test IcebergRESTServiceIT, there's no need to start the docker container for the memory catalog
Fix: #874
Does this PR introduce any user-facing change?
no
How was this patch tested?
existing UT