Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement] Improvement IT Docker methodology #639

Closed
xunliu opened this issue Oct 30, 2023 · 0 comments · Fixed by #711
Closed

[Improvement] Improvement IT Docker methodology #639

xunliu opened this issue Oct 30, 2023 · 0 comments · Fixed by #711
Assignees
@xunliu
Labels
improvement Improvements on everything
Milestone
Gravitino 0.3.0

Comments

@xunliu
Copy link
Member

xunliu commented Oct 30, 2023 •
edited
Loading

What would you like to be improved?

Currently, the HiveCatalogIT and CatalogIcebergIT integrated test environment launches the gravitino-ci-hive Docker image via a script, This creates a situation where the startup container is in GitHub Action or local to the user, and the test container is in the IT code, which is not uniform.

How should we improve?

I'm considering referencing the testcontaine approach in TrinoConnectorIT. It can be better to use containers for testing.
@xunliu xunliu added the improvement Improvements on everything label Oct 30, 2023
@xunliu xunliu added this to the Graviton 0.3.0 milestone Oct 30, 2023
@xunliu xunliu self-assigned this Oct 30, 2023
@xunliu xunliu changed the title [Improvement] Improve HiveCatalogIT Docker image [Improvement] Improve HiveCatalogIT Docker test method Oct 30, 2023
@xunliu xunliu mentioned this issue Nov 2, 2023
Merged
@mchades mchades mentioned this issue Nov 6, 2023
Closed
This was referenced Nov 7, 2023
Closed
Merged
@xunliu xunliu changed the title [Improvement] Improve HiveCatalogIT Docker test method [Improvement] Improving integration testing Docker methodology Nov 9, 2023
@xunliu xunliu mentioned this issue Nov 9, 2023
Merged
@xunliu xunliu changed the title [Improvement] Improving integration testing Docker methodology [Improvement] Improvement IT Docker methodology Nov 9, 2023
@xunliu xunliu mentioned this issue Nov 17, 2023
Closed
jerryshao pushed a commit that referenced this issue Nov 30, 2023
@xunliu
[#639] feat(CI): Improvement Docker management for integration test (#…
bb249d6 
…711)

### What changes were proposed in this pull request?

I'm considering referencing the `testcontaine` approach in
`TrinoConnectorIT`. It can be better to use containers for testing.

### Why are the changes needed?

Currently, the `HiveCatalogIT` and `CatalogIcebergIT` integrated test
environment launches the `gravitino-ci-hive` Docker image via a script,
This creates a situation where the startup container is in GitHub Action
or local to the user, and the test container is in the IT code, which is
not uniform.

Fix: #639

### Does this PR introduce _any_ user-facing change?

N/A

### How was this patch tested?

CI Pass
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xunliu xunliu

Labels
improvement Improvements on everything
Projects
None yet
Milestone
Gravitino 0.3.0
Development

Successfully merging a pull request may close this issue.

[#639] feat(CI): Improvement Docker management for integration test
1 participant
@xunliu