[#614] feat(docker): Gravitino Trino Docker image #702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code Coverage Report
|
|
Please change the tag name as proposed in #680. 
|
yuqi1129
reviewed
Nov 7, 2023
|
Overall LGTM, could others please also take a look. |
|
@yuqi1129 I fixed Trino JDBC port issue. |
jerryshao
reviewed
Nov 8, 2023
dev/docker/README.md
Outdated
| This Docker image is used to support Gravitino integration testing. | ||
| It includes Hadoop-2.x and Hive-2.x, you can use this Docker image to test the Gravitino catalog-hive module. | ||
| # Gravitino Docker images | ||
| This Docker image is designed to facilitate Gravitino integration testing. |
There was a problem hiding this comment.
Remove the trailing whitespace.
There was a problem hiding this comment.
This is not fixed, don't forget to do it.
|
LGTM |
mchades
reviewed
Nov 8, 2023
mchades
reviewed
Nov 8, 2023
mchades
approved these changes
Nov 8, 2023
|
Will merge if no more comments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Why are the changes needed?
Gravitino uses Trino for integration tests.
Trino has more than 40 plugins, Which makes the Trino server start up very slowly, usually taking 2~3 minutes.
We need to rebuild the Gravitino Trino Docker image and remove unused plugins.
Fix: #614
Does this PR introduce any user-facing change?
N/A
How was this patch tested?
I build Trino Docker image success. https://hub.docker.com/repository/docker/datastrato/gravitino-ci-trino/general