-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-31923] Run nightly builds against multiple branches and Flink versions #81
base: main
Are you sure you want to change the base?
[FLINK-31923] Run nightly builds against multiple branches and Flink versions #81
Conversation
Hmm, I can't seem to replicate the build error locally. Could we try re-running the checks? Done this:
and
|
As @dannycranmer mentioned, this is due Build failure against 1.18-SNAPSHOT is due to the backward incompatible change in architecture tests from FLINK-31804. This issue impacts multiple connector packages. |
What's the plan to address this, given that Flink and other connectors now use a Maven 3.3+ version? Will you drop the old Kinesis connector when the new one is introduced, or fix the shading issues in the old version? |
We can either fix the shading issue now, or wait for the current source to become deprecated and deleted. I would be inclined to fix the current shading if possible. @z3d1k did you make any progress on a fix?
This connector also uses Maven 3.3+, it uses 3.8.5 |
No. I will take another look. |
This PR does a couple of things:
For AWS specifically, that's:
v3.0
branch is tested against Flink 1.15.4 (latest available 1.15.* version) and Flink 1.16.2 (latest available 1.16.* version)v4.1
branch is tested against Flink 1.16.2 (latest available 1.16.* version) and Flink 1.17.1 (latest available 1.17.* version)main
branch, since it's unreleased, is tested against Flink 1.16-SNAPSHOT, 1.17-SNAPSHOT and 1.18-SNAPSHOTRemoved this, since AWS doesn't compile against Flink 1.18-SNAPSHOT, see https://github.com/apache/flink-connector-aws/actions/runs/5276473761/jobs/9543236823?pr=80#step:13:7916main
is now also tested against 1.18-SNAPSHOT