-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-35868][cdc-connector][mongodb] Bump dependency version to support MongoDB 7.0 #3489
Conversation
@leonardBang @Jiabao-Sun PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @yuxiqian for this improvement.
LGTM.
Shall we bump the driver version from 4.7.1 to 5.1.1 as well? |
Done, bumped |
@@ -69,7 +69,7 @@ limitations under the License. | |||
<dependency> | |||
<groupId>org.mongodb</groupId> | |||
<artifactId>mongodb-driver-sync</artifactId> | |||
<version>4.9.1</version> | |||
<version>5.1.1</version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you also update the docs ? and the older(release-3.1) version docs seem use an incorrect driver version.
https://nightlies.apache.org/flink/flink-cdc-docs-release-3.1/docs/connectors/flink-sources/overview/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The CI failure should be related to the mongo-kafka
version upgrade.
We need to analyze the cause.
I'll investigate this. |
Seems this commit mongodb/mongo-java-driver@a03649c changed return type of Any thoughts from @Jiabao-Sun? |
Thanks @yuxiqian for the investigation. |
This reverts commit a7e03d5.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @yuxiqian for this great work. LGTM now.
cc @leonardBang
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, Thanks @yuxiqian and @Jiabao-Sun for the nice work!
…ort MongoDB 7.0 This closes apache#3489.
…ort MongoDB 7.0 This closes apache#3489.
This closes FLINK-35868.
By bumping mongo-kafka and mongo-driver dependencies, Mongo CDC should be able to cooperate with MongoDB 6.0.16 & 7.0.12 (and legacy 5.0.2).
Notice: since JUnit doesn't allow parameterized
@ClassRule
or static fields, so containers must be created / destroyed before / after each test case, which significantly slows down the. testing (~50 min.). More discussion is required on this.