Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-35736][tests] Add migration test scripts & CI workflows #3447

Merged
merged 5 commits into from
Jul 30, 2024

Conversation

yuxiqian
Copy link
Contributor

@yuxiqian yuxiqian commented Jul 1, 2024

This closes FLINK-35736.

Currently, Flink CDC migration tests are limited to per-class unit tests, and it might not cover all migration cases.

Previously I wrote an E2e migration script, thinking this could be useful for RC verification / automated tests. This PR also added it into CI workflows, but I'm not quite sure about it. I'll remove this from GitHub action rules if it's not suitable for CI.

@morazow PTAL

@github-actions github-actions bot added the build label Jul 1, 2024
@morazow
Copy link
Contributor

morazow commented Jul 2, 2024

Thanks @yuxiqian for the update! I am going to check it soon 👀

Copy link
Contributor

@lvyanquan lvyanquan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, This is very helpful.
I've tested it and found some improvements of user experience.

tools/mig-test/datastream/run_migration_test.rb Outdated Show resolved Hide resolved
tools/mig-test/README.md Outdated Show resolved Hide resolved
tools/mig-test/README.md Outdated Show resolved Hide resolved
@yuxiqian
Copy link
Contributor Author

yuxiqian commented Jul 4, 2024

Added transform block into migration test for Flink CDC 3.1+ to make sure I didn't break anything accidentally in #3285.

@yuxiqian
Copy link
Contributor Author

@morazow Any chance this could be reviewed before the 3.2 release?

@leonardBang
Copy link
Contributor

@Shawn-Hx Would you like to help review this PR?

Copy link
Contributor

@morazow morazow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @yuxiqian for comprehensive guide!

Looks good from my side with minor request 👍

tools/mig-test/README.md Show resolved Hide resolved
Copy link
Contributor

@leonardBang leonardBang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @yuxiqian for the contribution and @morazow @lvyanquan for the review work, LGTM

@leonardBang leonardBang merged commit 5917f78 into apache:master Jul 30, 2024
21 checks passed
wuzhenhua01 pushed a commit to wuzhenhua01/flink-cdc-connectors that referenced this pull request Aug 4, 2024
qiaozongmi pushed a commit to qiaozongmi/flink-cdc that referenced this pull request Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants