-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-35736][tests] Add migration test scripts & CI workflows #3447
Conversation
Thanks @yuxiqian for the update! I am going to check it soon 👀 |
090fa9d
to
9473b87
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this, This is very helpful.
I've tested it and found some improvements of user experience.
Added |
@morazow Any chance this could be reviewed before the 3.2 release? |
@Shawn-Hx Would you like to help review this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @yuxiqian for comprehensive guide!
Looks good from my side with minor request 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @yuxiqian for the contribution and @morazow @lvyanquan for the review work, LGTM
This closes FLINK-35736.
Currently, Flink CDC migration tests are limited to per-class unit tests, and it might not cover all migration cases.
Previously I wrote an E2e migration script, thinking this could be useful for RC verification / automated tests. This PR also added it into CI workflows, but I'm not quite sure about it. I'll remove this from GitHub action rules if it's not suitable for CI.
@morazow PTAL