-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-35713][cdc-compose] Add sink PARALLELISM for flink-cdc. #3438
Open
proletarians
wants to merge
2
commits into
apache:master
Choose a base branch
from
proletarians:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -45,6 +45,15 @@ public class PipelineOptions { | |
.noDefaultValue() | ||
.withDescription("Parallelism of the pipeline"); | ||
|
||
|
||
|
||
public static final ConfigOption<Integer> SINK_PARALLELISM = | ||
ConfigOptions.key("sink.parallelism") | ||
.intType() | ||
.noDefaultValue() | ||
.withDescription("Parallelism of the sink in the pipeline"); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please add some tests for the setting. |
||
|
||
|
||
public static final ConfigOption<SchemaChangeBehavior> PIPELINE_SCHEMA_CHANGE_BEHAVIOR = | ||
ConfigOptions.key("schema.change.behavior") | ||
.enumType(SchemaChangeBehavior.class) | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -93,6 +93,7 @@ private FlinkPipelineComposer(StreamExecutionEnvironment env, boolean isBlocking | |
@Override | ||
public PipelineExecution compose(PipelineDef pipelineDef) { | ||
int parallelism = pipelineDef.getConfig().get(PipelineOptions.PIPELINE_PARALLELISM); | ||
int sinkParallelism = pipelineDef.getConfig().get(PipelineOptions.SINK_PARALLELISM); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What if users do not set the SINK_PARALLELISM setting? |
||
env.getConfig().setParallelism(parallelism); | ||
|
||
// Build Source Operator | ||
|
@@ -136,7 +137,7 @@ public PipelineExecution compose(PipelineDef pipelineDef) { | |
PartitioningTranslator partitioningTranslator = new PartitioningTranslator(); | ||
stream = | ||
partitioningTranslator.translate( | ||
stream, parallelism, parallelism, schemaOperatorIDGenerator.generate()); | ||
stream, parallelism, sinkParallelism, schemaOperatorIDGenerator.generate()); | ||
|
||
// Build Sink Operator | ||
DataSinkTranslator sinkTranslator = new DataSinkTranslator(); | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the future, defining multiple sink in one single pipeline job might be supported, and one might want to define parallelisms for each sink individually. Will it be better if we put
sink.parallelism
as an option insink:
block instead of a global pipeline option?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it! I will follow up on this.