Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FLINK-35713][cdc-compose] Add sink PARALLELISM for flink-cdc. #3438

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[FLINK-35713][cdc-compose] Add sink PARALLELISM for flink-cdc. #3438

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8c60e83
[FLINK-35713][cdc-compose] Add sink PARALLELISM for flink-cdc.
proletarians Jun 27, 2024
f6c427c
add end-to-end integration test for MySQL to Elasticsearch pipeline
proletarians Aug 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions flink-cdc-common/src/main/java/org/apache/flink/cdc/common/pipeline/PipelineOptions.java
View file
Open in desktop
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the future, defining multiple sink in one single pipeline job might be supported, and one might want to define parallelisms for each sink individually. Will it be better if we put sink.parallelism as an option in sink: block instead of a global pipeline option?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it! I will follow up on this.

Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,15 @@ public class PipelineOptions {
.noDefaultValue()
.withDescription("Parallelism of the pipeline");



public static final ConfigOption<Integer> SINK_PARALLELISM =
ConfigOptions.key("sink.parallelism")
.intType()
.noDefaultValue()
.withDescription("Parallelism of the sink in the pipeline");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add some tests for the setting.



public static final ConfigOption<SchemaChangeBehavior> PIPELINE_SCHEMA_CHANGE_BEHAVIOR =
ConfigOptions.key("schema.change.behavior")
.enumType(SchemaChangeBehavior.class)
Expand Down
3 changes: 2 additions & 1 deletion ...cdc-composer/src/main/java/org/apache/flink/cdc/composer/flink/FlinkPipelineComposer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,7 @@ private FlinkPipelineComposer(StreamExecutionEnvironment env, boolean isBlocking
@Override
public PipelineExecution compose(PipelineDef pipelineDef) {
int parallelism = pipelineDef.getConfig().get(PipelineOptions.PIPELINE_PARALLELISM);
int sinkParallelism = pipelineDef.getConfig().get(PipelineOptions.SINK_PARALLELISM);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if users do not set the SINK_PARALLELISM setting?

env.getConfig().setParallelism(parallelism);

// Build Source Operator
Expand Down Expand Up @@ -136,7 +137,7 @@ public PipelineExecution compose(PipelineDef pipelineDef) {
PartitioningTranslator partitioningTranslator = new PartitioningTranslator();
stream =
partitioningTranslator.translate(
stream, parallelism, parallelism, schemaOperatorIDGenerator.generate());
stream, parallelism, sinkParallelism, schemaOperatorIDGenerator.generate());

// Build Sink Operator
DataSinkTranslator sinkTranslator = new DataSinkTranslator();
Expand Down
Loading