[FLINK-35700][cli] Loosen CDC pipeline options validation #3435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| String.format("Unknown configuration key `%s`", key)); | ||
| } | ||
| }); | ||
|
|
||
| options.forEach( | ||
| option -> { | ||
| if (!configuration.getOptional(option).isPresent() |
There was a problem hiding this comment.
To be honest, I also don't understand why unspecified configuration without default value is error?
There was a problem hiding this comment.
Flink config also have a sink.parallelism, but also no default value.
There was a problem hiding this comment.
Since required / optional configuration in pipeline is vague (and undocumented), I've removed all pipeline-level validations.
|
+1 to follow Flink Conf‘s validation style |
|
LGTM! |
wuzhenhua01
pushed a commit
to wuzhenhua01/flink-cdc-connectors
that referenced
this pull request
Aug 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes FLINK-35700.
FLINK-35121 adds pipeline configuration validation, rejecting any unknown options, which turns out to be too strict, and it's not possible to create customized configuration extensions. Also, Flink doesn't reject unknown entries in flink-conf / config.yaml, just silently ignores them. It might be better for CDC to follow such behavior.