[FLINK-35143][pipeline-connector][mysql] Expose newly added tables capture in mysql pipeline connector. #3411
Conversation
… in mysql pipeline connector.
github-actions
bot
added
docs
...st/java/org/apache/flink/cdc/connectors/mysql/source/MysqlPipelineNewlyAddedTableITCase.java
Show resolved
Hide resolved
|
@qg-lin Thanks for your PR. If you need helps, please be free to notice me. Thanks. |
Thanks for your review, I've resolved it. |
| .booleanType() | ||
| .defaultValue(false) | ||
| .withDescription( | ||
| "Whether capture the scan the newly added tables or not, by default is false. This option is only useful when we start the job from a savepoint/checkpoint."); |
There was a problem hiding this comment.
Could we drop the capture here?
For example:
Whether to scan the newly added ...
With both capture and scan it seems hard to understand what the flag enables.
...mysql/src/main/java/org/apache/flink/cdc/connectors/mysql/source/MySqlDataSourceOptions.java
Outdated
Show resolved
Hide resolved
…line-connector-mysql/src/main/java/org/apache/flink/cdc/connectors/mysql/source/MySqlDataSourceOptions.java Co-authored-by: Muhammet Orazov <[email protected]>
|
Got it 👍 I missed that there is doc for the flag, the doc version was already understandable. Looks good! |
|
@qg-lin Please rebase the master branch and let's pass the CI. |
done |
|
@qg-lin It seems that some tests failed. Please take a look at them. Thanks. |
@ruanhang1993 Done, please trigger again. |
ruanhang1993
changed the title
…pture in mysql pipeline connector. (apache#3411) Co-authored-by: Muhammet Orazov <[email protected]> Co-authored-by: north.lin <[email protected]>
https://issues.apache.org/jira/browse/FLINK-35143