modified based on cr

apache · Aug 1, 2024 · 3b722ff · 3b722ff
1 parent be3a689
commit 3b722ff
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 10 deletions.
diff --git a/.../java/org/apache/flink/cdc/connectors/base/relational/connection/JdbcConnectionPools.java b/.../java/org/apache/flink/cdc/connectors/base/relational/connection/JdbcConnectionPools.java
@@ -86,12 +86,10 @@ public String getJdbcUrl(
     }
 
     public void clear() throws IOException {
-        if (instance != null) {
-            synchronized (instance.pools) {
-                instance.pools.values().stream().forEach(HikariDataSource::close);
-                instance.pools.clear();
-                POOL_FACTORY_MAP.clear();
-            }
+        synchronized (pools) {
+            pools.values().stream().forEach(HikariDataSource::close);
+            pools.clear();
+            POOL_FACTORY_MAP.clear();
         }
     }
 }
diff --git a/...ain/java/org/apache/flink/cdc/connectors/mysql/source/connection/JdbcConnectionPools.java b/...ain/java/org/apache/flink/cdc/connectors/mysql/source/connection/JdbcConnectionPools.java
@@ -53,10 +53,10 @@ public HikariDataSource getOrCreateConnectionPool(
         }
     }
 
-    public synchronized void clear() throws IOException {
-        synchronized (INSTANCE.pools) {
-            INSTANCE.pools.values().stream().forEach(HikariDataSource::close);
-            INSTANCE.pools.clear();
+    public void clear() throws IOException {
+        synchronized (pools) {
+            pools.values().stream().forEach(HikariDataSource::close);
+            pools.clear();
         }
     }
 }