-
Notifications
You must be signed in to change notification settings - Fork 639
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add unit test for ThreadUtils #5104
Conversation
eventmesh-common/src/test/java/org/apache/eventmesh/common/utils/ThreadUtilsTest.java
Outdated
Show resolved
Hide resolved
Hi, @harshithasudhakar.Unfortunately, I do not understand what causes the build errors. Can you help? |
Please review the SpotBugs analysis results. They might be available in the CI logs or as a separate report. I will re-run the build after that. |
hi, I review the SpotBugs analysis results but I couldn't find any bug because of my test. In my local everything is okey. Could you re-run the build, please ? |
Hello @harshithasudhakar, I have some guestion about project, When I clone project in master branch and clean build the gradle I get this error: FAILURE: Build failed with an exception.
I tried with java version ı was using java 8 but after that I used java 11 but not fix it. After that when I build with test I get this error for HttpSinkConnectorTest -> testUp method java.lang.IllegalArgumentException I donT understand those errors. Could you help? |
Seems like there are 2 issues here: Fix:
2. MockServer : The Fix:
Please try these fixes and let me know if it works :) |
hello again, thanks for feedback :). I solved the first error but the second still continue. |
Fixes #4540
Motivation
Increase test coverage
Modifications
Added new tests for ThreadUtils.java located https://github.com/apache/eventmesh/blob/master/eventmesh-common/src/main/java/org/apache/eventmesh/common/utils/ThreadUtils.java
Documentation
Does this pull request introduce a new feature? (no)
If yes, how is the feature documented? (not applicable)
If a feature is not applicable for documentation, explain why?
If a feature is not documented yet in this PR, please create a followup issue for adding the documentation