-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
registry inject (#52) #61
Conversation
now delete prom inject |
Codecov Report
@@ Coverage Diff @@
## master #61 +/- ##
==========================================
+ Coverage 48.56% 48.80% +0.23%
==========================================
Files 149 149
Lines 9511 9577 +66
Branches 41 41
==========================================
+ Hits 4619 4674 +55
- Misses 4362 4369 +7
- Partials 530 534 +4
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
suport zk, nacos, k8s as registry, and default is zk > nacos > k8s .
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
in admission controller, inject zk/nacos registry (into ENV) and prom (into annotations)