Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

registry inject (#52) #61

Merged
merged 6 commits into from
Oct 19, 2023
Merged

registry inject (#52) #61

merged 6 commits into from
Oct 19, 2023

Conversation

dawnzzz
Copy link
Contributor

@dawnzzz dawnzzz commented Oct 8, 2023

in admission controller, inject zk/nacos registry (into ENV) and prom (into annotations)

@dawnzzz
Copy link
Contributor Author

dawnzzz commented Oct 8, 2023

now delete prom inject

@dawnzzz dawnzzz changed the title add registry and prom inject (#52) registry inject (#52) Oct 8, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #61 (d066a6c) into master (452b9ed) will increase coverage by 0.23%.
Report is 3 commits behind head on master.
The diff coverage is 83.58%.

❗ Current head d066a6c differs from pull request most recent head 0cbeacc. Consider uploading reports for the commit 0cbeacc to get more accurate results

@@            Coverage Diff             @@
##           master      #61      +/-   ##
==========================================
+ Coverage   48.56%   48.80%   +0.23%     
==========================================
  Files         149      149              
  Lines        9511     9577      +66     
  Branches       41       41              
==========================================
+ Hits         4619     4674      +55     
- Misses       4362     4369       +7     
- Partials      530      534       +4     
Files Coverage Δ
pkg/webhook/patch/javasdk.go 92.55% <83.58%> (-3.35%) ⬇️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dawnzzz
Copy link
Contributor Author

dawnzzz commented Oct 13, 2023

suport zk, nacos, k8s as registry, and default is zk > nacos > k8s .
registry inject label is:

  • registry-zookeeper-inject
  • registry-nacos-inject
  • registry-k8s-inject

Copy link
Contributor

@chickenlj chickenlj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@chickenlj chickenlj merged commit 676706d into apache:master Oct 19, 2023
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants