Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

script, front, admin #57

Merged
merged 11 commits into from
Sep 25, 2023
Merged

script, front, admin #57

merged 11 commits into from
Sep 25, 2023

Conversation

sjmshsh
Copy link
Contributor

@sjmshsh sjmshsh commented Sep 23, 2023

一些shell脚本,一些makefile,修改了一下admin的前端,动态准入控制器基本上完成,删除dubboctl deploy 注入的逻辑

Copy link
Contributor

@chickenlj chickenlj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@codecov-commenter
Copy link

codecov-commenter commented Sep 24, 2023

Codecov Report

Merging #57 (7f43266) into master (bcd31ac) will increase coverage by 1.13%.
Report is 3 commits behind head on master.
The diff coverage is 64.70%.

❗ Current head 7f43266 differs from pull request most recent head e7001b3. Consider uploading reports for the commit e7001b3 to get more accurate results

@@            Coverage Diff             @@
##           master      #57      +/-   ##
==========================================
+ Coverage   47.39%   48.53%   +1.13%     
==========================================
  Files         150      149       -1     
  Lines        9739     9513     -226     
  Branches       41       41              
==========================================
+ Hits         4616     4617       +1     
+ Misses       4593     4366     -227     
  Partials      530      530              
Files Changed Coverage Δ
app/dubboctl/internal/dubbo/deployer.go 0.00% <0.00%> (ø)
app/dubboctl/internal/dubbo/dubbo.go 29.95% <ø> (+3.34%) ⬆️
pkg/authority/server/authority.go 66.66% <ø> (+16.66%) ⬆️
pkg/webhook/webhook/server.go 84.87% <ø> (ø)
pkg/core/cert/provider/storage.go 57.14% <33.33%> (ø)
pkg/webhook/patch/javasdk.go 95.90% <75.00%> (ø)
app/dubboctl/cmd/build.go 19.13% <100.00%> (ø)
app/dubboctl/cmd/deploy.go 28.08% <100.00%> (ø)
pkg/core/tools/endpoint/endpoint.go 90.90% <100.00%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@chickenlj chickenlj merged commit 664c99f into apache:master Sep 25, 2023
4 checks passed

v1 "k8s.io/api/core/v1"
"k8s.io/client-go/kubernetes"
)

type JavaSdk struct {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Give it a more general name.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, I will do it in the next pr.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants