Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(ui): setup format check tool #177

Merged
merged 3 commits into from
Jan 26, 2024
Merged

Conversation

yin1999
Copy link
Contributor

@yin1999 yin1999 commented Jan 26, 2024

What is the purpose of the change

setup format check tool for frontend project.

How to verify this change

run yarn install to install pre-commit hook and then try to commit a source file that will be formatted by prettier.

@yin1999
Copy link
Contributor Author

yin1999 commented Jan 26, 2024

/cc @jianyi-gronk

Copy link
Contributor

@jianyi-gronk jianyi-gronk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@chickenlj chickenlj merged commit 19ce7f4 into apache:master Jan 26, 2024
5 of 6 checks passed
@yin1999 yin1999 deleted the setup-format-check branch January 26, 2024 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants