Feature/UI/framework/vue3 #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`Vue3` `Vite` `TypeScript` `Ant Design Vue` `AntV|echarts` `lodash` `i18n` `colorful theme`
SDUWYS
approved these changes
Dec 16, 2023
| ) | ||
|
|
||
| response.use( | ||
| (response) => { |
There was a problem hiding this comment.
Wouldn't it be better to add some global exception handling hints?
Do we need to add login verification in the future?
There was a problem hiding this comment.
please create a issue about the global exception and login
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #111 +/- ##
==========================================
- Coverage 48.53% 48.52% -0.01%
==========================================
Files 149 148 -1
Lines 9565 9568 +3
Branches 41 41
==========================================
+ Hits 4642 4643 +1
- Misses 4395 4397 +2
Partials 528 528 ☔ View full report in Codecov by Sentry. |
…b/dubbo-kubernetes into feature/ui/framework/vue3 * 'feature/ui/framework/vue3' of https://github.com/Helltab/dubbo-kubernetes: support grafana configuration (apache#108)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix these issues #76 #106 #104
Vue3ViteTypeScriptAnt Design VueAntV|echartslodashi18ncolorful theme