Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add grafana configuration support #108

Merged
merged 1 commit into from
Dec 12, 2023

Conversation

chickenlj
Copy link
Contributor

admin:
  grafana: localhost:3000

@codecov-commenter
Copy link

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (e39d7bb) 48.54% compared to head (c8da113) 48.53%.

❗ Current head c8da113 differs from pull request most recent head 1a7d62f. Consider uploading reports for the commit 1a7d62f to get more accurate results

Files Patch % Lines
pkg/admin/services/prometheus_service_impl.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #108      +/-   ##
==========================================
- Coverage   48.54%   48.53%   -0.02%     
==========================================
  Files         149      149              
  Lines        9563     9565       +2     
  Branches       41       41              
==========================================
  Hits         4642     4642              
- Misses       4393     4395       +2     
  Partials      528      528              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@baerwang baerwang merged commit 49cbe64 into apache:master Dec 12, 2023
4 checks passed
@chickenlj chickenlj deleted the metadata-grafana branch December 12, 2023 09:14
Helltab added a commit to Helltab/dubbo-kubernetes that referenced this pull request Dec 16, 2023
…b/dubbo-kubernetes into feature/ui/framework/vue3

* 'feature/ui/framework/vue3' of https://github.com/Helltab/dubbo-kubernetes:
  support grafana configuration (apache#108)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants