[fix](jdbc catalog) fix and add mysql and doris extremum test #41679
+966
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
|
run buildall |
morningman
changed the title
morningman
reviewed
Oct 10, 2024
| return resultSet.getObject(columnIndex + 1); | ||
| case STRING: { | ||
| int jdbcType = resultSetMetaData.getColumnType(columnIndex + 1); | ||
| if (jdbcType == Types.TIME) { |
There was a problem hiding this comment.
Add some comment to explain this if else
| qt_select_char """select * from t_char order by 1;""" | ||
|
|
||
| sql """set dry_run_query=true""" | ||
| qt_select_all_types_multi_block """select * from all_types_multi_block;""" |
There was a problem hiding this comment.
You can use select count(k1), count(k2), and remove dry_run_query
|
run buildall |
|
run buildall |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1、add mysql jdbc catalog extremum test
2、mysql jdbc catalog time data outside the 24-hour range can be read
3、add doris jdbc catalog extremum test
4、fix doris jdbc catalog char type max size match
5、fix doris jdbc catalog nested array read
Legacy:
Doris float extreme values are incorrect 3.4028235e+38, -3.4028235e+38
Correct values should be 3.4028234e+38, -3.4028234e+38. The incorrect value will exceed the Java float range, so ignore this test and add it after it is fixed
This PR also followup #40122
Adds requiredColumnSize() and requiredDecimalDigits() methods to JdbcFieldSchema, improving error handling by throwing exceptions when values are absent.