[enhancement](util) print if using nereids planner when be coredump #31981 #41605
+39
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
|
run buildall |
Mryange
force-pushed
the
branch-2.0-pick-31981
branch
from
7c8adca
to
c11dd33
Compare
|
run buildall |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -222,12 +224,16 @@ class QueryContext { | |||
| public: | |||
| TUniqueId query_id; | |||
| DescriptorTbl* desc_tbl; | |||
|
|
|||
| bool is_nereids() const { return _is_nereids; } | |||
There was a problem hiding this comment.
warning: function 'is_nereids' should be marked [[nodiscard]] [modernize-use-nodiscard]
Suggested change
| bool is_nereids() const { return _is_nereids; } | |
| [[nodiscard]] bool is_nereids() const { return _is_nereids; } |
| @@ -450,6 +450,9 @@ class RuntimeState { | |||
| : 0; | |||
| } | |||
|
|
|||
|
|
|||
| bool is_nereids() const; | |||
There was a problem hiding this comment.
warning: function 'is_nereids' should be marked [[nodiscard]] [modernize-use-nodiscard]
Suggested change
| bool is_nereids() const; | |
| [[nodiscard]] bool is_nereids() const; |
TPC-H: Total hot run time: 49219 ms |
TPC-DS: Total hot run time: 212151 ms |
ClickBench: Total hot run time: 30.79 s |
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
|
run buildall |
TPC-H: Total hot run time: 49307 ms |
|
TeamCity be ut coverage result: |
TPC-DS: Total hot run time: 210862 ms |
ClickBench: Total hot run time: 31.78 s |
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
|
run p0 |
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
the
approved
|
PR approved by anyone and no changes requested. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
pick #31752
pick #31981
Issue Number: close #xxx