Use DorisVector to avoid memory usage from not being traced #41557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
yiguolei
reviewed
Oct 9, 2024
be/src/vec/common/custom_allocator.h
Outdated
| @@ -23,8 +23,8 @@ | |||
| template <class T, typename MemoryAllocator = Allocator<true>> | |||
| class CustomStdAllocator; | |||
|
|
|||
| template <typename T> | |||
| using DorisVector = std::vector<T, CustomStdAllocator<T>>; | |||
| template <typename T, bool clean_memory = false> | |||
yiguolei
reviewed
Oct 9, 2024
| @@ -53,6 +53,9 @@ Status AggLocalState::init(RuntimeState* state, LocalStateInfo& info) { | |||
| _hash_table_size_counter = | |||
| ADD_COUNTER_WITH_LEVEL(Base::profile(), "HashTableSize", TUnit::UNIT, 1); | |||
|
|
|||
| _container_memory_usage = ADD_COUNTER(profile(), "ContainerMemoryUsage", TUnit::BYTES); | |||
There was a problem hiding this comment.
rename to MemoryUsageContainer MemoryUsageArena
mrhhsg
force-pushed
the
spill_and_reserve
branch
2 times, most recently
from
c79bf06
to
b44b7a1
Compare
yiguolei
reviewed
Oct 9, 2024
| } | ||
| } | ||
| Base::keys = input_keys.data(); | ||
| } | ||
|
|
||
| size_t serialized_keys_size(bool is_build) const override { | ||
| return is_build ? build_arena.size() : Base::arena.size(); | ||
| return is_build ? (build_stored_keys.size() * sizeof(StringRef)) | ||
| : (stored_keys.size() * sizeof(StringRef)); |
There was a problem hiding this comment.
感觉这个不对吧，这个计算的偏小了。应该加上arena
mrhhsg
force-pushed
the
spill_and_reserve
branch
from
b44b7a1
to
211f359
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
And merge hash table of agg in thread of pipeline tasks.