Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix](sc) remove duplicated modify rowsets #40740

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

dataroaring
Copy link
Contributor

introducde by 39967

Proposed changes

Issue Number: close #xxx

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@dataroaring
Copy link
Contributor Author

run buildall

Copy link
Contributor

PR approved by anyone and no changes requested.

Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TPC-H: Total hot run time: 49347 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit bb2fb655d89434c83bb0543bf4765da3604d896f, data reload: false

------ Round 1 ----------------------------------
q1	17639	4427	4347	4347
q2	2065	158	151	151
q3	10252	1902	1917	1902
q4	10130	1238	1314	1238
q5	8464	3985	3972	3972
q6	231	125	124	124
q7	2061	1590	1603	1590
q8	9498	2750	2712	2712
q9	13653	9970	10016	9970
q10	8674	3586	3543	3543
q11	416	249	250	249
q12	462	296	300	296
q13	18380	3981	4022	3981
q14	354	335	331	331
q15	512	455	472	455
q16	527	475	466	466
q17	1127	968	933	933
q18	7258	6766	6790	6766
q19	1654	1575	1518	1518
q20	549	323	292	292
q21	4410	4120	4121	4120
q22	499	406	391	391
Total cold run time: 118815 ms
Total hot run time: 49347 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4331	4320	4272	4272
q2	317	228	227	227
q3	4170	4147	4150	4147
q4	2769	2737	2738	2737
q5	7216	7122	7184	7122
q6	235	119	118	118
q7	3269	2836	2839	2836
q8	4413	4482	4477	4477
q9	14317	13827	13805	13805
q10	4249	4271	4246	4246
q11	752	708	661	661
q12	1027	878	853	853
q13	7065	3713	3755	3713
q14	490	437	429	429
q15	493	463	452	452
q16	626	597	584	584
q17	3830	3862	3859	3859
q18	8832	8678	8672	8672
q19	1697	1708	1644	1644
q20	2356	2117	2143	2117
q21	8462	8514	8480	8480
q22	1038	967	960	960
Total cold run time: 81954 ms
Total hot run time: 76411 ms

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.84% (8141/21513)
Line Coverage: 29.59% (67004/226411)
Region Coverage: 29.08% (34570/118880)
Branch Coverage: 24.98% (17811/71288)
Coverage Report: http://coverage.selectdb-in.cc/coverage/bb2fb655d89434c83bb0543bf4765da3604d896f_bb2fb655d89434c83bb0543bf4765da3604d896f/report/index.html

@doris-robot
Copy link

TPC-DS: Total hot run time: 212797 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit bb2fb655d89434c83bb0543bf4765da3604d896f, data reload: false

query1	940	391	430	391
query2	6559	2141	2167	2141
query3	6931	220	209	209
query4	23013	22015	21495	21495
query5	19745	6559	6571	6559
query6	289	226	241	226
query7	4324	304	312	304
query8	270	251	255	251
query9	3052	2604	2558	2558
query10	487	329	338	329
query11	16007	14765	15124	14765
query12	133	81	79	79
query13	1030	453	433	433
query14	17266	13827	13584	13584
query15	380	224	232	224
query16	6480	285	273	273
query17	1888	935	947	935
query18	898	331	320	320
query19	212	156	159	156
query20	84	75	77	75
query21	193	101	96	96
query22	5127	5196	5099	5099
query23	34490	33555	33580	33555
query24	6927	6281	6351	6281
query25	546	431	436	431
query26	807	170	167	167
query27	2287	300	291	291
query28	6090	2267	2232	2232
query29	2920	2680	2661	2661
query30	252	168	166	166
query31	953	745	743	743
query32	70	65	63	63
query33	433	279	264	264
query34	866	494	493	493
query35	1145	957	915	915
query36	1351	1112	1090	1090
query37	91	65	60	60
query38	3104	2999	2984	2984
query39	1397	1346	1339	1339
query40	205	93	95	93
query41	39	37	36	36
query42	89	93	85	85
query43	647	594	539	539
query44	1187	721	728	721
query45	248	235	231	231
query46	1254	955	1003	955
query47	1882	1820	1584	1584
query48	510	411	417	411
query49	630	382	381	381
query50	862	628	614	614
query51	4766	4629	4648	4629
query52	94	76	91	76
query53	248	188	184	184
query54	2691	2508	2512	2508
query55	99	80	88	80
query56	225	205	196	196
query57	1174	1101	1112	1101
query58	224	210	228	210
query59	3419	3305	3206	3206
query60	216	228	199	199
query61	100	100	122	100
query62	821	498	444	444
query63	200	181	179	179
query64	3163	1590	1485	1485
query65	3663	3531	3575	3531
query66	802	411	404	404
query67	15453	14958	15929	14958
query68	11304	686	655	655
query69	511	263	280	263
query70	1937	1378	1417	1378
query71	417	314	314	314
query72	6875	4853	4936	4853
query73	779	333	329	329
query74	6382	5956	5879	5879
query75	5368	3744	3763	3744
query76	6937	1152	1204	1152
query77	1181	265	257	257
query78	12685	11802	12243	11802
query79	7083	661	660	660
query80	1048	388	376	376
query81	488	238	242	238
query82	741	109	93	93
query83	168	138	135	135
query84	268	70	74	70
query85	894	329	322	322
query86	336	277	283	277
query87	3218	3030	3039	3030
query88	4121	2392	2420	2392
query89	446	308	305	305
query90	1935	211	216	211
query91	156	133	127	127
query92	57	52	53	52
query93	6560	600	533	533
query94	713	205	208	205
query95	2080	2025	1960	1960
query96	662	347	335	335
query97	6591	6437	6477	6437
query98	214	210	214	210
query99	3007	826	868	826
Total cold run time: 319110 ms
Total hot run time: 212797 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.64 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit bb2fb655d89434c83bb0543bf4765da3604d896f, data reload: false

query1	0.02	0.02	0.02
query2	0.07	0.03	0.03
query3	0.25	0.05	0.05
query4	1.79	0.06	0.06
query5	0.54	0.53	0.52
query6	1.23	0.63	0.62
query7	0.01	0.02	0.01
query8	0.03	0.03	0.02
query9	0.51	0.47	0.48
query10	0.53	0.54	0.55
query11	0.12	0.09	0.09
query12	0.11	0.10	0.09
query13	0.63	0.62	0.61
query14	0.80	0.76	0.78
query15	0.77	0.75	0.75
query16	0.39	0.37	0.39
query17	1.04	1.04	1.02
query18	0.21	0.27	0.21
query19	1.93	1.88	1.87
query20	0.01	0.00	0.00
query21	15.47	0.55	0.54
query22	2.12	2.07	1.28
query23	17.20	0.98	0.87
query24	7.12	1.32	1.19
query25	0.39	0.11	0.06
query26	0.78	0.15	0.16
query27	0.04	0.04	0.03
query28	5.74	0.77	0.73
query29	12.62	2.40	2.37
query30	0.56	0.52	0.52
query31	2.83	0.39	0.37
query32	3.37	0.51	0.50
query33	3.08	3.08	3.02
query34	15.26	4.83	4.84
query35	4.89	4.86	4.82
query36	1.10	1.02	1.01
query37	0.06	0.04	0.05
query38	0.04	0.02	0.02
query39	0.02	0.01	0.02
query40	0.16	0.14	0.13
query41	0.06	0.01	0.01
query42	0.02	0.01	0.02
query43	0.02	0.02	0.02
Total cold run time: 103.94 s
Total hot run time: 30.64 s

@doris-robot
Copy link

Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'

Load test result on commit bb2fb655d89434c83bb0543bf4765da3604d896f with default session variables
Stream load json:         20 seconds loaded 2358488459 Bytes, about 112 MB/s
Stream load orc:          58 seconds loaded 1101869774 Bytes, about 18 MB/s
Stream load parquet:      31 seconds loaded 861443392 Bytes, about 26 MB/s
Insert into select:       21.0 seconds inserted 10000000 Rows, about 476K ops/s

@dataroaring dataroaring merged commit ba201fd into apache:branch-2.0 Sep 12, 2024
20 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants