Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix](ES Catalog)Fix int parse error when querying by doc_values (#40385) #40522

Merged
merged 1 commit into from
Sep 9, 2024
Merged

[fix](ES Catalog)Fix int parse error when querying by doc_values (#40385) #40522

merged 1 commit into from
Sep 9, 2024

Conversation

qidaye
Copy link
Contributor

@qidaye qidaye commented Sep 9, 2024

bp #40385

@qidaye
[fix](ES Catalog)Fix int parse error when querying by doc_values (apa…
0867cd5 
…che#40385)

When querying by doc_values, the result may be embrace by quotes, which
will lead the int parsing error.
@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@qidaye
Copy link
Contributor Author

qidaye commented Sep 9, 2024

run buildall

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 9, 2024

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TPC-H: Total hot run time: 49284 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 0867cd57e5a52b20c6e8b49428653beaf18be029, data reload: false

------ Round 1 ----------------------------------
q1	18142	4333	4314	4314
q2	2035	184	142	142
q3	10410	1860	1904	1860
q4	10337	1294	1325	1294
q5	8398	3937	3874	3874
q6	228	124	122	122
q7	2020	1623	1613	1613
q8	9304	2730	2704	2704
q9	10591	10133	10084	10084
q10	8606	3531	3490	3490
q11	425	244	245	244
q12	468	295	302	295
q13	18336	3973	4042	3973
q14	362	333	331	331
q15	517	458	461	458
q16	544	471	451	451
q17	1123	927	913	913
q18	7184	6933	6835	6835
q19	1691	1574	1517	1517
q20	548	303	297	297
q21	4385	4142	4080	4080
q22	500	393	397	393
Total cold run time: 116154 ms
Total hot run time: 49284 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4321	4324	4332	4324
q2	321	227	223	223
q3	4197	4145	4135	4135
q4	2756	2738	2746	2738
q5	7140	7152	7112	7112
q6	237	120	121	120
q7	3220	2799	2835	2799
q8	4404	4471	4474	4471
q9	14213	14015	13910	13910
q10	4225	4283	4272	4272
q11	762	697	666	666
q12	1036	839	840	839
q13	6926	3935	3741	3741
q14	441	416	416	416
q15	497	462	445	445
q16	630	586	599	586
q17	3777	3914	3917	3914
q18	8674	8762	8752	8752
q19	1711	1675	1650	1650
q20	2393	2103	2114	2103
q21	8457	8468	8462	8462
q22	1031	956	968	956
Total cold run time: 81369 ms
Total hot run time: 76634 ms

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.84% (8135/21499)
Line Coverage: 29.59% (66970/226357)
Region Coverage: 29.08% (34556/118851)
Branch Coverage: 24.99% (17811/71272)
Coverage Report: http://coverage.selectdb-in.cc/coverage/0867cd57e5a52b20c6e8b49428653beaf18be029_0867cd57e5a52b20c6e8b49428653beaf18be029/report/index.html

@doris-robot
Copy link

TPC-DS: Total hot run time: 213134 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 0867cd57e5a52b20c6e8b49428653beaf18be029, data reload: false

query1	923	391	420	391
query2	6533	2253	2157	2157
query3	6942	208	210	208
query4	23486	21754	22266	21754
query5	23084	6599	6648	6599
query6	1130	216	230	216
query7	6027	310	317	310
query8	253	288	241	241
query9	3060	2587	2542	2542
query10	499	307	305	305
query11	16038	15492	15224	15224
query12	135	76	76	76
query13	1051	444	448	444
query14	19188	13617	13482	13482
query15	358	224	218	218
query16	6431	281	259	259
query17	1572	930	886	886
query18	893	323	314	314
query19	210	145	144	144
query20	82	77	83	77
query21	195	100	93	93
query22	5327	5042	5084	5042
query23	34112	33352	33503	33352
query24	6505	6269	6284	6269
query25	519	431	413	413
query26	800	167	165	165
query27	2279	300	299	299
query28	6083	2298	2240	2240
query29	2918	2715	2644	2644
query30	243	169	170	169
query31	972	752	793	752
query32	69	63	57	57
query33	438	253	270	253
query34	887	470	468	468
query35	1142	956	909	909
query36	1437	1338	1213	1213
query37	90	60	57	57
query38	3082	2965	2906	2906
query39	1407	1331	1314	1314
query40	203	96	89	89
query41	40	38	38	38
query42	86	88	82	82
query43	656	604	580	580
query44	1159	721	729	721
query45	245	236	226	226
query46	1239	967	958	958
query47	1870	1748	1963	1748
query48	526	409	410	409
query49	611	380	376	376
query50	859	601	621	601
query51	4745	4640	4638	4638
query52	88	87	83	83
query53	235	191	178	178
query54	2722	2473	2512	2473
query55	97	84	82	82
query56	229	192	211	192
query57	1178	1153	1080	1080
query58	223	222	227	222
query59	3516	3487	3228	3228
query60	213	206	211	206
query61	99	97	99	97
query62	788	466	435	435
query63	203	175	178	175
query64	3253	1517	1342	1342
query65	3632	3552	3586	3552
query66	735	403	403	403
query67	16630	15284	15372	15284
query68	9793	638	648	638
query69	503	284	280	280
query70	1521	1313	1366	1313
query71	426	310	307	307
query72	7022	4922	4871	4871
query73	758	320	311	311
query74	6462	5962	5896	5896
query75	5491	3697	3621	3621
query76	5567	1157	1230	1157
query77	942	256	251	251
query78	12746	11882	11803	11803
query79	6943	642	644	642
query80	1534	382	378	378
query81	488	238	239	238
query82	1679	100	95	95
query83	173	137	137	137
query84	256	70	69	69
query85	895	319	323	319
query86	326	292	304	292
query87	3203	3032	3002	3002
query88	4673	2323	2317	2317
query89	389	283	296	283
query90	2002	205	216	205
query91	160	142	126	126
query92	57	50	51	50
query93	5867	549	559	549
query94	721	211	209	209
query95	2085	1942	2034	1942
query96	648	325	326	325
query97	6578	6442	6573	6442
query98	219	211	204	204
query99	3016	902	973	902
Total cold run time: 325623 ms
Total hot run time: 213134 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 31.23 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 0867cd57e5a52b20c6e8b49428653beaf18be029, data reload: false

query1	0.03	0.03	0.02
query2	0.07	0.03	0.03
query3	0.25	0.05	0.04
query4	1.79	0.08	0.08
query5	0.55	0.53	0.52
query6	1.25	0.63	0.63
query7	0.02	0.01	0.01
query8	0.03	0.03	0.03
query9	0.52	0.49	0.48
query10	0.53	0.54	0.54
query11	0.13	0.09	0.09
query12	0.11	0.08	0.08
query13	0.62	0.61	0.62
query14	0.79	0.78	0.79
query15	0.80	0.76	0.75
query16	0.36	0.37	0.37
query17	1.01	1.02	1.00
query18	0.19	0.27	0.26
query19	1.92	1.82	1.86
query20	0.01	0.01	0.01
query21	15.45	0.57	0.57
query22	2.14	2.58	1.65
query23	17.47	0.93	0.92
query24	6.33	1.25	1.62
query25	0.36	0.07	0.06
query26	0.83	0.17	0.15
query27	0.04	0.03	0.03
query28	5.98	0.74	0.75
query29	12.68	2.32	2.34
query30	0.63	0.53	0.54
query31	2.80	0.39	0.37
query32	3.37	0.50	0.48
query33	3.11	3.06	3.06
query34	15.25	4.83	4.84
query35	4.87	4.86	4.86
query36	1.06	1.01	1.02
query37	0.06	0.05	0.04
query38	0.04	0.02	0.02
query39	0.02	0.01	0.02
query40	0.16	0.14	0.14
query41	0.07	0.02	0.02
query42	0.02	0.01	0.02
query43	0.02	0.01	0.02
Total cold run time: 103.74 s
Total hot run time: 31.23 s

@doris-robot
Copy link

Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'

Load test result on commit 0867cd57e5a52b20c6e8b49428653beaf18be029 with default session variables
Stream load json:         19 seconds loaded 2358488459 Bytes, about 118 MB/s
Stream load orc:          58 seconds loaded 1101869774 Bytes, about 18 MB/s
Stream load parquet:      31 seconds loaded 861443392 Bytes, about 26 MB/s
Insert into select:       21.9 seconds inserted 10000000 Rows, about 456K ops/s

@xiaokang xiaokang merged commit 9dea5ce into apache:branch-2.0 Sep 9, 2024
20 of 24 checks passed
@qidaye qidaye deleted the pick_int_parse_2.0 branch September 9, 2024 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
kind/test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@qidaye @doris-robot @xiaokang