Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore](cloud) Support starting both meta-service and recycler within single process #40223

Merged
merged 7 commits into from
Sep 4, 2024

Conversation

gavinchou
Copy link
Collaborator

@gavinchou gavinchou commented Aug 31, 2024

e.g. the following will start meta-service and recycler within single process.

./bin/start.sh --daemon

the log file will be meta_service.INFO*

and it is the same effect as ./bin/start.sh --meta-service --recycler --daemon

doc PR apache/doris-website#1073

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@gavinchou
Copy link
Collaborator Author

run buildall

Copy link
Contributor

sh-checker report

To get the full details, please check in the job output.

shellcheck errors
'shellcheck ' found no issues.

shfmt errors

'shfmt ' returned error 1 finding the following formatting issues:

----------
--- cloud/script/start.sh.orig
+++ cloud/script/start.sh
@@ -134,9 +134,9 @@
 out_file=${DORIS_HOME}/log/${process}.out
 if [[ "${RUN_DAEMON}" -eq 1 ]]; then
     # append 10 blank lines to ensure the following tail -n10 works correctly
-    printf "\n\n\n\n\n\n\n\n\n\n" >> "${out_file}"
-    echo "$(date +'%F %T') try to start ${process}" >> "${out_file}"
-    nohup "${bin}" "$@" >> "${out_file}" 2>&1 &
+    printf "\n\n\n\n\n\n\n\n\n\n" >>"${out_file}"
+    echo "$(date +'%F %T') try to start ${process}" >>"${out_file}"
+    nohup "${bin}" "$@" >>"${out_file}" 2>&1 &
     echo "wait and check ${process} start successfully"
     sleep 3
     tail -n10 "${out_file}" | grep 'successfully started brpc'
----------

You can reformat the above files to meet shfmt's requirements by typing:

  shfmt  -w filename


Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

cloud/script/start.sh Outdated Show resolved Hide resolved
@gavinchou
Copy link
Collaborator Author

run buildall

Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

airborne12
airborne12 previously approved these changes Sep 1, 2024
Copy link
Member

@airborne12 airborne12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

github-actions bot commented Sep 1, 2024

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Sep 1, 2024
Copy link
Contributor

github-actions bot commented Sep 1, 2024

PR approved by anyone and no changes requested.

liaoxin01
liaoxin01 previously approved these changes Sep 1, 2024
Copy link
Contributor

@liaoxin01 liaoxin01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gavinchou gavinchou dismissed stale reviews from liaoxin01 and airborne12 via b30dc54 September 2, 2024 13:58
@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Sep 2, 2024
Copy link
Contributor

github-actions bot commented Sep 2, 2024

clang-tidy review says "All clean, LGTM! 👍"

@gavinchou
Copy link
Collaborator Author

run buildall

Copy link
Contributor

github-actions bot commented Sep 2, 2024

clang-tidy review says "All clean, LGTM! 👍"

… single process

e.g.
```
./bin/start.sh --recycler --meta-service --daemon
```

the log file will be meta_service.INFO*
@gavinchou
Copy link
Collaborator Author

run buildall

Copy link
Contributor

github-actions bot commented Sep 2, 2024

clang-tidy review says "All clean, LGTM! 👍"

@gavinchou
Copy link
Collaborator Author

run buildall

cloud/src/common/config.h Outdated Show resolved Hide resolved
@gavinchou
Copy link
Collaborator Author

run buildall

Copy link
Contributor

github-actions bot commented Sep 3, 2024

clang-tidy review says "All clean, LGTM! 👍"

1 similar comment
Copy link
Contributor

github-actions bot commented Sep 3, 2024

clang-tidy review says "All clean, LGTM! 👍"

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

github-actions bot commented Sep 3, 2024

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Sep 3, 2024
@gavinchou gavinchou merged commit d177d5b into apache:master Sep 4, 2024
27 of 28 checks passed
gavinchou added a commit that referenced this pull request Sep 5, 2024
… single process (#40223)

e.g. the following will start meta-service and recycler within single
process.
```
./bin/start.sh --daemon
```
the log file will be meta_service.INFO*

and it is the same effect as `./bin/start.sh --meta-service --recycler
--daemon`

doc PR apache/doris-website#1073
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. dev/3.0.2-merged reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants