[fix](brpc_client_cache) resolve hostname in DNS cache before passing to brpc #40074

kaijchen · 2024-08-28T14:06:23Z

Proposed changes

Currently brpc does not support resloving IPv6 hostnames, errors will be returned on brpc::Channel::Init.
The brpc client cache may return nullptr on its get_client or get_new_client_no_cache APIs.

This PR made the following changes:

Resolve hostnames from DNS cache before passing it to brpc.
Callers should check nullptr after get client, in case of failures.

doris-robot · 2024-08-28T14:06:28Z

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

kaijchen · 2024-08-28T14:06:32Z

run buildall

dataroaring

LGTM

github-actions · 2024-08-28T14:09:18Z

PR approved by at least one committer and no changes requested.

github-actions · 2024-08-28T14:09:20Z

PR approved by anyone and no changes requested.

github-actions · 2024-08-28T14:13:54Z

clang-tidy review says "All clean, LGTM! 👍"

kaijchen · 2024-08-29T02:27:47Z

run buildall

github-actions · 2024-08-29T02:32:37Z

clang-tidy review says "All clean, LGTM! 👍"

dataroaring · 2024-08-29T14:58:34Z

run buildall

github-actions · 2024-08-29T15:05:55Z

clang-tidy review says "All clean, LGTM! 👍"

kaijchen · 2024-08-30T04:55:10Z

run buildall

github-actions · 2024-08-30T05:02:02Z

clang-tidy review says "All clean, LGTM! 👍"

doris-robot · 2024-08-30T06:17:29Z

TPC-H: Total hot run time: 38115 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 0cdb3553da835d784686cc90d2d92d93f5245b1b, data reload: false

------ Round 1 ----------------------------------
q1	17940	4545	4327	4327
q2	2046	187	188	187
q3	11395	975	1166	975
q4	10214	757	829	757
q5	7755	2879	2848	2848
q6	224	138	137	137
q7	971	618	605	605
q8	9319	2124	2090	2090
q9	7263	6581	6573	6573
q10	7062	2229	2238	2229
q11	477	241	244	241
q12	390	223	225	223
q13	18960	3013	3046	3013
q14	277	241	234	234
q15	518	500	471	471
q16	611	499	504	499
q17	1005	735	689	689
q18	7504	6795	6880	6795
q19	1390	964	1005	964
q20	701	331	332	331
q21	3998	3071	2916	2916
q22	1137	1055	1011	1011
Total cold run time: 111157 ms
Total hot run time: 38115 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4384	4294	4273	4273
q2	371	270	268	268
q3	2892	2674	2703	2674
q4	1964	1631	1642	1631
q5	5648	5722	5749	5722
q6	232	135	135	135
q7	2298	1868	1846	1846
q8	3308	3453	3483	3453
q9	8830	8857	8869	8857
q10	3561	3419	3367	3367
q11	585	518	508	508
q12	826	656	657	656
q13	13366	3146	3150	3146
q14	327	292	307	292
q15	543	495	489	489
q16	612	596	597	596
q17	1862	1553	1515	1515
q18	8245	7736	7914	7736
q19	1736	1505	1605	1505
q20	2139	1891	1912	1891
q21	5760	5538	5595	5538
q22	1173	1057	1057	1057
Total cold run time: 70662 ms
Total hot run time: 57155 ms

doris-robot · 2024-08-30T06:29:51Z

TPC-DS: Total hot run time: 192437 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 0cdb3553da835d784686cc90d2d92d93f5245b1b, data reload: false

query1	1256	885	878	878
query2	6303	1953	1869	1869
query3	10767	4264	4015	4015
query4	60292	27711	23317	23317
query5	5297	500	502	500
query6	400	166	181	166
query7	5777	294	292	292
query8	289	209	208	208
query9	8865	2491	2436	2436
query10	476	269	261	261
query11	18041	14977	15573	14977
query12	169	103	103	103
query13	1551	414	373	373
query14	10839	7321	6535	6535
query15	250	187	180	180
query16	7567	518	521	518
query17	1179	585	559	559
query18	1979	287	308	287
query19	290	154	146	146
query20	123	110	109	109
query21	203	103	111	103
query22	4707	4452	4523	4452
query23	34574	33507	33126	33126
query24	5938	2859	2859	2859
query25	517	382	385	382
query26	684	158	158	158
query27	1797	280	288	280
query28	3775	2117	2088	2088
query29	659	396	405	396
query30	232	150	152	150
query31	935	739	773	739
query32	81	52	53	52
query33	451	288	279	279
query34	877	469	482	469
query35	840	720	726	720
query36	1054	931	939	931
query37	139	94	90	90
query38	3959	3846	3852	3846
query39	1477	1415	1398	1398
query40	199	117	113	113
query41	46	45	46	45
query42	111	97	99	97
query43	502	468	475	468
query44	1079	738	742	738
query45	193	169	171	169
query46	1103	747	756	747
query47	1919	1791	1803	1791
query48	373	294	302	294
query49	773	440	455	440
query50	819	433	416	416
query51	7179	7051	7135	7051
query52	99	91	93	91
query53	257	181	184	181
query54	582	463	485	463
query55	84	78	84	78
query56	292	269	273	269
query57	1177	1097	1099	1097
query58	230	239	240	239
query59	3023	2775	2795	2775
query60	304	282	304	282
query61	132	122	126	122
query62	770	663	668	663
query63	215	185	189	185
query64	2956	773	744	744
query65	3192	3134	3151	3134
query66	705	376	352	352
query67	15461	15237	15217	15217
query68	3025	575	576	575
query69	410	298	290	290
query70	1193	1067	1048	1048
query71	368	273	279	273
query72	6351	4299	4244	4244
query73	744	337	468	337
query74	9062	8812	8790	8790
query75	3367	2683	2722	2683
query76	1533	1114	1011	1011
query77	524	312	361	312
query78	10514	9294	9080	9080
query79	2264	532	538	532
query80	920	520	512	512
query81	565	237	241	237
query82	408	151	159	151
query83	189	151	149	149
query84	261	79	79	79
query85	818	314	289	289
query86	443	302	273	273
query87	4492	4359	4198	4198
query88	4145	2335	2334	2334
query89	388	280	295	280
query90	1918	203	195	195
query91	126	98	97	97
query92	61	50	52	50
query93	2331	533	531	531
query94	833	313	302	302
query95	353	264	266	264
query96	604	269	273	269
query97	3184	3069	3062	3062
query98	221	200	212	200
query99	1634	1305	1282	1282
Total cold run time: 311633 ms
Total hot run time: 192437 ms

doris-robot · 2024-08-30T06:35:27Z

ClickBench: Total hot run time: 32.69 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 0cdb3553da835d784686cc90d2d92d93f5245b1b, data reload: false

query1	0.05	0.04	0.04
query2	0.08	0.04	0.04
query3	0.22	0.05	0.04
query4	1.68	0.08	0.07
query5	0.51	0.50	0.49
query6	1.13	0.74	0.72
query7	0.02	0.01	0.01
query8	0.05	0.05	0.05
query9	0.54	0.48	0.49
query10	0.54	0.55	0.53
query11	0.16	0.12	0.11
query12	0.15	0.11	0.12
query13	0.60	0.58	0.59
query14	2.04	2.05	2.07
query15	0.90	0.82	0.82
query16	0.36	0.38	0.37
query17	1.00	0.98	0.95
query18	0.22	0.21	0.20
query19	1.94	1.88	1.84
query20	0.01	0.01	0.02
query21	15.40	0.67	0.65
query22	4.27	6.93	2.54
query23	18.31	1.46	1.30
query24	2.13	0.22	0.22
query25	0.15	0.08	0.08
query26	0.26	0.18	0.17
query27	0.09	0.07	0.07
query28	13.22	1.03	1.01
query29	12.62	3.28	3.26
query30	0.24	0.06	0.05
query31	2.88	0.40	0.39
query32	3.25	0.47	0.47
query33	2.94	3.03	3.00
query34	17.04	4.47	4.48
query35	4.45	4.44	4.44
query36	0.65	0.47	0.46
query37	0.18	0.16	0.15
query38	0.16	0.15	0.15
query39	0.05	0.04	0.04
query40	0.16	0.13	0.13
query41	0.10	0.05	0.05
query42	0.06	0.05	0.04
query43	0.04	0.04	0.04
Total cold run time: 110.85 s
Total hot run time: 32.69 s

kaijchen · 2024-08-30T09:24:05Z

run buildall

github-actions · 2024-08-30T09:24:52Z

clang-tidy review says "All clean, LGTM! 👍"

github-actions · 2024-08-30T09:31:27Z

clang-tidy review says "All clean, LGTM! 👍"

kaijchen · 2024-09-02T02:08:34Z

run buildall

github-actions · 2024-09-02T02:15:50Z

clang-tidy review says "All clean, LGTM! 👍"

doris-robot · 2024-09-02T03:02:14Z

TPC-H: Total hot run time: 38229 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit d39560609903d7887fa67d7a984b49982951f6cd, data reload: false

------ Round 1 ----------------------------------
q1	17717	4889	4386	4386
q2	2031	187	194	187
q3	11393	959	1099	959
q4	10511	776	613	613
q5	7751	2858	2851	2851
q6	223	139	139	139
q7	965	620	613	613
q8	9336	2086	2098	2086
q9	6969	6536	6535	6535
q10	7044	2244	2171	2171
q11	458	240	244	240
q12	402	228	232	228
q13	17779	3087	3073	3073
q14	277	240	242	240
q15	513	494	490	490
q16	618	504	505	504
q17	983	682	676	676
q18	7491	7043	6936	6936
q19	1396	1027	1103	1027
q20	700	326	347	326
q21	4476	3106	2958	2958
q22	1101	999	991	991
Total cold run time: 110134 ms
Total hot run time: 38229 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4355	4291	4249	4249
q2	375	280	264	264
q3	2968	2629	2638	2629
q4	1965	1625	1647	1625
q5	5686	5692	5791	5692
q6	235	138	134	134
q7	2264	1868	1802	1802
q8	3298	3440	3528	3440
q9	8973	8886	8864	8864
q10	3652	3433	3278	3278
q11	609	513	488	488
q12	899	679	673	673
q13	13785	3296	3320	3296
q14	302	296	290	290
q15	538	493	483	483
q16	612	575	596	575
q17	1843	1552	1535	1535
q18	8142	7851	8003	7851
q19	1738	1647	1542	1542
q20	2156	1896	1894	1894
q21	5780	5507	5577	5507
q22	1110	1042	1039	1039
Total cold run time: 71285 ms
Total hot run time: 57150 ms

doris-robot · 2024-09-02T03:14:33Z

TPC-DS: Total hot run time: 192591 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit d39560609903d7887fa67d7a984b49982951f6cd, data reload: false

query1	1260	873	838	838
query2	6359	1934	1854	1854
query3	10622	3937	3864	3864
query4	59941	23909	23269	23269
query5	5366	519	488	488
query6	424	170	178	170
query7	5890	299	306	299
query8	296	207	207	207
query9	9119	2526	2500	2500
query10	487	287	266	266
query11	17479	15042	15162	15042
query12	167	109	119	109
query13	1594	398	385	385
query14	11284	7202	7529	7202
query15	243	173	165	165
query16	7574	485	496	485
query17	1190	603	591	591
query18	2065	311	312	311
query19	314	153	154	153
query20	138	115	116	115
query21	208	111	116	111
query22	4756	4418	4576	4418
query23	34254	33763	33258	33258
query24	5921	2946	2809	2809
query25	557	413	421	413
query26	703	165	160	160
query27	1783	281	288	281
query28	3771	2088	2083	2083
query29	714	416	429	416
query30	242	162	154	154
query31	969	806	789	789
query32	88	57	59	57
query33	490	304	301	301
query34	859	479	485	479
query35	857	722	733	722
query36	1052	959	931	931
query37	153	90	84	84
query38	3907	3831	3861	3831
query39	1439	1402	1400	1400
query40	206	120	119	119
query41	48	50	47	47
query42	115	99	98	98
query43	515	477	459	459
query44	1097	761	756	756
query45	205	171	181	171
query46	1086	746	724	724
query47	1839	1762	1811	1762
query48	382	308	294	294
query49	784	444	447	444
query50	816	419	434	419
query51	7208	7104	6925	6925
query52	105	89	89	89
query53	255	179	184	179
query54	578	464	464	464
query55	79	76	79	76
query56	298	266	278	266
query57	1171	1069	1075	1069
query58	245	245	247	245
query59	2968	2792	2714	2714
query60	301	283	294	283
query61	127	123	125	123
query62	745	646	662	646
query63	219	188	190	188
query64	2962	829	683	683
query65	3214	3128	3161	3128
query66	689	334	354	334
query67	15425	15350	15089	15089
query68	4465	567	584	567
query69	429	279	273	273
query70	1121	1094	1114	1094
query71	389	274	272	272
query72	6576	4058	4056	4056
query73	752	337	333	333
query74	9095	9009	8849	8849
query75	3378	2706	2665	2665
query76	1832	975	1015	975
query77	568	320	319	319
query78	9742	8990	9147	8990
query79	2280	544	550	544
query80	1211	512	510	510
query81	572	238	237	237
query82	1213	146	140	140
query83	251	151	151	151
query84	257	74	76	74
query85	961	299	330	299
query86	438	308	287	287
query87	4451	4247	4272	4247
query88	3138	2359	2359	2359
query89	396	288	288	288
query90	1828	198	199	198
query91	128	100	101	100
query92	67	53	56	53
query93	2741	543	549	543
query94	809	308	303	303
query95	360	259	265	259
query96	610	276	265	265
query97	3185	3116	3058	3058
query98	221	207	206	206
query99	1568	1273	1275	1273
Total cold run time: 313249 ms
Total hot run time: 192591 ms

github-actions · 2024-09-05T16:49:12Z

PR approved by at least one committer and no changes requested.

liaoxin01

LGTM

liaoxin01 · 2024-09-11T02:00:16Z

run buildall

doris-robot · 2024-09-11T02:23:14Z

TeamCity be ut coverage result:
Function Coverage: 36.84% (9399/25510)
Line Coverage: 28.24% (77547/274619)
Region Coverage: 27.63% (40025/144851)
Branch Coverage: 24.25% (20356/83928)
Coverage Report: http://coverage.selectdb-in.cc/coverage/417f803913a87fc46d881e3e84b79b2c50190dc4_417f803913a87fc46d881e3e84b79b2c50190dc4/report/index.html

doris-robot · 2024-09-11T02:23:24Z

TPC-H: Total hot run time: 37878 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 417f803913a87fc46d881e3e84b79b2c50190dc4, data reload: false

------ Round 1 ----------------------------------
q1	17905	4518	4406	4406
q2	2612	191	190	190
q3	11498	1150	1105	1105
q4	10542	866	740	740
q5	7861	2888	2836	2836
q6	236	142	141	141
q7	985	671	614	614
q8	9771	2090	2054	2054
q9	7158	6549	6526	6526
q10	7012	2201	2258	2201
q11	473	244	253	244
q12	400	227	225	225
q13	17959	3094	3099	3094
q14	285	237	239	237
q15	532	492	481	481
q16	516	431	435	431
q17	996	669	683	669
q18	7402	6954	6804	6804
q19	1506	771	793	771
q20	804	713	694	694
q21	2696	2480	2361	2361
q22	1079	1054	1078	1054
Total cold run time: 110228 ms
Total hot run time: 37878 ms

----- Round 2, with runtime_filter_mode=off -----
q1	3315	3211	3287	3211
q2	305	317	314	314
q3	2235	2217	2233	2217
q4	1291	1333	1323	1323
q5	4324	4310	4343	4310
q6	284	279	285	279
q7	1789	1762	1797	1762
q8	2283	2255	2288	2255
q9	6992	6959	6953	6953
q10	2820	2776	2752	2752
q11	533	524	531	524
q12	656	659	665	659
q13	11915	3347	3356	3347
q14	293	292	288	288
q15	509	514	521	514
q16	513	489	503	489
q17	1191	1168	1154	1154
q18	6833	6824	6812	6812
q19	906	881	919	881
q20	1921	1854	1879	1854
q21	4831	4950	4883	4883
q22	1074	1093	1075	1075
Total cold run time: 56813 ms
Total hot run time: 47856 ms

doris-robot · 2024-09-11T02:35:15Z

TPC-DS: Total hot run time: 192318 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 417f803913a87fc46d881e3e84b79b2c50190dc4, data reload: false

query1	905	376	377	376
query2	6501	1952	1905	1905
query3	6644	210	220	210
query4	33508	23342	23272	23272
query5	5147	504	475	475
query6	266	171	155	155
query7	4589	309	313	309
query8	274	216	214	214
query9	8566	2505	2507	2505
query10	467	271	271	271
query11	17097	14962	15139	14962
query12	156	101	101	101
query13	1640	375	367	367
query14	10998	7216	7275	7216
query15	294	170	175	170
query16	7761	421	462	421
query17	1574	567	541	541
query18	2066	296	282	282
query19	316	146	143	143
query20	115	109	108	108
query21	206	106	102	102
query22	4526	4270	4172	4172
query23	34265	33650	33593	33593
query24	11071	2898	2836	2836
query25	631	373	383	373
query26	1167	155	160	155
query27	2774	280	291	280
query28	7558	2077	2054	2054
query29	826	408	410	408
query30	320	162	154	154
query31	966	743	796	743
query32	100	58	56	56
query33	755	290	295	290
query34	956	491	509	491
query35	844	728	726	726
query36	1067	918	952	918
query37	165	91	87	87
query38	3954	3832	3862	3832
query39	1452	1404	1383	1383
query40	199	116	112	112
query41	49	46	46	46
query42	117	97	97	97
query43	517	481	471	471
query44	1237	775	753	753
query45	196	166	171	166
query46	1100	732	721	721
query47	1876	1780	1840	1780
query48	373	295	303	295
query49	1019	435	433	433
query50	810	408	427	408
query51	6962	6792	6902	6792
query52	100	85	87	85
query53	258	181	180	180
query54	880	488	466	466
query55	80	73	74	73
query56	283	266	254	254
query57	1214	1100	1066	1066
query58	241	229	236	229
query59	3045	2877	2818	2818
query60	303	270	265	265
query61	111	106	101	101
query62	823	648	656	648
query63	223	191	186	186
query64	4782	662	651	651
query65	3266	3201	3132	3132
query66	1403	333	332	332
query67	15907	15490	15256	15256
query68	3128	558	554	554
query69	398	267	267	267
query70	1194	1127	1080	1080
query71	331	270	268	268
query72	6321	4107	3987	3987
query73	746	336	327	327
query74	9295	8886	8885	8885
query75	3464	2702	2726	2702
query76	1853	994	991	991
query77	471	312	308	308
query78	9884	9332	9358	9332
query79	943	889	861	861
query80	829	805	792	792
query81	451	264	260	260
query82	283	262	260	260
query83	193	196	197	196
query84	226	107	107	107
query85	717	400	389	389
query86	325	320	318	318
query87	4366	4189	4336	4189
query88	4555	4251	4138	4138
query89	367	358	352	352
query90	1630	333	320	320
query91	128	130	123	123
query92	82	77	78	77
query93	925	916	918	916
query94	668	358	374	358
query95	451	411	418	411
query96	481	478	482	478
query97	3098	3137	3099	3099
query98	231	224	240	224
query99	1531	1306	1277	1277
Total cold run time: 289426 ms
Total hot run time: 192318 ms

doris-robot · 2024-09-11T02:40:46Z

ClickBench: Total hot run time: 31.05 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 417f803913a87fc46d881e3e84b79b2c50190dc4, data reload: false

query1	0.04	0.04	0.04
query2	0.09	0.04	0.04
query3	0.23	0.06	0.05
query4	1.65	0.07	0.07
query5	0.50	0.49	0.50
query6	1.11	0.74	0.73
query7	0.02	0.02	0.02
query8	0.06	0.04	0.04
query9	0.54	0.51	0.49
query10	0.53	0.57	0.53
query11	0.16	0.11	0.11
query12	0.15	0.12	0.12
query13	0.60	0.58	0.59
query14	1.39	1.39	1.44
query15	0.83	0.83	0.83
query16	0.37	0.40	0.39
query17	1.02	1.07	1.00
query18	0.21	0.21	0.20
query19	1.97	1.82	1.81
query20	0.02	0.01	0.01
query21	15.45	0.67	0.66
query22	4.17	7.32	1.50
query23	18.23	1.36	1.24
query24	2.08	0.23	0.24
query25	0.15	0.08	0.07
query26	0.27	0.18	0.18
query27	0.08	0.08	0.08
query28	13.23	1.02	1.01
query29	12.65	3.31	3.31
query30	0.24	0.06	0.06
query31	2.86	0.40	0.39
query32	3.24	0.48	0.47
query33	2.96	3.02	3.05
query34	16.91	4.43	4.38
query35	4.46	4.44	4.42
query36	0.66	0.49	0.51
query37	0.17	0.16	0.16
query38	0.16	0.15	0.14
query39	0.05	0.04	0.04
query40	0.16	0.13	0.13
query41	0.10	0.05	0.05
query42	0.06	0.04	0.05
query43	0.05	0.04	0.04
Total cold run time: 109.88 s
Total hot run time: 31.05 s

… to brpc (apache#40074) Currently brpc does not support resloving IPv6 hostnames, errors will be returned on `brpc::Channel::Init`. The brpc client cache may return `nullptr` on its `get_client` or `get_new_client_no_cache` APIs. This PR made the following changes: 1. Resolve hostnames from DNS cache before passing it to brpc. 2. Callers should check nullptr after get client, in case of failures.

… to brpc (#40074) (#40786) backport #40074

… to brpc (#40074) Currently brpc does not support resloving IPv6 hostnames, errors will be returned on `brpc::Channel::Init`. The brpc client cache may return `nullptr` on its `get_client` or `get_new_client_no_cache` APIs. This PR made the following changes: 1. Resolve hostnames from DNS cache before passing it to brpc. 2. Callers should check nullptr after get client, in case of failures.

dataroaring previously approved these changes Aug 28, 2024

View reviewed changes

github-actions bot added the approved Indicates a PR has been approved by one committer. label Aug 28, 2024

github-actions bot added the reviewed label Aug 28, 2024

kaijchen dismissed dataroaring’s stale review via 01a3174 August 29, 2024 02:25

github-actions bot removed the approved Indicates a PR has been approved by one committer. label Aug 29, 2024

CalvinKirs added dev/2.1.x dev/3.0.x labels Aug 29, 2024

dataroaring force-pushed the fix-brpc-client-nullptr branch from 01a3174 to 9401056 Compare August 29, 2024 14:58

kaijchen changed the title ~~[fix](brpc_client_cache) callers should check nullptr after get client~~ [fix](brpc_client_cache) resolve hostname in DNS cache before passing to brpc Aug 30, 2024

apache deleted a comment from github-actions bot Sep 5, 2024

gavinchou approved these changes Sep 5, 2024

View reviewed changes

apache deleted a comment from github-actions bot Sep 5, 2024

github-actions bot added the approved Indicates a PR has been approved by one committer. label Sep 5, 2024

apache deleted a comment from github-actions bot Sep 5, 2024

yuanyuan8983 mentioned this pull request Sep 10, 2024

[Bug] be使用ipv6地址，进行ssb压测时，全部挂掉 #40391

Closed

3 tasks

liaoxin01 approved these changes Sep 11, 2024

View reviewed changes

kaijchen added 7 commits September 11, 2024 09:59

[fix](brpc_client_cache) callers should check nullptr after get_client

51d91cd

use get_client(host, port) for dnscache

49aca67

fix compile

a3b07c3

resolve hostname before pass it to brpc

68f22b7

style

44cb3cd

fixup

802ad28

fixup

417f803

liaoxin01 force-pushed the fix-brpc-client-nullptr branch from bff912e to 417f803 Compare September 11, 2024 01:59

liaoxin01 approved these changes Sep 11, 2024

View reviewed changes

liaoxin01 merged commit 91afeec into apache:master Sep 11, 2024
22 of 26 checks passed

yiguolei added the usercase Important user case type label label Sep 13, 2024

kaijchen mentioned this pull request Sep 13, 2024

[fix](brpc_client_cache) resolve hostname in DNS cache before passing to brpc (#40074) #40786

Merged

yiguolei pushed a commit that referenced this pull request Sep 13, 2024

[fix](brpc_client_cache) resolve hostname in DNS cache before passing…

7851563

… to brpc (#40074) (#40786) backport #40074

yiguolei added dev/2.1.7-merged and removed dev/2.1.x labels Sep 13, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[fix](brpc_client_cache) resolve hostname in DNS cache before passing to brpc #40074

[fix](brpc_client_cache) resolve hostname in DNS cache before passing to brpc #40074

kaijchen commented Aug 28, 2024 •

edited

Loading

doris-robot commented Aug 28, 2024

kaijchen commented Aug 28, 2024

dataroaring left a comment

github-actions bot commented Aug 28, 2024

github-actions bot commented Aug 28, 2024

github-actions bot commented Aug 28, 2024

kaijchen commented Aug 29, 2024

github-actions bot commented Aug 29, 2024

dataroaring commented Aug 29, 2024

github-actions bot commented Aug 29, 2024

kaijchen commented Aug 30, 2024

github-actions bot commented Aug 30, 2024

doris-robot commented Aug 30, 2024

doris-robot commented Aug 30, 2024

doris-robot commented Aug 30, 2024

kaijchen commented Aug 30, 2024

github-actions bot commented Aug 30, 2024

github-actions bot commented Aug 30, 2024

kaijchen commented Sep 2, 2024

github-actions bot commented Sep 2, 2024

doris-robot commented Sep 2, 2024

doris-robot commented Sep 2, 2024

github-actions bot commented Sep 5, 2024

liaoxin01 left a comment

liaoxin01 commented Sep 11, 2024

doris-robot commented Sep 11, 2024

doris-robot commented Sep 11, 2024

doris-robot commented Sep 11, 2024

doris-robot commented Sep 11, 2024

[fix](brpc_client_cache) resolve hostname in DNS cache before passing to brpc #40074

[fix](brpc_client_cache) resolve hostname in DNS cache before passing to brpc #40074

Conversation

kaijchen commented Aug 28, 2024 • edited Loading

Proposed changes

doris-robot commented Aug 28, 2024

kaijchen commented Aug 28, 2024

dataroaring left a comment

Choose a reason for hiding this comment

github-actions bot commented Aug 28, 2024

github-actions bot commented Aug 28, 2024

github-actions bot commented Aug 28, 2024

kaijchen commented Aug 29, 2024

github-actions bot commented Aug 29, 2024

dataroaring commented Aug 29, 2024

github-actions bot commented Aug 29, 2024

kaijchen commented Aug 30, 2024

github-actions bot commented Aug 30, 2024

doris-robot commented Aug 30, 2024

doris-robot commented Aug 30, 2024

doris-robot commented Aug 30, 2024

kaijchen commented Aug 30, 2024

github-actions bot commented Aug 30, 2024

github-actions bot commented Aug 30, 2024

kaijchen commented Sep 2, 2024

github-actions bot commented Sep 2, 2024

doris-robot commented Sep 2, 2024

doris-robot commented Sep 2, 2024

github-actions bot commented Sep 5, 2024

liaoxin01 left a comment

Choose a reason for hiding this comment

liaoxin01 commented Sep 11, 2024

doris-robot commented Sep 11, 2024

doris-robot commented Sep 11, 2024

doris-robot commented Sep 11, 2024

doris-robot commented Sep 11, 2024

kaijchen commented Aug 28, 2024 •

edited

Loading