Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[refactor](loadmemlimit) remove load memlimit since it is never used #39536

Merged
merged 1 commit into from
Aug 19, 2024
Merged

[refactor](loadmemlimit) remove load memlimit since it is never used #39536

merged 1 commit into from
Aug 19, 2024

Conversation

yiguolei
Copy link
Contributor

@yiguolei yiguolei commented Aug 18, 2024 •
edited
Loading

Proposed changes

It is needed to pick to branch 21, because we will depend on it to do spill disk.

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@yiguolei
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 38140 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 118835686ec33d1a417941bdf732da56ac8f1470, data reload: false

------ Round 1 ----------------------------------
q1	17861	4553	4288	4288
q2	2065	212	204	204
q3	12066	1015	1150	1015
q4	10549	784	767	767
q5	7804	2873	2811	2811
q6	264	156	156	156
q7	1029	644	647	644
q8	9590	2113	2143	2113
q9	8813	6600	6543	6543
q10	7035	2268	2217	2217
q11	487	285	271	271
q12	441	258	254	254
q13	17790	3021	3019	3019
q14	301	266	260	260
q15	577	539	518	518
q16	509	426	406	406
q17	1008	710	783	710
q18	7576	7061	6852	6852
q19	6719	1090	1061	1061
q20	687	351	359	351
q21	3972	2646	2828	2646
q22	1134	1052	1034	1034
Total cold run time: 118277 ms
Total hot run time: 38140 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4529	4563	4307	4307
q2	404	305	297	297
q3	2861	2612	2764	2612
q4	2001	1726	1673	1673
q5	5659	5756	5667	5667
q6	247	149	152	149
q7	2196	1786	1767	1767
q8	3324	3509	3462	3462
q9	8804	8778	8755	8755
q10	3597	3333	3263	3263
q11	616	526	512	512
q12	822	657	662	657
q13	17240	3203	3141	3141
q14	324	308	291	291
q15	565	520	528	520
q16	501	447	451	447
q17	1840	1578	1521	1521
q18	8338	8042	7892	7892
q19	4611	1716	1560	1560
q20	2172	1912	1904	1904
q21	13782	5294	5399	5294
q22	1157	1071	1086	1071
Total cold run time: 85590 ms
Total hot run time: 56762 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 196559 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 118835686ec33d1a417941bdf732da56ac8f1470, data reload: false

query1	1364	937	883	883
query2	6590	2067	1972	1972
query3	10618	3881	3754	3754
query4	58749	25841	23257	23257
query5	6089	726	738	726
query6	547	215	208	208
query7	6435	330	334	330
query8	537	444	436	436
query9	9147	2594	2587	2587
query10	631	351	336	336
query11	16127	15237	15434	15237
query12	197	148	154	148
query13	1687	423	440	423
query14	12529	7858	7673	7673
query15	266	216	193	193
query16	7205	515	533	515
query17	1202	635	632	632
query18	1657	343	348	343
query19	292	181	172	172
query20	146	133	137	133
query21	248	141	145	141
query22	4539	4531	4315	4315
query23	34757	33739	34117	33739
query24	5731	3044	3148	3044
query25	586	428	453	428
query26	717	187	185	185
query27	1746	299	308	299
query28	3736	2225	2182	2182
query29	697	473	444	444
query30	235	186	197	186
query31	1041	844	892	844
query32	124	77	82	77
query33	524	350	340	340
query34	897	504	510	504
query35	869	783	795	783
query36	1079	997	934	934
query37	154	108	106	106
query38	4043	3892	3835	3835
query39	1518	1464	1483	1464
query40	237	158	156	156
query41	140	139	141	139
query42	132	120	122	120
query43	538	526	505	505
query44	1108	784	786	784
query45	227	198	198	198
query46	1135	786	782	782
query47	1917	1800	1870	1800
query48	412	332	337	332
query49	913	595	607	595
query50	867	470	482	470
query51	6910	6808	6684	6684
query52	131	110	107	107
query53	301	230	230	230
query54	624	506	496	496
query55	91	88	94	88
query56	331	316	306	306
query57	1209	1105	1114	1105
query58	296	302	298	298
query59	3100	2915	2703	2703
query60	355	322	331	322
query61	146	144	147	144
query62	809	705	700	700
query63	259	239	234	234
query64	4319	2435	1861	1861
query65	3235	3202	3190	3190
query66	1030	684	668	668
query67	15271	14972	14912	14912
query68	7690	594	604	594
query69	657	434	349	349
query70	1439	1105	1174	1105
query71	549	318	319	318
query72	6661	2292	2125	2125
query73	2227	357	362	357
query74	9210	8813	8819	8813
query75	3921	2732	2779	2732
query76	4390	1009	1039	1009
query77	828	446	442	442
query78	10268	9159	8941	8941
query79	9740	580	587	580
query80	2562	627	624	624
query81	614	262	259	259
query82	970	162	164	162
query83	368	212	215	212
query84	289	98	94	94
query85	1190	361	404	361
query86	385	307	284	284
query87	4359	4398	4186	4186
query88	4415	2475	2464	2464
query89	578	343	334	334
query90	1759	230	234	230
query91	157	127	125	125
query92	84	78	75	75
query93	5844	562	557	557
query94	711	331	339	331
query95	389	296	307	296
query96	664	287	283	283
query97	3300	3062	3108	3062
query98	246	238	224	224
query99	1851	1294	1313	1294
Total cold run time: 339614 ms
Total hot run time: 196559 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 31.3 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 118835686ec33d1a417941bdf732da56ac8f1470, data reload: false

query1	0.05	0.05	0.04
query2	0.09	0.05	0.05
query3	0.23	0.06	0.06
query4	1.66	0.08	0.08
query5	0.51	0.48	0.49
query6	1.13	0.73	0.73
query7	0.02	0.02	0.02
query8	0.05	0.05	0.05
query9	0.55	0.49	0.49
query10	0.57	0.55	0.54
query11	0.16	0.12	0.12
query12	0.16	0.13	0.12
query13	0.62	0.61	0.58
query14	0.78	0.77	0.76
query15	0.86	0.83	0.82
query16	0.37	0.37	0.38
query17	1.04	1.00	0.98
query18	0.22	0.23	0.22
query19	1.84	1.78	1.79
query20	0.01	0.01	0.02
query21	15.41	0.67	0.66
query22	4.72	7.08	1.88
query23	18.32	1.41	1.29
query24	2.08	0.21	0.21
query25	0.16	0.09	0.09
query26	0.31	0.23	0.23
query27	0.45	0.22	0.22
query28	13.38	1.02	0.99
query29	12.61	3.43	3.45
query30	0.43	0.19	0.18
query31	2.79	0.41	0.40
query32	3.25	0.48	0.48
query33	2.95	3.00	2.95
query34	17.00	4.36	4.41
query35	4.43	4.41	4.40
query36	0.67	0.49	0.50
query37	0.23	0.17	0.17
query38	0.16	0.17	0.17
query39	0.06	0.06	0.06
query40	0.19	0.15	0.15
query41	0.11	0.06	0.07
query42	0.08	0.08	0.07
query43	0.07	0.07	0.06
Total cold run time: 110.78 s
Total hot run time: 31.3 s

@hello-stephen
Copy link
Contributor

run cloudut

@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels Aug 19, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

liaoxin01
liaoxin01 approved these changes Aug 19, 2024
View reviewed changes
Copy link
Contributor

@liaoxin01 liaoxin01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yiguolei yiguolei merged commit 0b5ee48 into apache:master Aug 19, 2024
28 of 32 checks passed
yiguolei added a commit to yiguolei/incubator-doris that referenced this pull request Sep 9, 2024
@yiguolei @Doris-Extras
[refactor](loadmemlimit) remove load memlimit since it is never used (a…
cacef8d 
…pache#39536)

It is needed to pick to branch 21, because we will depend on it to do
spill disk.

Co-authored-by: yiguolei <[email protected]>
@yiguolei yiguolei mentioned this pull request Sep 9, 2024
Closed
@xinyiZzz xinyiZzz mentioned this pull request Sep 9, 2024
Closed
yiguolei added a commit to yiguolei/incubator-doris that referenced this pull request Sep 15, 2024
@yiguolei @Doris-Extras
[refactor](loadmemlimit) remove load memlimit since it is never used (a…
5baf7f1 
…pache#39536)

It is needed to pick to branch 21, because we will depend on it to do
spill disk.

Co-authored-by: yiguolei <[email protected]>
@yiguolei yiguolei mentioned this pull request Sep 15, 2024
Merged
yiguolei added a commit that referenced this pull request Sep 16, 2024
@yiguolei @Doris-Extras
[cherrypick](branch21) pick some exception handleing pr in page io (#…
a6e2364 
…40883)

## Proposed changes

pick
#39536
#39913
#39964
#40020

---------

Co-authored-by: yiguolei <[email protected]>
dataroaring pushed a commit that referenced this pull request Oct 9, 2024
@yiguolei @Doris-Extras @dataroaring
[refactor](loadmemlimit) remove load memlimit since it is never used (#…
3866590 
…39536)

## Proposed changes

It is needed to pick to branch 21, because we will depend on it to do
spill disk.

Co-authored-by: yiguolei <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liaoxin01 liaoxin01 liaoxin01 approved these changes

@Gabriel39 Gabriel39 Gabriel39 approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/2.1.7-merged reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@yiguolei @doris-robot @hello-stephen @liaoxin01 @Gabriel39 @Doris-Extras