Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug](http-api) fix core dump on API check_rpc_channel coz exec_env not init #39520

Merged
merged 2 commits into from
Aug 20, 2024
Merged

[Bug](http-api) fix core dump on API check_rpc_channel coz exec_env not init #39520

merged 2 commits into from
Aug 20, 2024

Conversation

Vallishp
Copy link
Contributor

Proposed changes

Issue Number: close #39519

Initialised the exec_env in code and verified again. no crash

[root@vallish-ThinkPad-T14s-Gen-2i doris]# !curl
curl http://127.0.0.1:8040/api/check_rpc_channel/127.0.0.1/8060/1024000
open brpc connection to 127.0.0.1:8060 success.

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@Vallishp
Copy link
Contributor Author

run buildall

@Vallishp Vallishp force-pushed the be_crash_check_rpc_channel branch 2 times, most recently from f5183bb to e05dd47 Compare August 17, 2024 09:29
@Vallishp
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 37786 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 01b857db85a1a39ab428dd91b1661ab2b34c84ee, data reload: false

------ Round 1 ----------------------------------
q1	17857	4394	4302	4302
q2	2052	213	222	213
q3	11780	1009	1110	1009
q4	10540	802	737	737
q5	7784	2823	2822	2822
q6	263	157	155	155
q7	1017	672	645	645
q8	9581	2085	2112	2085
q9	8735	6538	6571	6538
q10	7037	2194	2219	2194
q11	463	261	253	253
q12	427	247	264	247
q13	18602	2992	3014	2992
q14	300	251	256	251
q15	558	516	526	516
q16	521	408	399	399
q17	992	668	785	668
q18	7401	6802	6632	6632
q19	7392	1104	1088	1088
q20	719	340	353	340
q21	3915	3103	2701	2701
q22	1100	1031	999	999
Total cold run time: 119036 ms
Total hot run time: 37786 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4495	4326	4357	4326
q2	416	307	303	303
q3	2819	2673	2758	2673
q4	1987	1736	1719	1719
q5	5621	5738	5609	5609
q6	248	160	151	151
q7	2162	1778	1783	1778
q8	3339	3522	3462	3462
q9	8741	8720	8792	8720
q10	3587	3357	3273	3273
q11	633	529	539	529
q12	803	664	652	652
q13	17107	3170	3131	3131
q14	318	288	304	288
q15	563	515	518	515
q16	509	468	456	456
q17	1843	1526	1565	1526
q18	8536	7856	7774	7774
q19	6992	1551	1528	1528
q20	2147	1956	1888	1888
q21	13993	5345	5380	5345
q22	1143	1072	1063	1063
Total cold run time: 88002 ms
Total hot run time: 56709 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 196713 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 01b857db85a1a39ab428dd91b1661ab2b34c84ee, data reload: false

query1	1306	903	871	871
query2	6633	1997	1956	1956
query3	10660	3856	3764	3764
query4	58179	27318	23312	23312
query5	6230	731	712	712
query6	541	213	215	213
query7	6430	337	330	330
query8	550	439	443	439
query9	9443	2593	2547	2547
query10	611	355	334	334
query11	16506	15184	15507	15184
query12	215	128	129	128
query13	1677	436	447	436
query14	12458	7142	7711	7142
query15	334	199	188	188
query16	7506	554	542	542
query17	1455	636	613	613
query18	1540	338	338	338
query19	287	171	170	170
query20	149	138	219	138
query21	246	146	143	143
query22	4682	4308	4446	4308
query23	34459	33894	33876	33876
query24	5662	2973	3019	2973
query25	621	434	424	424
query26	719	186	181	181
query27	1915	300	308	300
query28	3737	2207	2167	2167
query29	686	439	445	439
query30	230	184	193	184
query31	1041	830	809	809
query32	127	77	78	77
query33	545	343	338	338
query34	887	510	496	496
query35	868	776	761	761
query36	1107	947	979	947
query37	163	102	102	102
query38	4051	3898	3890	3890
query39	1530	1487	1472	1472
query40	236	157	154	154
query41	141	138	136	136
query42	167	120	118	118
query43	557	513	524	513
query44	1116	777	797	777
query45	225	196	194	194
query46	1108	804	749	749
query47	1899	1848	1831	1831
query48	406	343	341	341
query49	930	578	574	574
query50	885	460	456	456
query51	6833	6746	6639	6639
query52	122	108	111	108
query53	300	233	231	231
query54	617	497	520	497
query55	91	88	91	88
query56	324	303	307	303
query57	1197	1133	1139	1133
query58	305	307	299	299
query59	2950	2877	2886	2877
query60	366	317	330	317
query61	147	147	142	142
query62	790	698	689	689
query63	256	224	227	224
query64	4352	2345	3043	2345
query65	3273	3196	3145	3145
query66	1018	694	665	665
query67	15487	14980	15117	14980
query68	6062	578	586	578
query69	618	426	382	382
query70	1223	1110	1095	1095
query71	554	309	305	305
query72	6985	2301	2053	2053
query73	791	354	360	354
query74	9512	8817	8936	8817
query75	4020	2726	2754	2726
query76	3750	1130	1048	1048
query77	790	436	432	432
query78	9808	9077	9689	9077
query79	2422	553	559	553
query80	2361	655	614	614
query81	606	259	259	259
query82	604	164	162	162
query83	365	216	213	213
query84	302	104	100	100
query85	1170	352	354	352
query86	477	317	329	317
query87	4458	4316	4212	4212
query88	4104	2446	2454	2446
query89	426	328	323	323
query90	2030	237	232	232
query91	158	125	131	125
query92	91	80	76	76
query93	2622	546	542	542
query94	937	329	335	329
query95	389	294	295	294
query96	618	290	286	286
query97	3269	3088	3109	3088
query98	243	228	231	228
query99	1577	1337	1326	1326
Total cold run time: 325426 ms
Total hot run time: 196713 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 31.45 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 01b857db85a1a39ab428dd91b1661ab2b34c84ee, data reload: false

query1	0.04	0.05	0.04
query2	0.08	0.04	0.04
query3	0.23	0.06	0.05
query4	1.67	0.07	0.07
query5	0.51	0.52	0.48
query6	1.12	0.73	0.72
query7	0.02	0.02	0.02
query8	0.05	0.05	0.05
query9	0.55	0.50	0.48
query10	0.54	0.55	0.54
query11	0.16	0.13	0.12
query12	0.16	0.13	0.13
query13	0.61	0.60	0.59
query14	0.77	0.78	0.78
query15	0.86	0.83	0.82
query16	0.37	0.35	0.37
query17	1.06	1.04	1.00
query18	0.23	0.22	0.23
query19	1.89	1.81	1.83
query20	0.01	0.02	0.01
query21	15.40	0.67	0.65
query22	4.57	6.38	2.12
query23	18.31	1.35	1.22
query24	2.06	0.22	0.23
query25	0.16	0.09	0.09
query26	0.31	0.23	0.23
query27	0.46	0.23	0.23
query28	13.30	1.03	1.02
query29	12.66	3.36	3.33
query30	0.43	0.25	0.24
query31	2.86	0.40	0.41
query32	3.25	0.49	0.48
query33	2.96	2.96	2.94
query34	17.09	4.36	4.31
query35	4.37	4.43	4.43
query36	0.67	0.48	0.50
query37	0.22	0.18	0.17
query38	0.18	0.16	0.16
query39	0.07	0.06	0.06
query40	0.18	0.15	0.15
query41	0.11	0.07	0.08
query42	0.08	0.07	0.07
query43	0.07	0.06	0.06
Total cold run time: 110.7 s
Total hot run time: 31.45 s

yiguolei
yiguolei approved these changes Aug 17, 2024
View reviewed changes
Copy link
Contributor

@yiguolei yiguolei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Aug 17, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

dataroaring
dataroaring approved these changes Aug 18, 2024
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yiguolei
Copy link
Contributor

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 38004 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 70911ad8d010e86c52043cb8de473ef109b27a18, data reload: false

------ Round 1 ----------------------------------
q1	17858	4382	4317	4317
q2	2047	223	204	204
q3	12068	956	1160	956
q4	10524	766	784	766
q5	7761	2816	2830	2816
q6	262	158	160	158
q7	1023	686	646	646
q8	9576	2069	2120	2069
q9	7824	6590	6551	6551
q10	7057	2262	2210	2210
q11	480	285	270	270
q12	434	255	253	253
q13	17773	2979	2956	2956
q14	308	258	253	253
q15	552	539	527	527
q16	524	424	419	419
q17	1000	637	696	637
q18	7396	6808	6651	6651
q19	6617	1189	1110	1110
q20	727	355	361	355
q21	3903	2902	2838	2838
q22	1159	1056	1042	1042
Total cold run time: 116873 ms
Total hot run time: 38004 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4601	4365	4319	4319
q2	403	317	318	317
q3	2915	2604	2612	2604
q4	1984	1657	1666	1657
q5	5709	5682	5739	5682
q6	241	153	145	145
q7	2188	1740	1770	1740
q8	3288	3490	3498	3490
q9	8810	8813	8743	8743
q10	3556	3399	3362	3362
q11	654	542	541	541
q12	839	665	674	665
q13	16244	3175	3186	3175
q14	332	297	294	294
q15	562	522	506	506
q16	498	444	437	437
q17	1847	1548	1537	1537
q18	8662	7885	7791	7791
q19	9692	1551	1481	1481
q20	2178	1918	1914	1914
q21	13995	5291	5256	5256
q22	1187	1097	1084	1084
Total cold run time: 90385 ms
Total hot run time: 56740 ms

@Vallishp
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 38219 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit be340f87b80bcd3d06b4844406b0ec5cd3f1b80a, data reload: false

------ Round 1 ----------------------------------
q1	17847	4412	4345	4345
q2	2054	209	216	209
q3	11761	1011	1169	1011
q4	10518	709	761	709
q5	7799	2841	2798	2798
q6	271	163	163	163
q7	1039	665	666	665
q8	9617	2119	2105	2105
q9	8801	6564	6591	6564
q10	7047	2244	2192	2192
q11	501	265	270	265
q12	418	252	247	247
q13	17796	2999	2986	2986
q14	296	256	250	250
q15	558	520	539	520
q16	515	404	404	404
q17	984	699	744	699
q18	7395	6730	6840	6730
q19	7850	1059	1099	1059
q20	706	352	347	347
q21	4399	3158	2917	2917
q22	1155	1055	1034	1034
Total cold run time: 119327 ms
Total hot run time: 38219 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4610	4370	4312	4312
q2	392	295	311	295
q3	2859	2700	2724	2700
q4	2041	1714	1700	1700
q5	5597	5766	5635	5635
q6	240	162	154	154
q7	2150	1764	1806	1764
q8	3358	3520	3468	3468
q9	8794	8748	8794	8748
q10	3604	3312	3251	3251
q11	632	540	558	540
q12	853	678	631	631
q13	15894	3225	3031	3031
q14	325	292	290	290
q15	563	527	525	525
q16	531	464	465	464
q17	1848	1573	1558	1558
q18	8223	7834	7822	7822
q19	7280	1742	1631	1631
q20	2218	1902	1888	1888
q21	14245	5392	5383	5383
q22	1187	1089	1099	1089
Total cold run time: 87444 ms
Total hot run time: 56879 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 195522 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit be340f87b80bcd3d06b4844406b0ec5cd3f1b80a, data reload: false

query1	1334	913	895	895
query2	6720	1969	1937	1937
query3	10650	3827	3868	3827
query4	58219	24306	23245	23245
query5	6113	721	715	715
query6	541	204	225	204
query7	6405	326	326	326
query8	544	449	432	432
query9	9442	2529	2524	2524
query10	596	341	330	330
query11	15747	15051	15384	15051
query12	230	129	130	129
query13	1669	440	434	434
query14	12014	7098	6646	6646
query15	281	216	197	197
query16	7606	534	500	500
query17	1196	618	603	603
query18	2106	371	401	371
query19	331	178	167	167
query20	144	135	134	134
query21	248	146	146	146
query22	4529	4254	4211	4211
query23	34445	33701	34055	33701
query24	5715	2966	3055	2966
query25	574	429	442	429
query26	715	184	183	183
query27	1754	302	306	302
query28	4144	2190	2178	2178
query29	737	461	457	457
query30	244	191	193	191
query31	1056	817	815	815
query32	102	78	78	78
query33	511	346	344	344
query34	906	507	495	495
query35	871	767	768	767
query36	1093	939	941	939
query37	161	104	107	104
query38	4011	3820	3879	3820
query39	1560	1486	1475	1475
query40	243	154	153	153
query41	142	136	136	136
query42	136	114	118	114
query43	545	511	498	498
query44	1128	775	791	775
query45	228	201	196	196
query46	1132	788	794	788
query47	1904	1851	1852	1851
query48	421	347	338	338
query49	919	593	579	579
query50	863	460	479	460
query51	6760	6689	6847	6689
query52	117	109	109	109
query53	309	228	221	221
query54	609	505	504	504
query55	91	91	90	90
query56	332	306	333	306
query57	1196	1133	1123	1123
query58	295	297	301	297
query59	2995	2781	2741	2741
query60	351	329	340	329
query61	148	144	145	144
query62	797	709	708	708
query63	258	226	229	226
query64	3362	1900	1876	1876
query65	3205	3201	3194	3194
query66	1034	673	720	673
query67	15194	15056	15066	15056
query68	5964	578	583	578
query69	586	313	324	313
query70	1203	1183	1173	1173
query71	535	322	312	312
query72	7609	2311	2099	2099
query73	806	355	355	355
query74	9496	8905	8867	8867
query75	4441	2783	2772	2772
query76	3341	1102	1028	1028
query77	821	432	492	432
query78	10594	9408	9138	9138
query79	9286	555	559	555
query80	1042	601	605	601
query81	599	262	255	255
query82	799	159	156	156
query83	417	212	214	212
query84	296	97	95	95
query85	809	362	358	358
query86	420	297	307	297
query87	4424	4233	4242	4233
query88	5144	2466	2467	2466
query89	535	328	330	328
query90	2072	229	230	229
query91	156	128	159	128
query92	83	75	76	75
query93	5727	535	541	535
query94	772	314	319	314
query95	387	298	300	298
query96	635	287	287	287
query97	3252	3081	3043	3043
query98	253	228	231	228
query99	1599	1320	1341	1320
Total cold run time: 334081 ms
Total hot run time: 195522 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 31.51 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit be340f87b80bcd3d06b4844406b0ec5cd3f1b80a, data reload: false

query1	0.05	0.04	0.04
query2	0.08	0.05	0.04
query3	0.23	0.06	0.05
query4	1.65	0.10	0.10
query5	0.51	0.51	0.50
query6	1.13	0.73	0.72
query7	0.02	0.01	0.01
query8	0.06	0.05	0.05
query9	0.55	0.49	0.48
query10	0.55	0.55	0.54
query11	0.17	0.13	0.13
query12	0.16	0.12	0.12
query13	0.62	0.59	0.59
query14	0.78	0.79	0.78
query15	0.86	0.85	0.84
query16	0.37	0.38	0.35
query17	1.07	1.02	1.02
query18	0.21	0.20	0.21
query19	1.85	1.75	1.76
query20	0.01	0.01	0.01
query21	15.39	0.66	0.65
query22	3.92	7.41	2.44
query23	18.26	1.43	1.25
query24	2.05	0.24	0.23
query25	0.16	0.08	0.08
query26	0.26	0.18	0.19
query27	0.09	0.08	0.08
query28	13.22	1.04	1.01
query29	12.66	3.32	3.28
query30	0.43	0.19	0.20
query31	2.79	0.41	0.39
query32	3.25	0.48	0.49
query33	2.93	3.02	2.98
query34	17.10	4.30	4.30
query35	4.43	4.41	4.41
query36	0.68	0.48	0.48
query37	0.21	0.17	0.18
query38	0.17	0.18	0.17
query39	0.07	0.06	0.06
query40	0.18	0.16	0.16
query41	0.11	0.07	0.07
query42	0.07	0.07	0.07
query43	0.07	0.06	0.07
Total cold run time: 109.43 s
Total hot run time: 31.51 s

@yiguolei yiguolei merged commit a18615c into apache:master Aug 20, 2024
25 of 28 checks passed
@yiguolei yiguolei added the p0_c label Aug 20, 2024
This was referenced Aug 21, 2024
Merged
Closed
yiguolei pushed a commit that referenced this pull request Aug 21, 2024
@Vallishp
[cherry-pick](branch-2.1) [Bug](http-api) fix core dump on API check_…
935d0eb 
…rpc_channel coz exec_env not initialized #39519 (#39692)

…rpc_channel coz exec_env not initialized #39519

## Proposed changes

Issue Number: close #xxx
backport #39519  #39520
dataroaring pushed a commit that referenced this pull request Aug 26, 2024
@Vallishp @dataroaring
[Bug](http-api) fix core dump on API check_rpc_channel coz exec_env n…
5a88618 
…ot init (#39520)

## Proposed changes

Issue Number: close #39519

Initialised the exec_env in code and verified again. no crash

[root@vallish-ThinkPad-T14s-Gen-2i doris]# !curl
**curl
http://127.0.0.1:8040/api/check_rpc_channel/127.0.0.1/8060/1024000
open brpc connection to 127.0.0.1:8060 success.**
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yiguolei yiguolei yiguolei approved these changes

@dataroaring dataroaring dataroaring approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/2.1.6-merged dev/3.0.2-merged p0_c reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug](http-api) fix core dump on API check_rpc_channel coz exec_env not initialized
4 participants
@Vallishp @doris-robot @yiguolei @dataroaring