Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix](Nereids) polish function signature search algorithm (#38497) #39445

Merged
merged 1 commit into from
Aug 16, 2024
Merged

[fix](Nereids) polish function signature search algorithm (#38497) #39445

merged 1 commit into from
Aug 16, 2024

Conversation

morrySnow
Copy link
Contributor

pick from master #38497 and #39342

use double first

  • fmod
  • pmod

let return type same as parameter's type

  • if

let greatest / least work same as mysql's greatest

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@morrySnow
Copy link
Contributor Author

run buildall

@morrySnow
Copy link
Contributor Author

run buildall

@github-actions github-actions bot added the kind/docs Categorizes issue or PR as related to documentation. label Aug 15, 2024
@morrySnow
[fix](Nereids) polish function signature search algorithm (apache#38497)
24de5a6 
pick from master apache#38497 and apache#39342

use double first
- fmod
- pmod

let return type same as parameter's type
- if

let greatest / least work same as mysql's greatest
@morrySnow
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 49914 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 24de5a63759190dc916714128c407e1dc4dedff3, data reload: false

------ Round 1 ----------------------------------
q1	17686	4416	4349	4349
q2	2087	160	149	149
q3	10430	1865	1925	1865
q4	10379	1247	1341	1247
q5	8584	3915	3924	3915
q6	257	128	127	127
q7	2069	1602	1601	1601
q8	9341	2721	2691	2691
q9	11058	10595	10379	10379
q10	8650	3570	3529	3529
q11	422	255	250	250
q12	465	315	307	307
q13	18380	4000	4021	4000
q14	356	335	327	327
q15	510	452	462	452
q16	684	580	577	577
q17	1126	971	993	971
q18	7316	6789	6859	6789
q19	1685	1595	1571	1571
q20	535	307	325	307
q21	4461	4126	4121	4121
q22	492	390	392	390
Total cold run time: 116973 ms
Total hot run time: 49914 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4345	4386	4310	4310
q2	323	227	223	223
q3	4152	4168	4137	4137
q4	2766	2742	2753	2742
q5	7199	7144	7134	7134
q6	237	122	120	120
q7	3340	2876	2904	2876
q8	4370	4468	4477	4468
q9	17317	17213	17000	17000
q10	4216	4269	4298	4269
q11	802	691	694	691
q12	1020	839	859	839
q13	6858	3745	3772	3745
q14	447	434	421	421
q15	499	456	459	456
q16	734	689	671	671
q17	3817	3886	3872	3872
q18	8800	8784	8858	8784
q19	1706	1691	1647	1647
q20	2379	2156	2092	2092
q21	8429	8534	8406	8406
q22	1025	946	934	934
Total cold run time: 84781 ms
Total hot run time: 79837 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 204047 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 24de5a63759190dc916714128c407e1dc4dedff3, data reload: false

query1	921	403	413	403
query2	6550	2224	2156	2156
query3	6926	204	205	204
query4	20967	18110	18145	18110
query5	19734	6549	6614	6549
query6	354	220	235	220
query7	4508	301	308	301
query8	252	289	253	253
query9	3185	2758	2702	2702
query10	425	310	311	310
query11	11346	10778	10879	10778
query12	126	81	76	76
query13	5613	668	666	666
query14	18467	13967	14015	13967
query15	364	221	232	221
query16	6433	277	263	263
query17	1663	1465	887	887
query18	2294	418	419	418
query19	213	151	155	151
query20	80	80	87	80
query21	190	95	95	95
query22	5141	5033	4902	4902
query23	32676	32087	32049	32049
query24	6783	6543	6624	6543
query25	525	435	426	426
query26	531	167	165	165
query27	1844	305	306	305
query28	6144	2341	2311	2311
query29	2936	2752	2735	2735
query30	249	172	173	172
query31	903	745	752	745
query32	69	64	60	60
query33	425	258	270	258
query34	860	472	483	472
query35	1146	957	913	913
query36	1583	1180	1222	1180
query37	90	66	62	62
query38	3081	2924	2967	2924
query39	1388	1354	1322	1322
query40	218	98	99	98
query41	42	37	36	36
query42	86	87	84	84
query43	650	813	614	614
query44	1144	720	722	720
query45	243	233	233	233
query46	1242	972	997	972
query47	1808	1741	1697	1697
query48	981	681	684	681
query49	625	381	391	381
query50	859	641	635	635
query51	4733	4680	4637	4637
query52	102	80	81	80
query53	452	320	320	320
query54	2667	2476	2479	2476
query55	92	93	86	86
query56	223	215	214	214
query57	1113	1144	1230	1144
query58	219	209	202	202
query59	3547	3289	3437	3289
query60	224	193	210	193
query61	104	100	111	100
query62	810	497	477	477
query63	487	347	351	347
query64	2587	1556	1490	1490
query65	3648	3612	3547	3547
query66	820	384	378	378
query67	15426	17271	15129	15129
query68	10017	662	662	662
query69	587	361	379	361
query70	1784	1483	1592	1483
query71	425	317	319	317
query72	6648	3526	3543	3526
query73	742	330	328	328
query74	6330	5947	5840	5840
query75	5447	3757	3744	3744
query76	6446	1179	1231	1179
query77	1099	268	257	257
query78	12808	12020	11823	11823
query79	9389	655	646	646
query80	1255	407	412	407
query81	497	239	234	234
query82	1619	101	101	101
query83	169	136	136	136
query84	257	73	73	73
query85	882	332	338	332
query86	345	336	298	298
query87	3258	3070	3117	3070
query88	4678	2308	2333	2308
query89	488	305	297	297
query90	1968	205	214	205
query91	167	123	124	123
query92	61	56	59	56
query93	6998	602	605	602
query94	713	219	213	213
query95	1115	1076	1046	1046
query96	642	328	326	326
query97	6507	6491	6414	6414
query98	202	185	173	173
query99	2928	853	992	853
Total cold run time: 318608 ms
Total hot run time: 204047 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.98 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 24de5a63759190dc916714128c407e1dc4dedff3, data reload: false

query1	0.03	0.02	0.02
query2	0.07	0.03	0.03
query3	0.25	0.04	0.04
query4	1.78	0.06	0.06
query5	0.54	0.53	0.51
query6	1.24	0.63	0.61
query7	0.02	0.01	0.01
query8	0.03	0.02	0.02
query9	0.54	0.49	0.49
query10	0.54	0.54	0.54
query11	0.12	0.08	0.08
query12	0.11	0.09	0.09
query13	0.63	0.61	0.60
query14	0.77	0.80	0.79
query15	0.80	0.77	0.77
query16	0.36	0.36	0.36
query17	1.02	1.04	1.02
query18	0.21	0.27	0.25
query19	1.94	1.86	1.89
query20	0.02	0.01	0.01
query21	15.44	0.56	0.55
query22	2.01	2.21	1.75
query23	17.30	1.13	1.00
query24	4.95	4.12	1.03
query25	0.41	0.08	0.06
query26	0.79	0.16	0.15
query27	0.05	0.03	0.03
query28	5.23	0.76	0.71
query29	12.63	2.34	2.24
query30	0.53	0.52	0.49
query31	2.80	0.39	0.37
query32	3.35	0.49	0.49
query33	3.11	3.04	3.10
query34	15.26	4.83	4.81
query35	4.85	4.87	4.85
query36	1.05	1.01	1.04
query37	0.06	0.05	0.04
query38	0.04	0.02	0.02
query39	0.02	0.02	0.01
query40	0.16	0.14	0.14
query41	0.07	0.01	0.01
query42	0.02	0.01	0.01
query43	0.02	0.01	0.01
Total cold run time: 101.17 s
Total hot run time: 30.98 s

@doris-robot
Copy link

Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'

Load test result on commit 24de5a63759190dc916714128c407e1dc4dedff3 with default session variables
Stream load json:         19 seconds loaded 2358488459 Bytes, about 118 MB/s
Stream load orc:          58 seconds loaded 1101869774 Bytes, about 18 MB/s
Stream load parquet:      31 seconds loaded 861443392 Bytes, about 26 MB/s
Insert into select:       22.2 seconds inserted 10000000 Rows, about 450K ops/s

@morrySnow morrySnow merged commit 0adf48a into apache:branch-2.0 Aug 16, 2024
22 of 24 checks passed
@morrySnow morrySnow deleted the 2.0_38497 branch August 16, 2024 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area/nereids kind/docs Categorizes issue or PR as related to documentation. kind/test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@morrySnow @doris-robot