Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix](Nereids) set operation output nullable maybe wrong (#39109) #39444

Merged
merged 1 commit into from
Aug 16, 2024

Conversation

morrySnow
Copy link
Contributor

pick from master #39109

when first regulator child output nullable is not right, we may get wrong nullable output, and lead be crash

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@morrySnow
Copy link
Contributor Author

run buildall

@github-actions github-actions bot added the kind/docs Categorizes issue or PR as related to documentation. label Aug 15, 2024
@morrySnow
Copy link
Contributor Author

run buildall

pick from master apache#39109

when first regulator child output nullable is not right, we may get
wrong nullable output, and lead be crash
@morrySnow
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 49445 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 7fdc9029a8c3961eaa6aedb20e988d71c48019a4, data reload: false

------ Round 1 ----------------------------------
q1	18177	4353	4328	4328
q2	2076	155	148	148
q3	10454	1872	1876	1872
q4	10297	1269	1320	1269
q5	8453	3870	3894	3870
q6	230	126	129	126
q7	2004	1609	1572	1572
q8	9332	2717	2689	2689
q9	10585	10284	10188	10188
q10	8627	3514	3496	3496
q11	432	245	252	245
q12	464	310	305	305
q13	18367	4000	4055	4000
q14	353	317	343	317
q15	508	467	465	465
q16	679	581	572	572
q17	1120	947	984	947
q18	7225	6765	6734	6734
q19	1697	1564	1547	1547
q20	546	338	319	319
q21	4413	4079	4047	4047
q22	492	389	396	389
Total cold run time: 116531 ms
Total hot run time: 49445 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4355	4338	4295	4295
q2	322	230	222	222
q3	4150	4160	4131	4131
q4	2748	2735	2733	2733
q5	7128	7156	7080	7080
q6	234	122	117	117
q7	3221	2865	2841	2841
q8	4325	4430	4437	4430
q9	16868	16676	16737	16676
q10	4231	4263	4240	4240
q11	759	698	673	673
q12	1029	845	844	844
q13	7056	3766	3742	3742
q14	449	435	439	435
q15	501	465	457	457
q16	735	685	698	685
q17	3836	3867	3865	3865
q18	8736	8695	8690	8690
q19	1687	1697	1669	1669
q20	2366	2157	2166	2157
q21	8537	8446	8460	8446
q22	995	947	928	928
Total cold run time: 84268 ms
Total hot run time: 79356 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 201953 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 7fdc9029a8c3961eaa6aedb20e988d71c48019a4, data reload: false

query1	921	387	412	387
query2	6523	2198	2102	2102
query3	6925	206	201	201
query4	21099	18182	18079	18079
query5	19742	6470	6488	6470
query6	282	225	243	225
query7	4168	294	307	294
query8	293	259	228	228
query9	3135	2731	2656	2656
query10	446	326	296	296
query11	11433	10810	10711	10711
query12	118	80	75	75
query13	5589	658	644	644
query14	18039	13389	13252	13252
query15	379	221	221	221
query16	6736	285	264	264
query17	1742	1461	884	884
query18	2306	412	418	412
query19	230	151	149	149
query20	80	76	80	76
query21	189	94	94	94
query22	5256	4996	4975	4975
query23	32467	31863	32048	31863
query24	6885	6534	6460	6460
query25	517	432	420	420
query26	534	157	162	157
query27	1879	292	298	292
query28	6143	2311	2280	2280
query29	2907	2757	2873	2757
query30	245	170	165	165
query31	903	740	740	740
query32	70	69	58	58
query33	407	255	246	246
query34	835	467	464	464
query35	1111	920	924	920
query36	1236	1301	1057	1057
query37	92	59	63	59
query38	3076	2904	2928	2904
query39	1360	1338	1328	1328
query40	215	96	90	90
query41	39	42	36	36
query42	78	87	84	84
query43	576	662	561	561
query44	1115	728	726	726
query45	244	235	227	227
query46	1235	952	958	952
query47	2115	1776	1729	1729
query48	976	680	700	680
query49	618	374	386	374
query50	869	623	572	572
query51	4745	4601	4669	4601
query52	85	90	74	74
query53	450	334	308	308
query54	2630	2435	2464	2435
query55	79	82	83	82
query56	220	236	202	202
query57	1191	1060	1185	1060
query58	220	216	217	216
query59	3484	3312	3311	3311
query60	212	198	214	198
query61	96	93	100	93
query62	885	453	435	435
query63	489	341	343	341
query64	2258	1518	1532	1518
query65	3601	3577	3562	3562
query66	816	376	381	376
query67	16060	15299	17374	15299
query68	9099	679	664	664
query69	592	349	356	349
query70	1519	1416	1413	1413
query71	416	321	329	321
query72	6559	3473	3465	3465
query73	745	325	321	321
query74	6300	5846	5827	5827
query75	5364	3825	3828	3825
query76	5659	1156	1218	1156
query77	942	272	260	260
query78	13271	11954	11600	11600
query79	9174	638	636	636
query80	847	401	410	401
query81	494	231	229	229
query82	1278	101	95	95
query83	187	129	136	129
query84	261	71	71	71
query85	722	327	319	319
query86	327	291	297	291
query87	3201	2995	3054	2995
query88	4852	2313	2288	2288
query89	417	341	308	308
query90	1914	215	200	200
query91	160	121	121	121
query92	59	51	53	51
query93	6188	612	578	578
query94	652	215	207	207
query95	1106	1055	1052	1052
query96	646	329	324	324
query97	6495	6352	6426	6352
query98	201	175	177	175
query99	2815	923	1013	923
Total cold run time: 314361 ms
Total hot run time: 201953 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 31.3 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 7fdc9029a8c3961eaa6aedb20e988d71c48019a4, data reload: false

query1	0.02	0.03	0.02
query2	0.07	0.03	0.02
query3	0.26	0.05	0.04
query4	1.78	0.07	0.07
query5	0.54	0.52	0.52
query6	1.22	0.62	0.61
query7	0.01	0.00	0.01
query8	0.03	0.03	0.02
query9	0.54	0.50	0.49
query10	0.53	0.53	0.54
query11	0.12	0.09	0.09
query12	0.12	0.09	0.10
query13	0.62	0.61	0.61
query14	0.78	0.80	0.79
query15	0.76	0.76	0.76
query16	0.38	0.40	0.37
query17	1.04	1.04	0.99
query18	0.24	0.25	0.24
query19	1.94	1.88	1.85
query20	0.01	0.00	0.00
query21	15.45	0.56	0.54
query22	2.40	2.08	1.58
query23	16.24	0.93	0.82
query24	4.47	1.64	1.90
query25	0.39	0.09	0.04
query26	0.67	0.15	0.15
query27	0.05	0.05	0.04
query28	7.10	0.77	0.70
query29	12.67	2.33	2.33
query30	0.63	0.54	0.55
query31	2.82	0.39	0.38
query32	3.36	0.50	0.49
query33	3.08	3.08	3.07
query34	15.28	4.81	4.78
query35	4.84	4.84	4.82
query36	1.10	1.02	1.01
query37	0.06	0.04	0.05
query38	0.03	0.02	0.02
query39	0.02	0.02	0.01
query40	0.17	0.14	0.14
query41	0.07	0.02	0.02
query42	0.02	0.02	0.02
query43	0.03	0.01	0.02
Total cold run time: 101.96 s
Total hot run time: 31.3 s

@doris-robot
Copy link

Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'

Load test result on commit 7fdc9029a8c3961eaa6aedb20e988d71c48019a4 with default session variables
Stream load json:         19 seconds loaded 2358488459 Bytes, about 118 MB/s
Stream load orc:          58 seconds loaded 1101869774 Bytes, about 18 MB/s
Stream load parquet:      31 seconds loaded 861443392 Bytes, about 26 MB/s
Insert into select:       21.1 seconds inserted 10000000 Rows, about 473K ops/s

@morrySnow
Copy link
Contributor Author

run p0

@morrySnow morrySnow merged commit f247513 into apache:branch-2.0 Aug 16, 2024
22 of 24 checks passed
@morrySnow morrySnow deleted the 2.0_39109 branch August 16, 2024 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/nereids kind/docs Categorizes issue or PR as related to documentation. kind/test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants