[fix](Nereids) fixed the limit offset error #39316
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
|
run buildall |
TPC-H: Total hot run time: 39866 ms |
morrySnow
reviewed
Aug 13, 2024
Comment on lines
22
to
25
| def DBname = "limit_test_db" | ||
| sql "DROP DATABASE IF EXISTS ${DBname}" | ||
| sql "CREATE DATABASE IF NOT EXISTS ${DBname}" | ||
| sql "use ${DBname}" |
There was a problem hiding this comment.
done,It has been deleted
| PlanFragment inputFragment = physicalLimit.child(0).accept(this, context); | ||
| PlanNode child = inputFragment.getPlanRoot(); | ||
| child.setLimit(MergeLimits.mergeLimit(physicalLimit.getLimit(), physicalLimit.getOffset(), child.getLimit())); | ||
| if (childPlan instanceof PhysicalLimit) { |
There was a problem hiding this comment.
the better way fix this problem
- revert this PR [fix](Nereids): fix offset in PlanTranslator #29789
- translate global limit into exchange, if its child is not a exchange node. refer to org.apache.doris.nereids.glue.translator.PhysicalPlanTranslator#visitPhysicalTopN
TPC-DS: Total hot run time: 184409 ms |
ClickBench: Total hot run time: 30.74 s |
|
run buildall |
TPC-H: Total hot run time: 39716 ms |
TPC-DS: Total hot run time: 191240 ms |
ClickBench: Total hot run time: 30.16 s |
lide-reed
reviewed
Aug 14, 2024
|
|
||
| if (!(inputFragment.getPlanRoot() instanceof ExchangeNode)) { | ||
| inputFragment.getPlanRoot().setLimit(physicalLimit.getLimit()); | ||
| inputFragment.getPlanRoot().setOffset(physicalLimit.getOffset()); |
There was a problem hiding this comment.
Here the inputFragment.getPlanRoot() should replace with the varaible child which defined above.
|
run buildall |
TPC-H: Total hot run time: 37791 ms |
|
run buildall |
TPC-H: Total hot run time: 37663 ms |
TPC-DS: Total hot run time: 184204 ms |
ClickBench: Total hot run time: 31.53 s |
|
run buildall |
TPC-H: Total hot run time: 37445 ms |
TPC-DS: Total hot run time: 189937 ms |
ClickBench: Total hot run time: 31.56 s |
|
run compile |
|
run p0 |
|
run cloud_p0 |
|
run cloud_p1 |
1 similar comment
|
run cloud_p1 |
|
run buildall |
morrySnow
previously approved these changes
Sep 4, 2024
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
the
approved
|
PR approved by anyone and no changes requested. |
|
run buildall |
1 similar comment
|
run buildall |
github-actions
bot
removed
the
approved
|
run buildall |
|
run p0 |
|
run buildall |
|
run buildall |
|
run buildall |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue Number: close #36699