[opt](merge-on-write) Skip the alignment process of some rowsets in partial update #38487 #38686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
|
run buildall |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -165,6 +165,7 @@ class Rowset : public std::enable_shared_from_this<Rowset> { | |||
| bool is_segments_overlapping() const { return rowset_meta()->is_segments_overlapping(); } | |||
| KeysType keys_type() { return _schema->keys_type(); } | |||
| RowsetStatePB rowset_meta_state() const { return rowset_meta()->rowset_state(); } | |||
| bool produced_by_compaction() const { return rowset_meta()->produced_by_compaction(); } | |||
There was a problem hiding this comment.
warning: function 'produced_by_compaction' should be marked [[nodiscard]] [modernize-use-nodiscard]
Suggested change
| bool produced_by_compaction() const { return rowset_meta()->produced_by_compaction(); } | |
| ; }[[nodiscard]] |
| @@ -302,6 +302,12 @@ class RowsetMeta { | |||
| return num_segments() > 1 && is_singleton_delta() && segments_overlap() != NONOVERLAPPING; | |||
| } | |||
|
|
|||
| bool produced_by_compaction() const { | |||
There was a problem hiding this comment.
warning: function 'produced_by_compaction' should be marked [[nodiscard]] [modernize-use-nodiscard]
Suggested change
| bool produced_by_compaction() const { | |
| [[nodiscard]] bool produced_by_compaction() const { |
|
run buildall |
TPC-H: Total hot run time: 49933 ms |
|
TeamCity be ut coverage result: |
TPC-DS: Total hot run time: 204996 ms |
ClickBench: Total hot run time: 30.27 s |
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
xiaokang
changed the title
|
run p0 |
|
run p1 |
2 similar comments
|
run p1 |
|
run p1 |
bobhan1
force-pushed
the
branch-2.0-pick-38487
branch
from
84a410a
to
0f63bcf
Compare
|
run buildall |
|
TeamCity be ut coverage result: |
TPC-H: Total hot run time: 50139 ms |
TPC-DS: Total hot run time: 204038 ms |
ClickBench: Total hot run time: 30.65 s |
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
GoGoWen
pushed a commit
to GoGoWen/incubator-doris
that referenced
this pull request
Aug 27, 2024
…artial update apache#38487 (apache#38686) ## Proposed changes picks apache#38487 regression cases are commented currently.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
picks #38487
regression cases are commented currently.