-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bugfix](iceberg)Fixed missing type of iceberg table for timetravel #36047
Conversation
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
run buildall |
TPC-H: Total hot run time: 40021 ms
|
TPC-DS: Total hot run time: 172408 ms
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR approved by at least one committer and no changes requested. |
PR approved by anyone and no changes requested. |
ClickBench: Total hot run time: 30.69 s
|
do we need to add test case? |
@morrySnow There is a related case in the regression test, which was previously in a failed state, but has been muted. After this PR is merged, the case can be run successfully. |
Proposed changes
Related: #34681
34681 supports the time function, but supports the type
HMSExternalTable
.This PR add support for
IcebergExternalTable
type.