Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix](planner) fix unrequired slot bug when join node introduced by #25204 #34923 #35022

Open
wants to merge 3 commits into
base: branch-2.0
Choose a base branch
from

Conversation

nextdreamblue
Copy link
Contributor

@nextdreamblue nextdreamblue commented May 17, 2024

Proposed changes

cherry-pick from #34923

before fix, join node will retain some slots, which are not materialized and unrequired.
join node need remove these slots and not make them be output slots.

Further comments

If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@nextdreamblue
Copy link
Contributor Author

run buildall

@github-actions github-actions bot added area/planner Issues or PRs related to the query planner kind/test labels May 17, 2024
@nextdreamblue nextdreamblue marked this pull request as ready for review May 17, 2024 10:19
@xiaokang
Copy link
Contributor

@nextdreamblue There is still one failed case test_join_with_projection after retry.

Signed-off-by: nextdreamblue <[email protected]>
Signed-off-by: nextdreamblule <[email protected]>
@nextdreamblue
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 49726 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 9cec007c08e0632f54564c00c87cce89e6832643, data reload: false

------ Round 1 ----------------------------------
q1	17845	4350	4369	4350
q2	2071	158	149	149
q3	10271	1940	1973	1940
q4	10266	1300	1329	1300
q5	8378	3893	3904	3893
q6	227	127	125	125
q7	2019	1613	1614	1613
q8	9294	2751	2702	2702
q9	10665	10259	10145	10145
q10	8618	3515	3532	3515
q11	407	245	237	237
q12	462	301	299	299
q13	18319	3949	4050	3949
q14	357	334	324	324
q15	509	462	461	461
q16	679	561	574	561
q17	1130	983	963	963
q18	7258	6804	6840	6804
q19	1784	1651	1630	1630
q20	550	322	279	279
q21	4477	4165	4044	4044
q22	541	443	454	443
Total cold run time: 116127 ms
Total hot run time: 49726 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4348	4297	4271	4271
q2	320	227	226	226
q3	4214	4172	4220	4172
q4	2809	2803	2776	2776
q5	7297	7162	7123	7123
q6	238	123	120	120
q7	3207	2826	2804	2804
q8	4372	4442	4541	4442
q9	16899	16784	17026	16784
q10	4251	4260	4252	4252
q11	759	679	669	669
q12	1037	856	858	856
q13	7019	3755	3755	3755
q14	456	420	439	420
q15	495	461	468	461
q16	743	701	674	674
q17	3855	3882	3834	3834
q18	8760	8725	8776	8725
q19	1738	1736	1664	1664
q20	2392	2140	2158	2140
q21	8490	8562	8459	8459
q22	1076	1037	1018	1018
Total cold run time: 84775 ms
Total hot run time: 79645 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 203826 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 9cec007c08e0632f54564c00c87cce89e6832643, data reload: false

query1	930	417	379	379
query2	6560	2744	2689	2689
query3	6922	208	202	202
query4	20079	18106	17947	17947
query5	19736	6584	6575	6575
query6	291	221	233	221
query7	4180	309	308	308
query8	484	403	422	403
query9	3105	2678	2629	2629
query10	440	295	309	295
query11	11325	10903	10822	10822
query12	123	79	78	78
query13	5589	698	701	698
query14	17931	13445	13663	13445
query15	365	242	250	242
query16	6456	292	267	267
query17	1685	1461	883	883
query18	2298	411	409	409
query19	208	146	150	146
query20	69	81	78	78
query21	186	98	92	92
query22	5106	4979	5020	4979
query23	32381	31748	32041	31748
query24	6919	6508	6516	6508
query25	559	448	417	417
query26	533	171	164	164
query27	1880	292	292	292
query28	6121	2403	2346	2346
query29	3044	2909	2847	2847
query30	244	168	167	167
query31	896	737	761	737
query32	70	64	61	61
query33	396	268	254	254
query34	893	487	465	465
query35	1103	940	887	887
query36	1361	1245	1298	1245
query37	94	61	63	61
query38	3078	2900	2954	2900
query39	1384	1320	1314	1314
query40	212	96	97	96
query41	47	45	45	45
query42	84	86	81	81
query43	680	781	679	679
query44	1142	716	714	714
query45	242	236	234	234
query46	1216	950	959	950
query47	1806	1751	1647	1647
query48	1020	705	710	705
query49	625	373	392	373
query50	886	629	597	597
query51	4725	4662	4719	4662
query52	97	81	82	81
query53	449	327	317	317
query54	2655	2459	2447	2447
query55	89	86	89	86
query56	255	234	203	203
query57	1135	1090	1124	1090
query58	223	208	205	205
query59	4039	4000	3763	3763
query60	221	199	222	199
query61	98	103	96	96
query62	833	496	511	496
query63	501	338	346	338
query64	2464	1547	1502	1502
query65	3631	3557	3592	3557
query66	768	393	374	374
query67	15964	15586	15229	15229
query68	10985	665	652	652
query69	566	361	345	345
query70	1991	1395	1471	1395
query71	427	320	314	314
query72	6607	3553	3462	3462
query73	739	328	315	315
query74	6321	5809	5789	5789
query75	5492	3752	3764	3752
query76	6945	1197	1222	1197
query77	1190	258	254	254
query78	12578	11553	11679	11553
query79	8405	640	646	640
query80	1012	403	406	403
query81	456	233	235	233
query82	893	99	96	96
query83	171	133	129	129
query84	250	75	70	70
query85	891	336	331	331
query86	348	305	284	284
query87	3231	3018	3125	3018
query88	4463	2327	2325	2325
query89	483	303	295	295
query90	1943	211	205	205
query91	175	143	141	141
query92	58	51	55	51
query93	7475	568	587	568
query94	701	214	214	214
query95	1122	1069	1077	1069
query96	658	328	321	321
query97	6474	6389	6380	6380
query98	192	177	178	177
query99	3142	882	948	882
Total cold run time: 317515 ms
Total hot run time: 203826 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.48 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 9cec007c08e0632f54564c00c87cce89e6832643, data reload: false

query1	0.03	0.03	0.02
query2	0.07	0.02	0.02
query3	0.25	0.04	0.04
query4	1.81	0.07	0.07
query5	0.55	0.52	0.52
query6	1.24	0.61	0.62
query7	0.02	0.01	0.01
query8	0.04	0.02	0.02
query9	0.55	0.49	0.49
query10	0.54	0.52	0.54
query11	0.12	0.09	0.08
query12	0.12	0.09	0.09
query13	0.62	0.61	0.61
query14	0.79	0.78	0.80
query15	0.77	0.76	0.76
query16	0.36	0.38	0.39
query17	1.01	1.01	1.01
query18	0.22	0.26	0.25
query19	1.88	1.80	1.80
query20	0.02	0.01	0.01
query21	15.46	0.55	0.54
query22	2.31	2.39	1.80
query23	17.25	0.98	0.88
query24	6.71	0.98	0.73
query25	0.40	0.08	0.06
query26	0.71	0.16	0.14
query27	0.03	0.04	0.04
query28	6.75	0.74	0.72
query29	12.62	2.28	2.19
query30	0.57	0.53	0.53
query31	2.80	0.39	0.37
query32	3.40	0.50	0.50
query33	3.13	3.05	3.07
query34	15.28	4.81	4.80
query35	4.87	4.83	4.80
query36	1.07	1.00	1.03
query37	0.05	0.04	0.05
query38	0.04	0.02	0.02
query39	0.02	0.02	0.02
query40	0.16	0.13	0.14
query41	0.06	0.02	0.01
query42	0.02	0.01	0.02
query43	0.02	0.02	0.01
Total cold run time: 104.74 s
Total hot run time: 30.48 s

@doris-robot
Copy link

Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'

Load test result on commit 9cec007c08e0632f54564c00c87cce89e6832643 with default session variables
Stream load json:         19 seconds loaded 2358488459 Bytes, about 118 MB/s
Stream load orc:          59 seconds loaded 1101869774 Bytes, about 17 MB/s
Stream load parquet:      32 seconds loaded 861443392 Bytes, about 25 MB/s
Insert into select:       21.7 seconds inserted 10000000 Rows, about 460K ops/s

@nextdreamblue
Copy link
Contributor Author

run p0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/planner Issues or PRs related to the query planner kind/test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants