-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix](planner) fix unrequired slot bug when join node introduced by #25204 #34923 #35022
Open
nextdreamblue
wants to merge
3
commits into
apache:branch-2.0
Choose a base branch
from
nextdreamblue:fix_slot_join_node_2.0
base: branch-2.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[fix](planner) fix unrequired slot bug when join node introduced by #25204 #34923 #35022
nextdreamblue
wants to merge
3
commits into
apache:branch-2.0
from
nextdreamblue:fix_slot_join_node_2.0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
run buildall |
github-actions
bot
added
area/planner
Issues or PRs related to the query planner
kind/test
labels
May 17, 2024
@nextdreamblue There is still one failed case test_join_with_projection after retry. |
Signed-off-by: nextdreamblue <[email protected]>
Signed-off-by: nextdreamblue <[email protected]>
Signed-off-by: nextdreamblule <[email protected]>
nextdreamblue
force-pushed
the
fix_slot_join_node_2.0
branch
from
July 31, 2024 09:33
05ce9fb
to
9cec007
Compare
run buildall |
TPC-H: Total hot run time: 49726 ms
|
TPC-DS: Total hot run time: 203826 ms
|
ClickBench: Total hot run time: 30.48 s
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
|
run p0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
cherry-pick from #34923
before fix, join node will retain some slots, which are not materialized and unrequired.
join node need remove these slots and not make them be output slots.
Further comments
If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...