Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Pick](repeat) fix core dump coz output slot'order on repeat node not match with pre repeat exprs #34803

Merged
merged 1 commit into from
May 20, 2024

Conversation

BiteTheDDDDt
Copy link
Contributor

Proposed changes

pick from #32662

Further comments

If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...

…match with pre repeat exprs (apache#32662)

fix core dump coz output slot'order on repeat node not match with pre repeat exprs
@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@BiteTheDDDDt BiteTheDDDDt changed the base branch from master to branch-2.0 May 14, 2024 03:11
@BiteTheDDDDt
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 49641 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit e786cdb7d0949499b96b84b8529a7ae2dbabc951, data reload: false

------ Round 1 ----------------------------------
q1	17812	4425	4385	4385
q2	2030	154	146	146
q3	10542	1935	1917	1917
q4	10362	1263	1333	1263
q5	8452	3877	3905	3877
q6	231	126	128	126
q7	2016	1601	1624	1601
q8	9470	2715	2714	2714
q9	13598	10266	10327	10266
q10	8631	3517	3502	3502
q11	423	245	249	245
q12	477	298	299	298
q13	18354	3943	4049	3943
q14	345	335	317	317
q15	505	455	471	455
q16	662	580	564	564
q17	1123	942	911	911
q18	7336	6930	6815	6815
q19	1710	1585	1487	1487
q20	548	311	311	311
q21	4376	4149	4101	4101
q22	478	397	407	397
Total cold run time: 119481 ms
Total hot run time: 49641 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4474	4512	4331	4331
q2	321	220	224	220
q3	4132	4175	4152	4152
q4	2753	2731	2736	2731
q5	7156	7005	7011	7005
q6	241	123	122	122
q7	3217	2885	2840	2840
q8	4272	4417	4436	4417
q9	16856	16606	16594	16594
q10	4253	4291	4238	4238
q11	758	699	681	681
q12	1035	853	827	827
q13	4950	3783	3733	3733
q14	450	423	426	423
q15	513	457	453	453
q16	733	677	693	677
q17	3716	3815	3763	3763
q18	8880	8693	8672	8672
q19	1728	1660	1705	1660
q20	2376	2087	2079	2079
q21	8384	8511	8335	8335
q22	1027	940	956	940
Total cold run time: 82225 ms
Total hot run time: 78893 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 202378 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit e786cdb7d0949499b96b84b8529a7ae2dbabc951, data reload: false

query1	927	383	369	369
query2	6542	2891	2778	2778
query3	6927	211	207	207
query4	20968	18022	17984	17984
query5	19727	6503	6505	6503
query6	288	213	222	213
query7	4160	305	311	305
query8	268	270	258	258
query9	3142	2708	2635	2635
query10	422	277	303	277
query11	11263	10618	10651	10618
query12	120	82	69	69
query13	5582	692	692	692
query14	18142	13577	13261	13261
query15	376	231	221	221
query16	6453	267	255	255
query17	1757	1462	856	856
query18	2329	406	405	405
query19	215	148	145	145
query20	79	75	78	75
query21	193	96	89	89
query22	5272	5027	5065	5027
query23	32508	31867	31767	31767
query24	7011	6507	6594	6507
query25	506	418	408	408
query26	528	163	157	157
query27	1860	296	297	296
query28	6137	2368	2311	2311
query29	2900	2666	2849	2666
query30	245	162	168	162
query31	911	734	710	710
query32	65	63	61	61
query33	399	250	252	250
query34	852	481	475	475
query35	1109	914	878	878
query36	1314	1080	1055	1055
query37	96	64	58	58
query38	3023	2903	2913	2903
query39	1366	1333	1324	1324
query40	196	86	98	86
query41	39	35	35	35
query42	86	82	86	82
query43	662	804	778	778
query44	1122	712	711	711
query45	243	232	223	223
query46	1224	972	966	966
query47	1843	1649	1791	1649
query48	1017	725	696	696
query49	611	376	366	366
query50	873	599	592	592
query51	4693	4657	4680	4657
query52	86	91	83	83
query53	453	318	317	317
query54	2649	2447	2451	2447
query55	96	80	90	80
query56	236	235	218	218
query57	1251	1060	997	997
query58	221	220	193	193
query59	4274	3674	3872	3674
query60	202	196	202	196
query61	90	80	80	80
query62	825	535	483	483
query63	469	339	339	339
query64	2402	1509	1471	1471
query65	3639	3565	3573	3565
query66	799	373	377	373
query67	16069	15444	16115	15444
query68	8884	649	653	649
query69	570	340	350	340
query70	1594	1469	1290	1290
query71	403	306	320	306
query72	6564	3391	3392	3391
query73	736	347	323	323
query74	6334	5796	5866	5796
query75	5234	3664	3683	3664
query76	5477	1134	1203	1134
query77	913	253	259	253
query78	12316	11590	12121	11590
query79	7182	636	644	636
query80	956	396	396	396
query81	500	237	233	233
query82	1523	96	100	96
query83	183	132	135	132
query84	261	70	68	68
query85	846	291	293	291
query86	315	301	295	295
query87	3255	2993	3043	2993
query88	4792	2345	2344	2344
query89	351	294	280	280
query90	1918	208	206	206
query91	167	144	137	137
query92	59	46	52	46
query93	4593	575	534	534
query94	647	207	201	201
query95	1113	1058	1046	1046
query96	650	336	323	323
query97	6466	6276	6425	6276
query98	182	176	175	175
query99	2864	912	903	903
Total cold run time: 310200 ms
Total hot run time: 202378 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 31.77 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit e786cdb7d0949499b96b84b8529a7ae2dbabc951, data reload: false

query1	0.02	0.03	0.02
query2	0.07	0.03	0.02
query3	0.25	0.05	0.04
query4	1.80	0.07	0.06
query5	0.54	0.53	0.52
query6	1.26	0.68	0.62
query7	0.01	0.02	0.01
query8	0.03	0.03	0.02
query9	0.54	0.47	0.48
query10	0.54	0.52	0.52
query11	0.12	0.08	0.08
query12	0.11	0.08	0.08
query13	0.62	0.62	0.61
query14	0.78	0.81	0.79
query15	0.78	0.76	0.76
query16	0.39	0.36	0.36
query17	1.00	0.97	1.00
query18	0.23	0.25	0.24
query19	1.92	1.87	1.86
query20	0.01	0.01	0.01
query21	15.58	0.54	0.56
query22	2.04	2.05	1.57
query23	17.23	0.94	0.82
query24	5.07	2.20	3.43
query25	0.37	0.10	0.04
query26	0.87	0.16	0.15
query27	0.03	0.03	0.05
query28	4.74	0.81	0.71
query29	12.65	2.31	2.35
query30	0.56	0.56	0.53
query31	2.80	0.38	0.38
query32	3.39	0.50	0.49
query33	3.08	3.08	3.08
query34	15.28	4.78	4.77
query35	4.83	4.87	4.83
query36	1.05	1.02	1.02
query37	0.06	0.04	0.05
query38	0.04	0.01	0.02
query39	0.02	0.02	0.01
query40	0.16	0.14	0.14
query41	0.06	0.02	0.01
query42	0.02	0.01	0.01
query43	0.02	0.02	0.02
Total cold run time: 100.97 s
Total hot run time: 31.77 s

@doris-robot
Copy link

Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'

Load test result on commit e786cdb7d0949499b96b84b8529a7ae2dbabc951 with default session variables
Stream load json:         20 seconds loaded 2358488459 Bytes, about 112 MB/s
Stream load orc:          58 seconds loaded 1101869774 Bytes, about 18 MB/s
Stream load parquet:      31 seconds loaded 861443392 Bytes, about 26 MB/s
Insert into select:       21.0 seconds inserted 10000000 Rows, about 476K ops/s

@xiaokang xiaokang merged commit c62acf5 into apache:branch-2.0 May 20, 2024
27 of 28 checks passed
mongo360 pushed a commit to mongo360/doris that referenced this pull request Aug 16, 2024
…match with pre repeat exprs (apache#32662) (apache#34803)

fix core dump coz output slot'order on repeat node not match with pre repeat exprs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants