Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[branch-2.0](cherry-pick) donot coredump when be can not start (#27928) #34116

Merged
merged 1 commit into from
Apr 25, 2024

Conversation

zxealous
Copy link
Contributor

@zxealous zxealous commented Apr 25, 2024

Proposed changes

Issue Number: close #xxx

cherry-pick #27928 to branch-2.0

Further comments

If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@zxealous
Copy link
Contributor Author

run buildall

Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TPC-H: Total hot run time: 49579 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit c42a6d286b8acb429d07b73f670d147b648c126c, data reload: false

------ Round 1 ----------------------------------
q1	17661	4358	4324	4324
q2	2059	154	139	139
q3	10536	1945	1886	1886
q4	10351	1234	1318	1234
q5	8353	3833	3877	3833
q6	235	125	125	125
q7	2019	1591	1586	1586
q8	9254	2701	2709	2701
q9	10406	10339	10309	10309
q10	8617	3536	3509	3509
q11	417	242	228	228
q12	462	293	296	293
q13	18359	3952	4005	3952
q14	335	328	329	328
q15	507	467	448	448
q16	664	573	570	570
q17	1131	952	961	952
q18	7314	6964	6907	6907
q19	1676	1545	1547	1545
q20	533	311	299	299
q21	4470	4123	4037	4037
q22	482	384	374	374
Total cold run time: 115841 ms
Total hot run time: 49579 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4294	4309	4322	4309
q2	311	219	218	218
q3	4162	4150	4134	4134
q4	2743	2756	2755	2755
q5	7216	7178	7053	7053
q6	238	115	118	115
q7	3244	2912	2862	2862
q8	4365	4472	4478	4472
q9	16884	16719	16764	16719
q10	4191	4266	4281	4266
q11	755	681	674	674
q12	1039	852	858	852
q13	7223	3776	3712	3712
q14	456	428	429	428
q15	496	460	446	446
q16	729	679	664	664
q17	3884	3825	3817	3817
q18	8833	8802	8843	8802
q19	1721	1716	1632	1632
q20	2400	2135	2078	2078
q21	8416	8459	8475	8459
q22	1045	939	955	939
Total cold run time: 84645 ms
Total hot run time: 79406 ms

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.80% (8069/21348)
Line Coverage: 29.46% (65905/223690)
Region Coverage: 28.94% (33925/117235)
Branch Coverage: 24.80% (17414/70216)
Coverage Report: http://coverage.selectdb-in.cc/coverage/c42a6d286b8acb429d07b73f670d147b648c126c_c42a6d286b8acb429d07b73f670d147b648c126c/report/index.html

@doris-robot
Copy link

TPC-DS: Total hot run time: 202570 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit c42a6d286b8acb429d07b73f670d147b648c126c, data reload: false

query1	923	385	381	381
query2	6528	2800	2688	2688
query3	6913	196	198	196
query4	20392	18039	17940	17940
query5	19718	6473	6464	6464
query6	290	219	233	219
query7	4146	306	292	292
query8	249	267	247	247
query9	3166	2741	2682	2682
query10	430	285	303	285
query11	11254	10669	10747	10669
query12	126	72	69	69
query13	5575	707	675	675
query14	18116	13481	13479	13479
query15	372	215	226	215
query16	6467	266	255	255
query17	1744	1450	874	874
query18	2309	417	398	398
query19	207	151	148	148
query20	71	78	73	73
query21	189	97	90	90
query22	5250	5120	5091	5091
query23	32519	31682	31879	31682
query24	6912	6473	6439	6439
query25	506	429	419	419
query26	531	159	158	158
query27	1890	303	296	296
query28	6185	2422	2385	2385
query29	2826	2728	2748	2728
query30	239	162	161	161
query31	881	703	711	703
query32	69	56	57	56
query33	392	254	249	249
query34	845	457	475	457
query35	1126	905	851	851
query36	1243	1109	1281	1109
query37	90	60	58	58
query38	3045	2943	2876	2876
query39	1362	1331	1319	1319
query40	201	93	91	91
query41	39	39	34	34
query42	97	82	88	82
query43	781	685	774	685
query44	1114	724	721	721
query45	239	226	229	226
query46	1231	982	946	946
query47	1918	1792	1707	1707
query48	1001	746	703	703
query49	612	365	367	365
query50	870	736	643	643
query51	4804	4666	4681	4666
query52	86	75	81	75
query53	439	316	309	309
query54	2615	2441	2411	2411
query55	93	78	89	78
query56	221	190	194	190
query57	1219	1096	1100	1096
query58	213	203	204	203
query59	4284	4057	4033	4033
query60	215	198	188	188
query61	87	84	83	83
query62	874	476	445	445
query63	472	333	338	333
query64	2560	1486	1497	1486
query65	3621	3557	3529	3529
query66	826	359	371	359
query67	15855	17325	15100	15100
query68	9607	641	647	641
query69	568	356	339	339
query70	1685	1342	1505	1342
query71	406	293	305	293
query72	6640	3481	3447	3447
query73	716	314	335	314
query74	6325	5856	5871	5856
query75	5309	3664	3677	3664
query76	5992	1176	1230	1176
query77	1016	245	255	245
query78	12485	11668	11589	11589
query79	7681	635	631	631
query80	1173	394	382	382
query81	492	228	230	228
query82	1668	107	97	97
query83	173	136	134	134
query84	258	66	68	66
query85	844	301	291	291
query86	338	344	294	294
query87	3220	3022	3043	3022
query88	4913	2317	2333	2317
query89	385	263	313	263
query90	1968	202	202	202
query91	165	144	134	134
query92	55	52	54	52
query93	5295	534	561	534
query94	694	205	198	198
query95	1092	1054	1032	1032
query96	643	340	320	320
query97	6468	6313	6346	6313
query98	188	176	165	165
query99	2911	826	877	826
Total cold run time: 313056 ms
Total hot run time: 202570 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.69 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit c42a6d286b8acb429d07b73f670d147b648c126c, data reload: false

query1	0.03	0.02	0.02
query2	0.07	0.03	0.02
query3	0.25	0.04	0.06
query4	1.81	0.07	0.07
query5	0.53	0.52	0.51
query6	1.25	0.61	0.61
query7	0.01	0.00	0.01
query8	0.03	0.02	0.02
query9	0.52	0.49	0.48
query10	0.55	0.54	0.56
query11	0.12	0.08	0.09
query12	0.12	0.09	0.09
query13	0.62	0.62	0.62
query14	0.78	0.80	0.80
query15	0.77	0.76	0.75
query16	0.36	0.36	0.37
query17	1.00	1.00	1.01
query18	0.23	0.27	0.26
query19	1.91	1.77	1.90
query20	0.02	0.01	0.01
query21	15.54	0.56	0.55
query22	2.04	2.67	1.68
query23	17.61	1.08	0.83
query24	4.46	0.95	1.23
query25	0.38	0.05	0.05
query26	0.60	0.14	0.15
query27	0.05	0.04	0.04
query28	8.52	0.79	0.72
query29	12.71	2.38	2.36
query30	0.59	0.54	0.53
query31	2.80	0.38	0.38
query32	3.37	0.49	0.48
query33	3.07	3.06	3.04
query34	15.25	4.81	4.79
query35	4.85	4.86	4.84
query36	1.07	1.01	1.02
query37	0.06	0.04	0.05
query38	0.04	0.02	0.02
query39	0.02	0.02	0.01
query40	0.16	0.14	0.15
query41	0.06	0.02	0.01
query42	0.02	0.02	0.01
query43	0.02	0.02	0.02
Total cold run time: 104.27 s
Total hot run time: 30.69 s

@doris-robot
Copy link

Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'

Load test result on commit c42a6d286b8acb429d07b73f670d147b648c126c with default session variables
Stream load json:         21 seconds loaded 2358488459 Bytes, about 107 MB/s
Stream load orc:          59 seconds loaded 1101869774 Bytes, about 17 MB/s
Stream load parquet:      31 seconds loaded 861443392 Bytes, about 26 MB/s
Insert into select:       21.3 seconds inserted 10000000 Rows, about 469K ops/s

Copy link
Contributor

@cambyzju cambyzju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Apr 25, 2024
Copy link
Contributor

PR approved by at least one committer and no changes requested.

Copy link
Contributor

PR approved by anyone and no changes requested.

@dataroaring dataroaring merged commit 23bab29 into apache:branch-2.0 Apr 25, 2024
24 of 29 checks passed
@zxealous zxealous deleted the not-core branch April 28, 2024 09:29
mongo360 pushed a commit to mongo360/doris that referenced this pull request Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants