Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature](Nereids) support set and use statement syntax only #33979

Merged
merged 1 commit into from
Apr 25, 2024
Merged

[feature](Nereids) support set and use statement syntax only #33979

merged 1 commit into from
Apr 25, 2024

Conversation

morrySnow
Copy link
Contributor

@morrySnow morrySnow commented Apr 22, 2024 •
edited
Loading

This PR:

  1. add a new Command type: UnsupportedCommand to handle the statement only support parse but could not execute.
  2. support syntax about set and use
  3. add keyword VAULT to follow legacy planner

TODO

  1. support all statment syntax in Nereids

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@morrySnow
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 38464 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit af0287f38b95f8c1ea3581ba5a58bdf7d454545d, data reload: false

------ Round 1 ----------------------------------
q1	17614	4332	4232	4232
q2	2013	189	180	180
q3	10458	1154	1151	1151
q4	10202	772	813	772
q5	7497	2684	2642	2642
q6	212	131	133	131
q7	988	600	605	600
q8	9230	2049	2013	2013
q9	8470	6565	6523	6523
q10	8572	3508	3534	3508
q11	439	234	225	225
q12	433	219	220	219
q13	18540	2923	2930	2923
q14	273	227	237	227
q15	522	479	482	479
q16	526	380	380	380
q17	959	711	702	702
q18	7252	6975	6723	6723
q19	6306	1542	1491	1491
q20	999	318	312	312
q21	3534	2726	2781	2726
q22	355	305	309	305
Total cold run time: 115394 ms
Total hot run time: 38464 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4292	4220	4223	4220
q2	506	264	262	262
q3	2964	2712	2770	2712
q4	1883	1618	1526	1526
q5	5312	5355	5270	5270
q6	207	122	125	122
q7	2209	1896	1864	1864
q8	3205	3310	3318	3310
q9	8530	8566	8724	8566
q10	4092	3930	3879	3879
q11	584	480	498	480
q12	835	642	639	639
q13	16257	3200	3234	3200
q14	312	286	287	286
q15	533	489	476	476
q16	481	439	436	436
q17	1817	1531	1490	1490
q18	7905	8059	7986	7986
q19	1651	1560	1553	1553
q20	2053	1861	1834	1834
q21	6561	4929	4902	4902
q22	564	491	480	480
Total cold run time: 72753 ms
Total hot run time: 55493 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 185263 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit af0287f38b95f8c1ea3581ba5a58bdf7d454545d, data reload: false

query1	914	370	367	367
query2	6182	2669	2294	2294
query3	6646	213	212	212
query4	23932	21294	21360	21294
query5	4149	410	413	410
query6	271	208	174	174
query7	4583	290	295	290
query8	249	193	187	187
query9	8472	2277	2242	2242
query10	421	248	255	248
query11	14792	14192	14174	14174
query12	135	92	88	88
query13	1632	364	369	364
query14	9730	7969	7471	7471
query15	246	182	182	182
query16	8240	272	267	267
query17	1977	590	558	558
query18	2100	281	272	272
query19	344	154	154	154
query20	97	88	86	86
query21	206	126	124	124
query22	5005	4812	4787	4787
query23	33780	33320	33477	33320
query24	7777	3149	3175	3149
query25	615	406	464	406
query26	701	169	157	157
query27	2238	354	365	354
query28	5673	2044	2043	2043
query29	846	628	654	628
query30	270	186	179	179
query31	997	759	794	759
query32	104	61	65	61
query33	534	256	259	256
query34	1320	499	504	499
query35	836	740	728	728
query36	1065	962	923	923
query37	114	78	71	71
query38	3637	3471	3339	3339
query39	1609	1556	1565	1556
query40	170	135	124	124
query41	45	45	43	43
query42	105	93	99	93
query43	570	536	542	536
query44	1100	730	742	730
query45	297	279	263	263
query46	1085	745	759	745
query47	2002	1929	1957	1929
query48	389	303	333	303
query49	838	389	394	389
query50	779	392	402	392
query51	6830	6714	6733	6714
query52	98	93	86	86
query53	337	279	280	279
query54	256	232	226	226
query55	76	70	68	68
query56	234	224	236	224
query57	1218	1109	1144	1109
query58	221	193	187	187
query59	3525	3075	3101	3075
query60	253	220	226	220
query61	87	85	88	85
query62	574	441	436	436
query63	312	274	276	274
query64	4758	3889	4045	3889
query65	3067	3047	3044	3044
query66	753	325	334	325
query67	15309	14977	14748	14748
query68	6672	533	522	522
query69	542	296	307	296
query70	1271	1241	1177	1177
query71	1432	1260	1264	1260
query72	6377	2646	2444	2444
query73	731	320	320	320
query74	6912	6359	6535	6359
query75	3949	2671	2662	2662
query76	4416	1032	987	987
query77	638	259	261	259
query78	11033	10216	10169	10169
query79	6592	515	518	515
query80	1164	432	422	422
query81	521	246	240	240
query82	879	97	97	97
query83	208	170	165	165
query84	268	80	82	80
query85	1249	311	256	256
query86	447	307	300	300
query87	3507	3233	3398	3233
query88	4936	2396	2399	2396
query89	472	367	360	360
query90	1839	180	176	176
query91	123	93	93	93
query92	57	46	45	45
query93	5774	496	488	488
query94	1092	180	174	174
query95	382	297	295	295
query96	615	265	259	259
query97	3115	2937	2948	2937
query98	231	213	210	210
query99	1212	858	896	858
Total cold run time: 286383 ms
Total hot run time: 185263 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.19 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit af0287f38b95f8c1ea3581ba5a58bdf7d454545d, data reload: false

query1	0.04	0.03	0.03
query2	0.08	0.04	0.04
query3	0.23	0.06	0.07
query4	1.65	0.10	0.09
query5	0.51	0.50	0.51
query6	1.47	0.72	0.72
query7	0.02	0.02	0.01
query8	0.05	0.03	0.04
query9	0.55	0.49	0.49
query10	0.56	0.55	0.53
query11	0.15	0.11	0.12
query12	0.14	0.12	0.12
query13	0.59	0.58	0.57
query14	0.76	0.78	0.80
query15	0.82	0.81	0.81
query16	0.34	0.35	0.35
query17	0.98	0.94	0.96
query18	0.21	0.24	0.22
query19	1.74	1.67	1.65
query20	0.02	0.01	0.01
query21	15.42	0.65	0.64
query22	4.51	7.25	1.86
query23	18.24	1.36	1.27
query24	2.04	0.21	0.19
query25	0.14	0.08	0.09
query26	0.27	0.17	0.16
query27	0.08	0.08	0.08
query28	13.36	1.02	0.99
query29	12.61	3.31	3.26
query30	0.26	0.08	0.06
query31	2.88	0.37	0.38
query32	3.24	0.46	0.46
query33	2.83	2.84	2.83
query34	16.93	4.38	4.39
query35	4.50	4.45	4.47
query36	0.66	0.45	0.46
query37	0.18	0.16	0.15
query38	0.15	0.15	0.14
query39	0.04	0.04	0.04
query40	0.16	0.15	0.14
query41	0.09	0.04	0.05
query42	0.06	0.05	0.05
query43	0.04	0.04	0.04
Total cold run time: 109.6 s
Total hot run time: 30.19 s

@morrySnow
Copy link
Contributor Author

run buildall

@morrySnow
Copy link
Contributor Author

run buildall

@morrySnow
[feature](Nereids) support set and use statement syntax only
a5d31eb 
1. add a new Command type: UnsupportedCommand to handle the statement
   only support parse but could not execute.
2. support syntax about set and use
@morrySnow
Copy link
Contributor Author

run buildall

@morrySnow
Copy link
Contributor Author

run p0

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Apr 24, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@morrySnow morrySnow merged commit 65fb7d4 into apache:master Apr 25, 2024
25 of 28 checks passed
@morrySnow morrySnow deleted the support_set_syntax_only branch April 30, 2024 06:22
@morrySnow morrySnow mentioned this pull request May 6, 2024
Merged
yiguolei pushed a commit that referenced this pull request May 6, 2024
@morrySnow
[feature](Nereids) support set and use statement syntax only (#33979) (…
7ae5de3 
…#34409)

pick from master #33979
commit id 65fb7d4

This PR:
1. add a new Command type: UnsupportedCommand to handle the statement only support parse but could not execute.
2. support syntax about set and use
3. add keyword VAULT to follow legacy planner

TODO
1. support all statment syntax in Nereids
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@924060929 924060929 924060929 approved these changes

@starocean999 starocean999 starocean999 approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@morrySnow @doris-robot @924060929 @starocean999 @yiguolei