Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvementation](join) empty_block shall be set true when build blo… #33977

Merged
merged 3 commits into from
Apr 25, 2024

Conversation

BiteTheDDDDt
Copy link
Contributor

…ck only one row (#33721)

empty_block shall be set true when build block only one row

Proposed changes

Further comments

If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...

…ck only one row (apache#33721)

empty_block shall be set true when build block only one row
@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@BiteTheDDDDt
Copy link
Contributor Author

run buildall

Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@BiteTheDDDDt
Copy link
Contributor Author

run builall

Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TPC-H: Total hot run time: 38566 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 4e55ff6e854ebc3d1a53302add03cb56c8c821e7, data reload: false

------ Round 1 ----------------------------------
q1	6833	4534	4268	4268
q2	646	185	182	182
q3	1581	1125	1201	1125
q4	8031	775	825	775
q5	2685	2704	2877	2704
q6	243	141	138	138
q7	1034	594	570	570
q8	1963	2051	2043	2043
q9	6684	6639	6566	6566
q10	3661	3554	3533	3533
q11	343	241	225	225
q12	375	222	213	213
q13	16792	2947	2974	2947
q14	271	230	241	230
q15	523	489	478	478
q16	503	385	375	375
q17	964	720	721	720
q18	7171	6844	6646	6646
q19	1560	1544	1475	1475
q20	505	307	305	305
q21	3530	2847	2738	2738
q22	365	311	310	310
Total cold run time: 66263 ms
Total hot run time: 38566 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4279	4274	4233	4233
q2	372	270	259	259
q3	2962	2772	2770	2770
q4	1857	1606	1570	1570
q5	5371	5376	5334	5334
q6	222	123	124	123
q7	2266	1877	1883	1877
q8	3236	3366	3372	3366
q9	8582	8552	8618	8552
q10	3883	3708	3744	3708
q11	566	485	480	480
q12	732	569	588	569
q13	15484	2938	2935	2935
q14	290	269	282	269
q15	518	480	470	470
q16	469	410	422	410
q17	1781	1490	1452	1452
q18	7935	8018	8010	8010
q19	1964	1647	1578	1578
q20	2073	1853	1829	1829
q21	5108	4952	4982	4952
q22	561	493	488	488
Total cold run time: 70511 ms
Total hot run time: 55234 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 185185 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 4e55ff6e854ebc3d1a53302add03cb56c8c821e7, data reload: false

query1	889	388	375	375
query2	6498	2579	2402	2402
query3	6653	212	220	212
query4	23765	21279	21240	21240
query5	4152	425	411	411
query6	273	190	180	180
query7	4591	297	285	285
query8	245	190	185	185
query9	8424	2283	2243	2243
query10	427	243	260	243
query11	14751	14225	14120	14120
query12	139	84	86	84
query13	1648	366	363	363
query14	9457	7723	7887	7723
query15	277	187	180	180
query16	8134	274	271	271
query17	1903	596	540	540
query18	2012	281	263	263
query19	323	152	147	147
query20	89	85	84	84
query21	199	122	126	122
query22	5066	4852	4864	4852
query23	33573	32904	32884	32884
query24	9728	3066	3014	3014
query25	589	380	383	380
query26	723	151	155	151
query27	2366	362	365	362
query28	5867	2001	2023	2001
query29	884	606	598	598
query30	281	185	179	179
query31	1013	731	771	731
query32	92	54	61	54
query33	609	252	242	242
query34	906	479	477	477
query35	790	737	699	699
query36	1083	942	913	913
query37	113	74	69	69
query38	3420	3342	3328	3328
query39	1633	1589	1584	1584
query40	180	127	128	127
query41	45	42	44	42
query42	110	98	100	98
query43	569	538	538	538
query44	1101	789	749	749
query45	300	282	275	275
query46	1106	738	727	727
query47	2094	1974	1961	1961
query48	378	296	298	296
query49	843	427	390	390
query50	777	400	415	400
query51	6856	6726	6839	6726
query52	102	90	93	90
query53	354	276	276	276
query54	288	233	246	233
query55	87	76	76	76
query56	274	246	231	231
query57	1282	1206	1215	1206
query58	223	201	205	201
query59	3462	3520	3175	3175
query60	266	235	245	235
query61	105	106	100	100
query62	596	430	471	430
query63	298	274	273	273
query64	4639	3853	3762	3762
query65	3062	3055	3017	3017
query66	734	327	324	324
query67	15552	14975	15190	14975
query68	6592	529	520	520
query69	528	296	294	294
query70	1281	1206	1167	1167
query71	1430	1275	1267	1267
query72	6587	2602	2487	2487
query73	734	318	316	316
query74	6816	6443	6386	6386
query75	3512	2641	2595	2595
query76	3787	1022	957	957
query77	614	257	258	257
query78	10921	10146	10133	10133
query79	7837	504	508	504
query80	1415	436	429	429
query81	505	244	245	244
query82	1148	93	88	88
query83	197	160	162	160
query84	264	87	82	82
query85	1197	279	272	272
query86	452	310	306	306
query87	3526	3351	3339	3339
query88	5017	2391	2378	2378
query89	489	370	363	363
query90	1915	178	176	176
query91	123	94	94	94
query92	56	46	45	45
query93	6615	485	491	485
query94	1068	180	179	179
query95	389	292	285	285
query96	612	266	258	258
query97	3087	2931	2933	2931
query98	233	222	215	215
query99	1239	869	849	849
Total cold run time: 289454 ms
Total hot run time: 185185 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.1 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 4e55ff6e854ebc3d1a53302add03cb56c8c821e7, data reload: false

query1	0.04	0.03	0.03
query2	0.08	0.04	0.04
query3	0.23	0.05	0.05
query4	1.68	0.07	0.07
query5	0.47	0.49	0.51
query6	1.43	0.72	0.72
query7	0.02	0.01	0.01
query8	0.05	0.04	0.04
query9	0.55	0.51	0.49
query10	0.54	0.56	0.56
query11	0.15	0.11	0.11
query12	0.14	0.11	0.12
query13	0.59	0.59	0.58
query14	0.77	0.76	0.78
query15	0.82	0.81	0.80
query16	0.35	0.37	0.38
query17	0.97	0.94	0.97
query18	0.20	0.25	0.23
query19	1.72	1.68	1.66
query20	0.01	0.00	0.01
query21	15.40	0.65	0.65
query22	4.26	7.86	1.60
query23	18.34	1.38	1.29
query24	1.88	0.25	0.23
query25	0.16	0.09	0.09
query26	0.27	0.17	0.16
query27	0.08	0.08	0.09
query28	13.26	1.00	0.99
query29	12.60	3.32	3.26
query30	0.25	0.09	0.06
query31	2.82	0.38	0.38
query32	3.27	0.46	0.46
query33	2.83	2.85	2.83
query34	17.05	4.40	4.49
query35	4.50	4.55	4.51
query36	0.66	0.46	0.47
query37	0.19	0.15	0.15
query38	0.15	0.14	0.14
query39	0.05	0.04	0.04
query40	0.17	0.17	0.14
query41	0.09	0.04	0.05
query42	0.06	0.05	0.05
query43	0.04	0.04	0.03
Total cold run time: 109.19 s
Total hot run time: 30.1 s

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 35.37% (8916/25209)
Line Coverage: 27.10% (73326/270591)
Region Coverage: 26.23% (37872/144362)
Branch Coverage: 23.05% (19289/83698)
Coverage Report: http://coverage.selectdb-in.cc/coverage/4e55ff6e854ebc3d1a53302add03cb56c8c821e7_4e55ff6e854ebc3d1a53302add03cb56c8c821e7/report/index.html

@BiteTheDDDDt
Copy link
Contributor Author

run buildall

Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 35.23% (8916/25305)
Line Coverage: 26.99% (73334/271713)
Region Coverage: 26.16% (37879/144800)
Branch Coverage: 22.97% (19284/83970)
Coverage Report: http://coverage.selectdb-in.cc/coverage/7858f25afc2f3b90d4e1a95236c90a1dfbc31d0a_7858f25afc2f3b90d4e1a95236c90a1dfbc31d0a/report/index.html

Copy link
Contributor

@HappenLee HappenLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Apr 23, 2024
Copy link
Contributor

PR approved by at least one committer and no changes requested.

Copy link
Contributor

PR approved by anyone and no changes requested.

@BiteTheDDDDt BiteTheDDDDt merged commit 4073aba into apache:master Apr 25, 2024
24 of 28 checks passed
yiguolei pushed a commit that referenced this pull request Apr 25, 2024
#33977)

empty_block shall be set true when build block only one row
yiguolei pushed a commit that referenced this pull request Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.1.0-conflict approved Indicates a PR has been approved by one committer. reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants