[Enhancement](external catalog) Added status reset when jdbc name mapping is abnormal #33971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
|
run buildall |
TPC-H: Total hot run time: 38537 ms |
TPC-DS: Total hot run time: 185126 ms |
ClickBench: Total hot run time: 30 s |
morningman
reviewed
Apr 23, 2024
| loadColumnNamesIfNeeded(localDbName, localTableName); | ||
| } | ||
| return localColumnToRemoteColumn.get(remoteDbName).get(remoteTableName); | ||
| if (columnMap.isEmpty()) { | ||
| LOG.error("No remote column found for localTableName: {}. Please refresh this catalog.", localTableName); |
There was a problem hiding this comment.
Suggested change
| LOG.error("No remote column found for localTableName: {}. Please refresh this catalog.", localTableName); | |
| LOG.warn("No remote column found for localTableName: {}. Please refresh this catalog.", localTableName); |
fe/fe-core/src/main/java/org/apache/doris/datasource/mapping/IdentifierMapping.java
Show resolved
Hide resolved
| loadDatabaseNames(); | ||
| } catch (Exception e) { | ||
| dbNamesLoaded.set(false); // Reset on failure | ||
| LOG.error("Error loading database names", e); |
There was a problem hiding this comment.
Suggested change
| LOG.error("Error loading database names", e); | |
| LOG.warn("Error loading database names", e); |
zy-kkk
force-pushed
the
jdbc_mapping_opt
branch
from
206cf00
to
56850a6
Compare
|
run buildall |
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
the
approved
|
PR approved by anyone and no changes requested. |
|
run cloud_p1 |
|
run buildall |
TPC-H: Total hot run time: 41040 ms |
TPC-DS: Total hot run time: 186192 ms |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue Number: close #xxx
This PR introduces several important improvements aimed at enhancing the robustness, maintainability, and error handling efficiency of database connectivity and data retrieval processes. Here are the main optimization points:
Code Abstraction and Reuse:
getRequiredMappingmethod to centralize the common logic for retrieving database, table, and column names. This change reduces repetitive code across multiple functions, making the overall code structure more compact and consistent.Unified Error Handling:
getRequiredMappingmethod, missing mappings are handled uniformly. If a mapping is not found, the corresponding loading function is automatically triggered, and an exception is thrown if data remains missing. This approach simplifies error management and enhances code readability and maintainability.Enhanced Exception Safety:
Improved Robustness:
ConcurrentHashMapandAtomicBooleanto ensure data consistency and thread safety in a multi-threaded environment. Optimized data checks and exception handling logic reduce potential issues caused by concurrent modifications.Improved Logging:
Further comments
If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...