Revert "[Improvementation](join) empty_block shall be set true when b… #33916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uild block only one row (apache#33721)" This reverts commit a93c865.
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
|
run buildall |
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -62,17 +62,15 @@ void ColumnWithTypeAndName::dump_structure(std::ostream& out) const { | |||
| out << name; | |||
| } | |||
|
|
|||
| if (type) { | |||
| if (type) | |||
There was a problem hiding this comment.
warning: statement should be inside braces [readability-braces-around-statements]
Suggested change
| if (type) | |
| if (type) { |
be/src/vec/core/column_with_type_and_name.cpp:66:
- else
+ } else
Comment on lines
+67
to
68
| else | ||
| out << " nullptr"; |
There was a problem hiding this comment.
warning: statement should be inside braces [readability-braces-around-statements]
Suggested change
| else | |
| out << " nullptr"; | |
| else { | |
| out << " nullptr"; | |
| } |
| if (column) { | ||
| out << ' ' << column->dump_structure() << "(use_count=" << column->use_count() << ')'; | ||
| } else { | ||
| if (column) |
There was a problem hiding this comment.
warning: statement should be inside braces [readability-braces-around-statements]
Suggested change
| if (column) | |
| if (column) { |
be/src/vec/core/column_with_type_and_name.cpp:71:
- else
+ } else
Comment on lines
+72
to
73
| else | ||
| out << " nullptr"; |
There was a problem hiding this comment.
warning: statement should be inside braces [readability-braces-around-statements]
Suggested change
| else | |
| out << " nullptr"; | |
| else { | |
| out << " nullptr"; | |
| } |
yiguolei
approved these changes
Apr 19, 2024
TPC-H: Total hot run time: 38669 ms |
|
TeamCity be ut coverage result: |
TPC-DS: Total hot run time: 184617 ms |
ClickBench: Total hot run time: 31.26 s |
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
BiteTheDDDDt
added a commit
to BiteTheDDDDt/incubator-doris
that referenced
this pull request
Apr 28, 2024
…uild block only one row (apache#33721)" (apache#33916) This reverts commit a93c865.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…uild block only one row (#33721)"
This reverts commit a93c865.
Proposed changes
Issue Number: close #xxx
Further comments
If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...