-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix](row-count-cache) use cached row count for show #33911
Conversation
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
run buildall |
TPC-H: Total hot run time: 39001 ms
|
TPC-DS: Total hot run time: 184073 ms
|
ClickBench: Total hot run time: 30.27 s
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
|
PR approved by at least one committer and no changes requested. |
PR approved by anyone and no changes requested. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Proposed changes
Followup #33449
Some operation, like
show tables status
may traverse all tables and call table's getRowCount() method.This method may trigger the row count cache refresh async, and may take all executor thread and block other
query requests.
This PR change the logic, for some
show
request likeshow table status
, use a new methodgetCachedRowCount()
.This method will get row count from cache if present, and will not trigger cache refresh if cache miss.
Further comments
If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...