[Performance](Variant) Improve load performance for variant type #33890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. remove phmap for padding rows 2. add `SimpleFieldVisitorToScarlarType` for short circuit type deducint 3. correct type coercion for conflict types bettween integers In clickbench data, load performance: 12m36.799s -> 8m30.870s about 32.5% In variant_p2/performance.groovy: 3min44s20 -> 2min21s07 about 36.7%
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
|
run buildall |
|
TeamCity be ut coverage result: |
TPC-H: Total hot run time: 38846 ms |
|
PR approved by anyone and no changes requested. |
|
run buildall |
TPC-H: Total hot run time: 38587 ms |
|
TeamCity be ut coverage result: |
TPC-DS: Total hot run time: 185295 ms |
ClickBench: Total hot run time: 30.4 s |
|
run buildall |
|
TeamCity be ut coverage result: |
TPC-H: Total hot run time: 38735 ms |
TPC-DS: Total hot run time: 185387 ms |
ClickBench: Total hot run time: 30.78 s |
|
run buildall |
TPC-H: Total hot run time: 38584 ms |
|
TeamCity be ut coverage result: |
TPC-DS: Total hot run time: 185062 ms |
ClickBench: Total hot run time: 30.09 s |
|
run p0 |
xiaokang
reviewed
May 5, 2024
xiaokang
reviewed
May 5, 2024
|
run buildall |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -207,8 +266,10 @@ class FieldVisitorToScalarType : public StaticVisitor<size_t> { | |||
| type_indexes.insert(TypeId<NearestFieldType<T>>::value); | |||
| return 0; | |||
| } | |||
| void get_scalar_type(DataTypePtr* type) const { | |||
| get_least_supertype<LeastSupertypeOnError::Jsonb>(type_indexes, type); | |||
| void get_scalar_type(TypeIndex* type) const { | |||
There was a problem hiding this comment.
warning: method 'get_scalar_type' can be made static [readability-convert-member-functions-to-static]
Suggested change
| void get_scalar_type(TypeIndex* type) const { | |
| static void get_scalar_type(TypeIndex* type) { |
|
TeamCity be ut coverage result: |
TPC-DS: Total hot run time: 186136 ms |
…he same) and a quick check to match the next expected field, instead of searching the hash table.
|
run buildall |
|
TeamCity be ut coverage result: |
TPC-DS: Total hot run time: 186465 ms |
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
TeamCity be ut coverage result: |
xiaokang
reviewed
May 11, 2024
xiaokang
approved these changes
May 11, 2024
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
ByteYue
pushed a commit
to ByteYue/doris
that referenced
this pull request
May 15, 2024
…che#33890) 1. remove phmap for padding rows 2. add SimpleFieldVisitorToScarlarType for short circuit type deducing 3. correct type coercion for conflict types bettween integers 4. improve nullable column performance 5. remove shared_ptr dependancy for DataType use TypeIndex instead 6. Optimization by caching the order of fields (which is almost always the same) and a quick check to match the next expected field, instead of searching the hash table. benchmark: In clickbench data, load performance: 12m36.799s ->7m10.934s about 43% latency reduce In variant_p2/performance.groovy: 3min44s20 -> 1min15s80 about 66% latency reducy
yiguolei
pushed a commit
that referenced
this pull request
May 18, 2024
) 1. remove phmap for padding rows 2. add SimpleFieldVisitorToScarlarType for short circuit type deducing 3. correct type coercion for conflict types bettween integers 4. improve nullable column performance 5. remove shared_ptr dependancy for DataType use TypeIndex instead 6. Optimization by caching the order of fields (which is almost always the same) and a quick check to match the next expected field, instead of searching the hash table. benchmark: In clickbench data, load performance: 12m36.799s ->7m10.934s about 43% latency reduce In variant_p2/performance.groovy: 3min44s20 -> 1min15s80 about 66% latency reducy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SimpleFieldVisitorToScarlarTypefor short circuit type deducingand a quick check to match the next expected field, instead of searching the hash table.
In clickbench data, load performance:
12m36.799s ->7m10.934s about 43% latency reduce
In variant_p2/performance.groovy:
3min44s20 -> 1min15s80 about 66% latency reducy
Proposed changes
Issue Number: close #xxx
Further comments
If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...