[Enhencement](Nereids) rules to optimize length function with aggregate function #33837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
|
run buildall |
|
it is better to do this transformation: It covers more cases. |
morrySnow
reviewed
Apr 18, 2024
| if (not.getArgument(0) instanceof EqualPredicate) { | ||
| EqualPredicate equalPredicate = (EqualPredicate) not.getArgument(0); | ||
| if (equalPredicate.getArgument(0).getDataType().isStringType() | ||
| && equalPredicate.getArgument(1).equals(new StringLiteral(""))) { |
There was a problem hiding this comment.
how about varchar or char literal? should check StringLikeLiteral and getStringValue from it
| EqualPredicate equalPredicate = (EqualPredicate) not.getArgument(0); | ||
| if (equalPredicate.getArgument(0).getDataType().isStringType() | ||
| && equalPredicate.getArgument(1).equals(new StringLiteral(""))) { | ||
| expr = new GreaterThan(new Length(equalPredicate.getArgument(0)), new IntegerLiteral(0), false); |
There was a problem hiding this comment.
use two arg ctor is enough
|
run buildall |
have changed and add more cases abort that |
|
run buildall |
LiBinfeng-01
force-pushed
the
add_string_to_length
branch
2 times, most recently
from
ecd5ef2
to
ae32abc
Compare
|
run buildall |
LiBinfeng-01
changed the title
TPC-H: Total hot run time: 38213 ms |
TPC-DS: Total hot run time: 185541 ms |
englefly
previously approved these changes
Apr 22, 2024
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
approved
|
PR approved by anyone and no changes requested. |
|
run buildall |
github-actions
bot
removed
the
approved
TPC-H: Total hot run time: 38516 ms |
TPC-DS: Total hot run time: 185231 ms |
ClickBench: Total hot run time: 30.9 s |
|
run buildall |
|
run external |
LiBinfeng-01
force-pushed
the
add_string_to_length
branch
from
ea828ba
to
d47e3c1
Compare
|
run buildall |
ClickBench: Total hot run time: 29.41 s |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add two rules in order to optimize plan in clickbench q27
example：
select t1.string from t1 where t1.string <> ""; ==>select t1.string from t1 where length(t1.string) > 0;
select avg(length(t1.string)) from t1;
from agg(length) to agg->project(length)