Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix](planner) retain groupingSlotIds as materialized for aggregate #33064

Merged
merged 1 commit into from
Mar 30, 2024

Conversation

nextdreamblue
Copy link
Contributor

@nextdreamblue nextdreamblue commented Mar 30, 2024

Proposed changes

cherry-pick from #33060

Further comments

If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@nextdreamblue
Copy link
Contributor Author

run buildall

@github-actions github-actions bot added area/planner Issues or PRs related to the query planner kind/test labels Mar 30, 2024
@doris-robot
Copy link

TPC-H: Total hot run time: 49632 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 0c714a7e4b28b9398fb7b8c0aee92055e0eb5841, data reload: false

------ Round 1 ----------------------------------
q1	17736	4357	4465	4357
q2	2038	149	142	142
q3	10354	1957	1919	1919
q4	10358	1249	1275	1249
q5	8406	3941	3910	3910
q6	226	123	122	122
q7	2030	1610	1563	1563
q8	9378	2705	2713	2705
q9	10563	10513	10426	10426
q10	8646	3498	3466	3466
q11	425	235	253	235
q12	461	299	301	299
q13	18343	3935	3985	3935
q14	345	318	329	318
q15	514	463	451	451
q16	691	587	580	580
q17	1112	939	980	939
q18	7319	6921	6782	6782
q19	1679	1565	1518	1518
q20	533	295	306	295
q21	4468	4106	4037	4037
q22	492	384	387	384
Total cold run time: 116117 ms
Total hot run time: 49632 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4287	4251	4266	4251
q2	316	217	229	217
q3	4154	4114	4120	4114
q4	2739	2748	2734	2734
q5	7269	7157	7170	7157
q6	230	118	118	118
q7	3233	2858	2826	2826
q8	4343	4468	4465	4465
q9	17002	16867	16818	16818
q10	4231	4227	4255	4227
q11	734	664	691	664
q12	1022	857	854	854
q13	7107	3757	3751	3751
q14	444	421	424	421
q15	501	454	460	454
q16	773	698	702	698
q17	3891	3845	3800	3800
q18	8788	8651	8804	8651
q19	1702	1683	1657	1657
q20	2364	2130	2093	2093
q21	8580	8471	8520	8471
q22	1054	970	1000	970
Total cold run time: 84764 ms
Total hot run time: 79411 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 201579 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 0c714a7e4b28b9398fb7b8c0aee92055e0eb5841, data reload: false

query1	915	395	380	380
query2	6527	2255	2057	2057
query3	8489	206	210	206
query4	21925	18735	18702	18702
query5	22457	6601	6574	6574
query6	1237	265	251	251
query7	6252	304	307	304
query8	276	267	253	253
query9	3116	2688	2622	2622
query10	454	288	302	288
query11	11401	10709	10704	10704
query12	116	71	70	70
query13	5604	645	647	645
query14	18849	13680	13244	13244
query15	354	227	228	227
query16	6409	277	252	252
query17	1313	1543	861	861
query18	2268	403	394	394
query19	209	142	144	142
query20	79	76	73	73
query21	184	92	94	92
query22	5336	4954	4897	4897
query23	32593	32204	31824	31824
query24	6711	6575	6453	6453
query25	504	417	407	407
query26	495	158	156	156
query27	1627	298	290	290
query28	6029	2264	2221	2221
query29	2863	2774	2832	2774
query30	243	160	157	157
query31	915	773	749	749
query32	67	58	58	58
query33	395	266	237	237
query34	842	466	473	466
query35	1114	851	934	851
query36	1667	1165	1176	1165
query37	89	61	61	61
query38	3125	2944	2875	2875
query39	1354	1313	1324	1313
query40	205	96	88	88
query41	41	33	32	32
query42	86	87	94	87
query43	637	656	579	579
query44	1143	713	719	713
query45	236	227	222	222
query46	1233	954	951	951
query47	1887	1660	1651	1651
query48	992	675	672	672
query49	613	354	364	354
query50	854	632	640	632
query51	4741	4618	4645	4618
query52	91	71	76	71
query53	440	316	310	310
query54	2601	2462	2432	2432
query55	83	79	78	78
query56	215	206	203	203
query57	1181	1069	1037	1037
query58	220	198	200	198
query59	3459	3123	3362	3123
query60	209	196	192	192
query61	86	84	86	84
query62	865	477	595	477
query63	470	330	329	329
query64	2314	1465	1460	1460
query65	3618	3554	3539	3539
query66	784	365	364	364
query67	17974	15356	15807	15356
query68	6563	654	681	654
query69	563	330	350	330
query70	1529	1455	1455	1455
query71	402	302	309	302
query72	6492	3423	3426	3423
query73	739	323	325	323
query74	6321	5954	5856	5856
query75	4687	3652	3697	3652
query76	4373	1168	1191	1168
query77	528	240	245	240
query78	12572	11439	11823	11439
query79	9397	659	652	652
query80	3057	399	392	392
query81	521	226	224	224
query82	1705	94	96	94
query83	187	138	134	134
query84	250	69	69	69
query85	1366	282	288	282
query86	358	298	291	291
query87	3266	3051	2981	2981
query88	5171	2323	2311	2311
query89	390	286	312	286
query90	1753	201	217	201
query91	158	116	113	113
query92	60	50	47	47
query93	5294	564	540	540
query94	880	209	201	201
query95	1103	1053	1023	1023
query96	642	331	325	325
query97	6405	6440	6387	6387
query98	186	178	168	168
query99	2948	869	963	869
Total cold run time: 321547 ms
Total hot run time: 201579 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.83 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 0c714a7e4b28b9398fb7b8c0aee92055e0eb5841, data reload: false

query1	0.02	0.02	0.02
query2	0.06	0.02	0.02
query3	0.25	0.05	0.06
query4	1.78	0.08	0.07
query5	0.53	0.52	0.52
query6	1.27	0.61	0.62
query7	0.02	0.01	0.02
query8	0.03	0.02	0.02
query9	0.52	0.48	0.49
query10	0.54	0.53	0.53
query11	0.12	0.08	0.09
query12	0.11	0.09	0.09
query13	0.61	0.62	0.60
query14	0.78	0.79	0.78
query15	0.77	0.75	0.76
query16	0.37	0.37	0.35
query17	0.98	1.01	1.02
query18	0.24	0.24	0.22
query19	1.94	1.76	1.84
query20	0.01	0.01	0.00
query21	15.48	0.58	0.57
query22	2.11	2.42	1.62
query23	17.26	0.99	1.00
query24	3.43	1.07	4.49
query25	0.39	0.12	0.05
query26	0.68	0.16	0.14
query27	0.04	0.05	0.04
query28	6.38	0.74	0.71
query29	12.67	2.32	2.35
query30	0.60	0.53	0.54
query31	2.81	0.38	0.37
query32	3.42	0.49	0.49
query33	3.07	3.10	3.10
query34	15.25	4.80	4.79
query35	4.85	4.86	4.82
query36	1.05	1.01	1.02
query37	0.07	0.04	0.05
query38	0.04	0.02	0.02
query39	0.02	0.01	0.01
query40	0.16	0.14	0.14
query41	0.06	0.02	0.01
query42	0.03	0.01	0.01
query43	0.02	0.01	0.02
Total cold run time: 100.84 s
Total hot run time: 30.83 s

@doris-robot
Copy link

Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'

Load test result on commit 0c714a7e4b28b9398fb7b8c0aee92055e0eb5841 with default session variables
Stream load json:         20 seconds loaded 2358488459 Bytes, about 112 MB/s
Stream load orc:          59 seconds loaded 1101869774 Bytes, about 17 MB/s
Stream load parquet:      31 seconds loaded 861443392 Bytes, about 26 MB/s
Insert into select:       20.9 seconds inserted 10000000 Rows, about 478K ops/s

Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels Mar 30, 2024
Copy link
Contributor

PR approved by anyone and no changes requested.

@yiguolei yiguolei merged commit f5a305b into apache:branch-2.0 Mar 30, 2024
27 of 29 checks passed
mongo360 pushed a commit to mongo360/doris that referenced this pull request Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. area/planner Issues or PRs related to the query planner kind/test reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants